From 71a7ba5738798815e74aedd2b26fa4daeb8409a1 Mon Sep 17 00:00:00 2001
From: Dong Anyuan <donganyuan@cn.fujitsu.com>
Date: Tue, 28 May 2019 22:03:19 +0900
Subject: [PATCH] Fix Coverity Scan CID 300415 (Variable ul_report going out of
scope leaks the storage it points to.)
---
openair2/ENB_APP/CONTROL_MODULES/MAC/flexran_agent_mac.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/openair2/ENB_APP/CONTROL_MODULES/MAC/flexran_agent_mac.c b/openair2/ENB_APP/CONTROL_MODULES/MAC/flexran_agent_mac.c
index 23ec58cfab..185427c3de 100644
--- a/openair2/ENB_APP/CONTROL_MODULES/MAC/flexran_agent_mac.c
+++ b/openair2/ENB_APP/CONTROL_MODULES/MAC/flexran_agent_mac.c
@@ -470,6 +470,10 @@ int flexran_agent_mac_stats_reply(mid_t mod_id,
ul_report[j] = malloc(sizeof(Protocol__FlexUlCqi));
if(ul_report[j] == NULL) {
+ for (k = 0; k < j; k++) {
+ free(ul_report[k]);
+ }
+ free(ul_report);
free(full_ul_report);
goto error;
}
@@ -484,6 +488,10 @@ int flexran_agent_mac_stats_reply(mid_t mod_id,
uint32_t *sinr_meas;
sinr_meas = (uint32_t *) malloc(sizeof(uint32_t) * ul_report[j]->n_sinr);
if (sinr_meas == NULL) {
+ for (k = 0; k < j; k++) {
+ free(ul_report[k]);
+ }
+ free(ul_report);
free(full_ul_report);
goto error;
}
--
GitLab