From c41af020a28a8104321b2dea904a3a63f76591f0 Mon Sep 17 00:00:00 2001
From: Dong Anyuan <donganyuan@cn.fujitsu.com>
Date: Tue, 28 May 2019 20:14:25 +0900
Subject: [PATCH] Fix Coverity Scan CID 339932 (Overrunning array
messages_callback of 48 24-byte elements at element index 48 (byte offset
1152) using index pdu.choice.initiatingMessage.procedureCode (which evaluates
to 48).)
---
openair3/S1AP/s1ap_eNB_handlers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/openair3/S1AP/s1ap_eNB_handlers.c b/openair3/S1AP/s1ap_eNB_handlers.c
index 0c3b1ee25b..18c6d98601 100644
--- a/openair3/S1AP/s1ap_eNB_handlers.c
+++ b/openair3/S1AP/s1ap_eNB_handlers.c
@@ -220,7 +220,7 @@ int s1ap_eNB_handle_message(uint32_t assoc_id, int32_t stream,
}
/* Checking procedure Code and direction of message */
- if (pdu.choice.initiatingMessage.procedureCode > sizeof(messages_callback) / (3 * sizeof(
+ if (pdu.choice.initiatingMessage.procedureCode >= sizeof(messages_callback) / (3 * sizeof(
s1ap_message_decoded_callback))
|| (pdu.present > S1AP_S1AP_PDU_PR_unsuccessfulOutcome)) {
S1AP_ERROR("[SCTP %d] Either procedureCode %ld or direction %d exceed expected\n",
--
GitLab