1. 29 Aug, 2017 1 commit
  2. 24 Aug, 2017 1 commit
    • Cedric Roux's avatar
      improve multi-UEs scenario · 622b919b
      Cedric Roux authored
      This commits contains several fixes to improve a multi-UE scenario.
      This is not the end of the story.
      Summary of work:
      1 - improve SR (scheduling requests):
          We configured n1pucch == 3 for scheduling requests, for all
          UEs. We now use 71 - UE_id/10.
          For it to work, it is vital that pucch_nRB_CQI in the configuration
          file is set to 0, otherwise the SR will go to an RB used for
          PUSCH and uplink decoding will fail whenever an UE does SR.
          Note that we will have problems with 20MHz when we use a CCE that
          let the UE send the ACK/NACK using a n1pucch allocated for SR,
          because when the PDCCH is of size 3, we can have 87 CCEs
          and it may lead to an n1pucch colliding with one for SR.
          The work done in this patch is a quick solution, seems to work
          with 10MHz.
          The real solution is to disable the use of those CCEs that would
          lead an UE to use a n1pucch colliding with an SR n1pucch. Then
          we can use whatever n1pucch we want for SR, as long as the
          scheduler protects them.
          Impacted files: configuration files
      2 - some fixes for uplink scheduling:
          - Do not use PRACH for PUSCH, that leads to too many false
          PRACH detection. Plus the PUSCH receiving may fail if one
          UE uses the PRACH at the same time.
          - Take care of retransmissions. That was not done at all, so
          we could allocate one RB to several UEs. The current design
          of the code makes it hard to do it properly, so we chose a
          quick and dirty solution, which is to increase "first_rb"
          to skip any RB used for retransmission. In this process we
          may skip a lot of free RBs. A proper solution is needed here.
          - Do not allocate the last RB. This one is used for PUCCH.
          It was sometimes allocated to PUSCH.
          - In the pre-processor we didn't pre-allocate RBs to UEs
          with an empty buffer status. We didn't check if the UE
          sent an SR. For example in a three UEs scenario, we
          could have the third UE never scheduled in the uplink.
          - rb_table_index was not decreased properly, so we allocated
          too much RBs to some UEs and thus not enough to others.
          Impacted files: openair2/LAYER2/MAC/eNB_scheduler_ulsch.c
      3 - some fixes for downlink scheduling:
          - The check on CCE allocation was not correct. We did something
              if (cce allocation is possible) {
          We should have done:
              save current cce allocation
              if (cce allocation is possible) {
                allocate cce
              reset current cce allocation
          Basically, when we scheduled several UEs, they were checked
          separately, and the totality of them was not checked.
          Impacted file: openair2/LAYER2/MAC/eNB_scheduler_dlsch.c
          - The retransmissions are probably not handled correctly.
          Check in openair2/LAYER2/MAC/pre_processor.c, near
          the comment "// control channel or retransmission",
          the case "round > 0" was added. It's probably not enough,
          even maybe not correct.
          - Change SF05_LIMIT with SF0_LIMIT. We accept to use
          central blocks in SF 5. The code was also not correct,
          vrb_map was not set properly because the loop on j
          was wrong for the last RBG (which can have one less
          RB than the others).
          This is not satisfying. The real solution is to use the
          central RBs and check that the MCS used is compatible
          with the numbers of resource elements allocated (we don't
          want to put too more data bits than what fits).
      4 - some fixes in PUCCH decoding:
          See: openair1/PHY/LTE_TRANSPORT/pucch.c
          Probably not enough. Some more work and analysis is
          required for a proper use of the PUCCH. What we see
          is that the PUCCH constellation gets wrong when there
          are several UEs, meaning the received ACK/NACK is
          not properly decoded (this, or something else...).
      5 - several fixes/checks added here and there:
          - The final allocate_CCEs in eNB_dlsch_ulsch_scheduler
            is checked and we brutally exit if it fails.
          - We exit in get_num_pdcch_symbols in case of failure
            (this should never happen anyway, no big deal normally).
          - Some logs added or changed to error/warning instead
            of debug.
          - In dlsch_scheduler_pre_processor an abort() was added.
            The code here looks suspicious.
          - In assign_max_mcs_min_rb, rb_table_index was not set
            to 2, the value 0 was used. This was not correct.
      What remains to be done:
          - Correct CCE allocation (take into account SR n1pucch,
            check that all the n1pucch that will be used are "compatible").
          - Take into account the PHICH when scheduling uplink. As of
            today it is very possible to have two UEs use the same PHICH
            group and PHICH sequence index. We can use n_DMRS in the DCI
            to have uniqueness (see 36.213 table 9.1.2-2). We can drop an
            allocation if there is no free PHICH group/sequence index for
            a given UE.
          - When there is an uplink retransmission in the PRACH, we have
            to disable PRACH detection. It is possible that one UE does
            PRACH at the same time, but then what to do? We could use
            DCI0-based retransmission in this specific case maybe...
          - Handle free RBs in uplink in a much better way in case of
            a retransmission. We may have a lot of free unused RBs with
            the current code.
          - Check downlink retransmissions. Not much has been done there.
          - Surely more stuff not clear yet. In some situations we don't
            have a good behavior of the system. Hard to describe more
            precisely at this point.
  3. 23 Aug, 2017 2 commits
  4. 22 Aug, 2017 1 commit
  5. 18 Aug, 2017 3 commits
  6. 03 Aug, 2017 2 commits
  7. 31 Jul, 2017 1 commit
    • Cedric Roux's avatar
      bugfix: fix sync for oaisim · 030a3452
      Cedric Roux authored
      With the current implementation of oaisim
      (rxdata and channel simulation), we cannot
      call trx_read_func on a dummy buffer. The
      code will actually modify the rxdata buffers
      of the UE.
      This is has to be rewritten properly. In the
      meantime, let's introduce a simple hack. The
      idea of the read at this point is to wait for
      the synch to finish and not lose samples from
      the hardware in the real UE. In the simulator,
      as it is today, we can simply sleep until the
      synch code has finished its work.
  8. 28 Jul, 2017 1 commit
  9. 26 Jul, 2017 1 commit
  10. 20 Jul, 2017 1 commit
  11. 17 Jul, 2017 2 commits
  12. 06 Jul, 2017 1 commit
  13. 29 Jun, 2017 1 commit
  14. 23 Jun, 2017 3 commits
    • Cedric Roux's avatar
      fix: let run_enb_ue_virt_s1 work with "default" openair-cn · 9adfa48d
      Cedric Roux authored
      - ue mcc/mnc 208.93
      - use correct key/opc for user
      - change addresses in conf file for them to be easier to understand
      With those changes, running:
         sudo ./run_enb_ue_virt_s1
      in cmake_targets/tools should work out of the box
      The user still has to configure correct IP addresses in
      We supposed oaisim (enb+ue) machine to be on IP address
      and EPC (hss, mme, spgw) machine to be on IP address
    • Cedric Roux's avatar
      bladerf: minor: add log for RX overrun · a8ae85f6
      Cedric Roux authored
    • Cedric Roux's avatar
      bladerf: tentative to have it functional · 0da60274
      Cedric Roux authored
      Several problems are present.
      The first is that _write returns 0 instead of the
      number of samples. We solve it by returning
      The second is that _read may return less samples at
      the beginning and we don't want to exit for that.
      We solve it also by returning nsamps.
      (We still need to log more in this, to be done in the
      next commit.)
      The third is that after initialization we don't send
      anything for a while, time for the softmodem to finish
      its init. This generates lots of "RX overrun".
      We solve it by disabling TX and RX modules after init
      and then in trx_brf_start we activate them again (and
      also call bladerf_sync_config, which seems to be
      mandatory, and bladerf_calibrate_dc, which may be avoided,
      Maybe not the end of the story. Sometimes it works, UE connects,
      traffic is fine (tested only with 5MHz). Sometimes it does not,
      UE does not connect, or it connects but then traffic is bad,
      especially uplink.
      To be refined.
  15. 21 Jun, 2017 2 commits
  16. 13 Jun, 2017 1 commit
  17. 06 Jun, 2017 1 commit
  18. 02 Jun, 2017 4 commits
    • Cedric Roux's avatar
      integration fixes · 60c4b5ec
      Cedric Roux authored
      - rename UE_NO_LOG to DISABLE_LOG_X
        because the name is misleading. The full software
        is impacted, not only the UE part
      - same for compilation option ---ue-no-log
        that becomes --disable-log
      - keep LOG_X for the standard case, that is the
        case without DISABLE_LOG_X where printf has been
        put. Two reasons:
        * printf is not realtime friendly
        * keep behavior similar for other users who may
          be troubled by different logs that don't add
          any benefit to previous logs
    • Cedric Roux's avatar
      change port ENB_PORT_FOR_S1U in config files · d7e5e319
      Cedric Roux authored
      The port to use should be 2152, not 2153.
    • tctalcatel's avatar
      Remove not used conf file · 56743415
      tctalcatel authored
    • tctalcatel's avatar
      UE autotest, adding TDD tests · 32a330a4
      tctalcatel authored
  19. 31 May, 2017 2 commits
  20. 22 May, 2017 3 commits
  21. 19 May, 2017 1 commit
    • Gabriel's avatar
      UE logging change : · fe350d5b
      Gabriel authored
      --ue-trace : Enabling UE trace for debug
      --ue-timing : Enabling UE timing trace
      --ue-no-log : Disabling all LOG_X traces
  22. 18 May, 2017 2 commits
    • Cedric Roux's avatar
      warnings removal in LOG_X · 9d65f4dd
      Cedric Roux authored
      those popped up thanks to previous commit
    • Cedric Roux's avatar
      improve logging in oaisim · 5e323eef
      Cedric Roux authored
      - print current working directory
      - print git version (if available)
      - print security keys
        this last one is a security breach, but as of today
        it's not a problem
  23. 15 May, 2017 1 commit
  24. 12 May, 2017 2 commits
    • Gabriel's avatar
      bug fixes from Fujitsu (bug 29) · 893f36e8
      Gabriel authored
      bug 29
      FDD should be TDD.
      Bug Location:
        switch (oai_emulation.info.frame_type[0]) {
        case FDD:
          frame_type = "FDD";
        case TDD:
          frame_type = "FDD";
    • Gabriel's avatar
      bug fixes from Fujitsu (bugs 18, 19, 20) · bdaef795
      Gabriel authored
      bug 18
      Probably he/she wants to copy the contents of arrays, but
      this coding doesn't copy anything, moreover index overflow
      Bug Location:
      Detected by CppCheck
      bug 19
      Probably he/she wants to copy the contents of arrays, but
      this coding doesn't copy anything, moreover index overflow
      Bug Location:
      Detected by CppCheck
      bug 20
      Probably he/she wants to copy the contents of arrays, but
      this coding doesn't copy anything, moreover index overflow
      Bug Location:
      Detected by CppCheck