From 2d987a07b7cb79cb99705ec854ebc802515fb354 Mon Sep 17 00:00:00 2001 From: Raphael Defosseux <raphael.defosseux@openairinterface.org> Date: Fri, 24 May 2024 16:00:37 +0200 Subject: [PATCH] chore(ci): post-review comment Signed-off-by: Raphael Defosseux <raphael.defosseux@openairinterface.org> --- src/oai_pcf/main.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/oai_pcf/main.cpp b/src/oai_pcf/main.cpp index 9704119..e6f085b 100644 --- a/src/oai_pcf/main.cpp +++ b/src/oai_pcf/main.cpp @@ -36,10 +36,7 @@ using namespace oai::pcf::api; using namespace oai::config; -std::unique_ptr<pcf_app> pcf_app_inst = nullptr; -// TODO Stefan: I am not happy with these global variables -// We could make a singleton getInstance in config -// or we handle everything in smf_app init and have a reference to config there +std::unique_ptr<pcf_app> pcf_app_inst = nullptr; std::unique_ptr<pcf_config> pcf_cfg = nullptr; std::unique_ptr<PCFApiServer> pcf_api_server_1 = nullptr; std::unique_ptr<pcf_http2_server> pcf_api_server_2 = nullptr; -- GitLab