Skip to content
  • Brian Kim's avatar
    ODROID-XU3/4: Clean up the compiler warning messages · 40072ad6
    Brian Kim authored
    This patch fix the routines caused to output the warning message in compile time as below:
    - gcc version: gcc version 4.9.2 20140904 (prerelease) (crosstool-NG linaro-1.13.1-4.9-2014.09 - Linaro GCC 4.9-2014.09)
    
    drivers/cpufreq/cpufreq_interactive.c: In function ‘show_target_loads’:
    drivers/cpufreq/cpufreq_interactive.c:805:6: warning: operation on ‘ret’ may be undefined [-Wsequence-point]
      ret += sprintf(buf + --ret, "\n");
          ^
    drivers/cpufreq/cpufreq_interactive.c: In function ‘show_above_hispeed_delay’:
    drivers/cpufreq/cpufreq_interactive.c:845:6: warning: operation on ‘ret’ may be undefined [-Wsequence-point]
      ret += sprintf(buf + --ret, "\n");
          ^
    drivers/devfreq/exynos5422_bus_int.c: In function ‘exynos5_int_busfreq_target’:
    drivers/devfreq/exynos5422_bus_int.c:945:6: warning: unused variable ‘i’ [-Wunused-variable]
      int i, target_idx = LV_0;
          ^
    drivers/devfreq/exynos5422_bus_int.c: In function ‘exynos5_devfreq_int_probe’:
    drivers/devfreq/exynos5422_bus_int.c:1241:6: warning: unused variable ‘i’ [-Wunused-variable]
      int i, index = -1;
          ^
    drivers/devfreq/exynos5422_bus_int.c: In function ‘int_show_state’:
    drivers/devfreq/exynos5422_bus_int.c:1121:10: warning: iteration 1u invokes undefined behavior [-Waggressive-loop-optimizations]
       len += snprintf(buf + len, write_cnt, "%ld %llu\n", int_bus_opp_list[i].freq,
              ^
    drivers/devfreq/exynos5422_bus_int.c:1120:2: note: containing loop
      for (i = LV_0; i < LV_END; i++)
      ^
    sound/soc/samsung/lpass.c: In function ‘lpass_proc_show’:
    sound/soc/samsung/lpass.c:718:5: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 3 has type ‘void *’ [-Wformat=]
         ar->reg, ar->val);
         ^
    In file included from backports/drivers/net/wireless/ath/ath10k/debug.c:19:0:
    backports/backport-include/linux/debugfs.h:11:10: warning: ‘struct device’ declared inside parameter list
              void *data));
              ^
    backports/backport-include/linux/debugfs.h:11:10: warning: its scope is only this definition or declaration, which is probably not what you want
    In file included from backports/drivers/net/wireless/ath/wcn36xx/debug.c:19:0:
    backports/backport-include/linux/debugfs.h:11:10: warning: ‘struct device’ declared inside parameter list
              void *data));
              ^
    backports/backport-include/linux/debugfs.h:11:10: warning: its scope is only this definition or declaration, which is probably not what you want
    backports/drivers/realtek/8192cu/hal/rtl8192c/rtl8192c_rf6052.c: In function ‘PHY_RFShadowRefresh’:
    backports/drivers/realtek/8192cu/hal/rtl8192c/rtl8192c_rf6052.c:1020:37: warning: iteration 63u invokes undefined behavior [-Waggressive-loop-optimizations]
        RF_Shadow[eRFPath][Offset].Value = 0;
                                         ^
    backports/drivers/realtek/8192cu/hal/rtl8192c/rtl8192c_rf6052.c:1018:3: note: containing loop
       for (Offset = 0; Offset <= RF6052_MAX_REG; Offset++)
       ^
    drivers/gpu/drm/exynos/exynos_drm_drv.c: In function ‘exynos_drm_init’:
    drivers/gpu/drm/exynos/exynos_drm_drv.c:768:1: warning: label ‘err_unregister_pd’ defined but not used [-Wunused-label]
     err_unregister_pd:
     ^
    net/core/sysctl_net_core.c:24:12: warning: ‘one’ defined but not used [-Wunused-variable]
     static int one = 1;
                ^
    drivers/gpu/drm/exynos/exynos_hdmi.c: In function ‘hdmi_hpd_enable’:
    drivers/gpu/drm/exynos/exynos_hdmi.c:233:27: warning: passing argument 3 of ‘kstrtoul’ from incompatible pointer type
         if(kstrtoul(line, 10, &gEnableHPD) != 0)    gEnableHPD = true;
                               ^
    In file included from include/drm/drmP.h:45:0,
                     from drivers/gpu/drm/exynos/exynos_hdmi.c:17:
    include/linux/kernel.h:255:32: note: expected ‘long unsigned int *’ but argument is of type ‘unsigned int *’
     static inline int __must_check kstrtoul(const char *s, unsigned int base, unsigned long *res)
                                    ^
    drivers/gpu/drm/exynos/exynos_hdmi.c: At top level:
    drivers/gpu/drm/exynos/exynos_hdmi.c:1985:13: warning: ‘hdmiphy_poweroff’ defined but not used [-Wunused-function]
     static void hdmiphy_poweroff(struct hdmi_context *hdata)
                 ^
    drivers/hardkernel/ioboard-spi.c:223:12: warning: ‘ioboard_spi_read_memory’ defined but not used [-Wunused-function]
     static int ioboard_spi_read_memory              (struct spi_device *spi, unsigned int addr, unsigned char *rdata, unsigned int size)
                ^
    drivers/hardkernel/ioboard-spi.c:329:13: warning: ‘ioboard_spi_test’ defined but not used [-Wunused-function]
     static void ioboard_spi_test        (struct spi_device *spi)
                 ^
    drivers/hid/hid-appleir.c:347:22: warning: initialization from incompatible pointer type
      .input_configured = appleir_input_configured,
                          ^
    drivers/hid/hid-appleir.c:347:22: warning: (near initialization for ‘appleir_driver.input_configured’)
    In file included from backports/net/wireless/core.c:16:0:
    backports/backport-include/linux/debugfs.h:11:10: warning: ‘struct device’ declared inside parameter list
              void *data));
              ^
    backports/backport-include/linux/debugfs.h:11:10: warning: its scope is only this definition or declaration, which is probably not what you want
    drivers/hid/hid-magicmouse.c:590:22: warning: initialization from incompatible pointer type
      .input_configured = magicmouse_input_configured,
                          ^
    drivers/hid/hid-magicmouse.c:590:22: warning: (near initialization for ‘magicmouse_driver.input_configured’)
    drivers/hid/hid-ntrig.c:1026:22: warning: initialization from incompatible pointer type
      .input_configured = ntrig_input_configured,
                          ^
    drivers/hid/hid-ntrig.c:1026:22: warning: (near initialization for ‘ntrig_driver.input_configured’)
    backports/drivers/realtek/rtl8192du/os_dep/ioctl_cfg80211.c:3580:17: warning: initialization from incompatible pointer type
      .get_station = cfg80211_rtw_get_station,
                     ^
    backports/drivers/realtek/rtl8192du/os_dep/ioctl_cfg80211.c:3580:17: warning: (near initialization for ‘rtw_cfg80211_ops.get_station’)
    backports/drivers/realtek/rtl8192du/os_dep/ioctl_cfg80211.c:3608:17: warning: initialization from incompatible pointer type
      .add_station = cfg80211_rtw_add_station,
                     ^
    backports/drivers/realtek/rtl8192du/os_dep/ioctl_cfg80211.c:3608:17: warning: (near initialization for ‘rtw_cfg80211_ops.add_station’)
    backports/drivers/realtek/rtl8192du/os_dep/ioctl_cfg80211.c:3609:17: warning: initialization from incompatible pointer type
      .del_station = cfg80211_rtw_del_station,
                     ^
    backports/drivers/realtek/rtl8192du/os_dep/ioctl_cfg80211.c:3609:17: warning: (near initialization for ‘rtw_cfg80211_ops.del_station’)
    backports/drivers/realtek/rtl8192du/os_dep/ioctl_cfg80211.c:3610:20: warning: initialization from incompatible pointer type
      .change_station = cfg80211_rtw_change_station,
                        ^
    backports/drivers/realtek/rtl8192du/os_dep/ioctl_cfg80211.c:3610:20: warning: (near initialization for ‘rtw_cfg80211_ops.change_station’)
    backports/drivers/realtek/rtl8192du/os_dep/ioctl_cfg80211.c:3617:13: warning: initialization from incompatible pointer type
      .mgmt_tx = cfg80211_rtw_mgmt_tx,
                 ^
    backports/drivers/realtek/rtl8192du/os_dep/ioctl_cfg80211.c:3617:13: warning: (near initialization for ‘rtw_cfg80211_ops.mgmt_tx’)
    net/rfkill/rfkill-regulator.c: In function ‘rfkill_regulator_set_block’:
    net/rfkill/rfkill-regulator.c:43:4: warning: ignoring return value of ‘regulator_enable’, declared with attribute warn_unused_result [-Wunused-result]
        regulator_enable(rfkill_data->vcc);
        ^
    drivers/media/platform/exynos/mfc/s5p_mfc.c:2108:28: warning: ‘s5p_mfc_dec_drm_videodev’ defined but not used [-Wunused-variable]
     static struct video_device s5p_mfc_dec_drm_videodev = {
                                ^
    drivers/media/platform/exynos/mfc/s5p_mfc.c:2115:28: warning: ‘s5p_mfc_enc_drm_videodev’ defined but not used [-Wunused-variable]
     static struct video_device s5p_mfc_enc_drm_videodev = {
                                ^
    fs/binfmt_misc.c: In function ‘parse_command.part.1’:
    fs/binfmt_misc.c:405:7: warning: array subscript is above array bounds [-Warray-bounds]
      if (s[count-1] == '\n')
           ^
    drivers/usb/host/xhci.c: In function ‘xhci_free_dev’:
    drivers/usb/host/xhci.c:3506:17: warning: unused variable ‘dev’ [-Wunused-variable]
      struct device *dev = hcd->self.controller;
                     ^
    drivers/usb/host/xhci.c: In function ‘xhci_alloc_dev’:
    drivers/usb/host/xhci.c:3592:17: warning: unused variable ‘dev’ [-Wunused-variable]
      struct device *dev = hcd->self.controller;
                     ^
    drivers/usb/host/xhci-plat.c: In function ‘xhci_plat_probe’:
    drivers/usb/host/xhci-plat.c:156:4: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
        extern void samsung_usb3phy_retune(int);
        ^
    arch/arm/boot/compressed/atags_to_fdt.c: In function ‘merge_fdt_bootargs’:
    arch/arm/boot/compressed/atags_to_fdt.c:96:1: warning: the frame size of 1032 bytes is larger than 1024 bytes [-Wframe-larger-than=]
     }
     ^
    
    Change-Id: I646d4470fecdef67da42bcff549a2dc3632c68cd
    40072ad6