• Arjan van de Ven's avatar
    mark sys_open/sys_read exports unused · cb51f973
    Arjan van de Ven authored
    sys_open / sys_read were used in the early 1.2 days to load firmware from
    disk inside drivers.  Since 2.0 or so this was deprecated behavior, but
    several drivers still were using this.  Since a few years we have a
    request_firmware() API that implements this in a nice, consistent way.
    Only some old ISA sound drivers (pre-ALSA) still straggled along for some
    time....  however with commit c2b1239a the
    last user is now gone.
    This is a good thing, since using sys_open / sys_read etc for firmware is a
    very buggy to dangerous thing to do; these operations put an fd in the
    process file descriptor table....  which then can be tampered with from
    other threads for example.  For those who don't want the firmware loader,
    filp_open()/vfs_read are the better APIs to use, without this security
    The patch below marks sys_open and sys_read unused now that they're
    really not used anymore, and for deletion in the 2.6.25 timeframe.
    Signed-off-by: default avatarArjan van de Ven <arjan@linux.intel.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
open.c 26.2 KB