Commit 4fd8da8d authored by Heiko Carstens's avatar Heiko Carstens Committed by Linus Torvalds

fs: change sys_truncate length parameter type

For this system call user space passes a signed long length parameter,
while the kernel side takes an unsigned long parameter and converts it
later to signed long again.

This has led to bugs in compat wrappers see e.g.  dd90bbd5 "powerpc: Add
compat_sys_truncate".  The s390 compat wrapper for this functions is
broken as well since it also performs zero extension instead of sign
extension for the length parameter.

In addition if hpa comes up with an automated way of generating
compat wrappers it would generate a wrong one here.

So change the length parameter from unsigned long to long.

Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: default avatarHeiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent a6e995ad
...@@ -290,10 +290,9 @@ out: ...@@ -290,10 +290,9 @@ out:
return error; return error;
} }
SYSCALL_DEFINE2(truncate, const char __user *, path, unsigned long, length) SYSCALL_DEFINE2(truncate, const char __user *, path, long, length)
{ {
/* on 32-bit boxen it will cut the range 2^31--2^32-1 off */ return do_sys_truncate(path, length);
return do_sys_truncate(path, (long)length);
} }
static long do_sys_ftruncate(unsigned int fd, loff_t length, int small) static long do_sys_ftruncate(unsigned int fd, loff_t length, int small)
......
...@@ -460,8 +460,7 @@ asmlinkage long sys_mount(char __user *dev_name, char __user *dir_name, ...@@ -460,8 +460,7 @@ asmlinkage long sys_mount(char __user *dev_name, char __user *dir_name,
void __user *data); void __user *data);
asmlinkage long sys_umount(char __user *name, int flags); asmlinkage long sys_umount(char __user *name, int flags);
asmlinkage long sys_oldumount(char __user *name); asmlinkage long sys_oldumount(char __user *name);
asmlinkage long sys_truncate(const char __user *path, asmlinkage long sys_truncate(const char __user *path, long length);
unsigned long length);
asmlinkage long sys_ftruncate(unsigned int fd, unsigned long length); asmlinkage long sys_ftruncate(unsigned int fd, unsigned long length);
asmlinkage long sys_stat(char __user *filename, asmlinkage long sys_stat(char __user *filename,
struct __old_kernel_stat __user *statbuf); struct __old_kernel_stat __user *statbuf);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment