Commit 901b74a3 authored by Jingoo Han's avatar Jingoo Han Committed by Bryan Wu

leds: renesas: set gpio_request_one() flags param correctly

The gpio_request_one() flags parameter was set to:

  GPIOF_DIR_OUT | !!brightness

GPIOF_DIR_OUT and GPIOF_DIR_IN are defined as below:
  GPIOF_DIR_OUT   (0 << 0)
  GPIOF_DIR_IN    (1 << 0)

So, when '!!brightness' is 1, the gpio pin can be set as input,
instead of output.

To prevent this problem, GPIOF_OUT_INIT flags should be used when
using gpio_request_one().
Signed-off-by: default avatarJingoo Han <>
Signed-off-by: default avatarBryan Wu <>
parent 9d04cbaa
......@@ -205,7 +205,8 @@ static void r_tpu_set_pin(struct r_tpu_priv *p, enum r_tpu_pin new_state,
if (new_state == R_TPU_PIN_GPIO)
gpio_request_one(cfg->pin_gpio, GPIOF_DIR_OUT | !!brightness,
gpio_request_one(cfg->pin_gpio, !!brightness ?
if (new_state == R_TPU_PIN_GPIO_FN)
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment