Commit a9c62a18 authored by Alan Cox's avatar Alan Cox Committed by Linus Torvalds

fs: correct SuS compliance for open of large file without options

The early LFS work that Linux uses favours EFBIG in various places. SuSv3
specifically uses EOVERFLOW for this as noted by Michael (Bug 7253)

    The named file is a regular file and the size of the file cannot be
represented correctly in an object of type off_t. We should therefore
transition to the proper error return code
Signed-off-by: default avatarAlan Cox <>
Cc: Theodore Tso <>
Cc: Jens Axboe <>
Cc: Arjan van de Ven <>
Signed-off-by: default avatarAndrew Morton <>
Signed-off-by: default avatarLinus Torvalds <>
parent 28e3fed8
......@@ -406,7 +406,7 @@ static int gfs2_open(struct inode *inode, struct file *file)
if (!(file->f_flags & O_LARGEFILE) &&
ip->i_di.di_size > MAX_NON_LFS) {
error = -EFBIG;
error = -EOVERFLOW;
goto fail_gunlock;
......@@ -61,7 +61,7 @@ static int ntfs_file_open(struct inode *vi, struct file *filp)
if (sizeof(unsigned long) < 8) {
if (i_size_read(vi) > MAX_LFS_FILESIZE)
return -EFBIG;
return -EOVERFLOW;
return generic_file_open(vi, filp);
......@@ -1177,7 +1177,7 @@ asmlinkage long sys_vhangup(void)
int generic_file_open(struct inode * inode, struct file * filp)
if (!(filp->f_flags & O_LARGEFILE) && i_size_read(inode) > MAX_NON_LFS)
return -EFBIG;
return -EOVERFLOW;
return 0;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment