Commit c3c4f694 authored by Al Viro's avatar Al Viro

do_dentry_open(): close the race with mark_files_ro() in failure exit

we want to take it out of mark_files_ro() reach *before* we start
checking if we ought to drop write access.
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent 85d7d618
......@@ -727,6 +727,7 @@ static int do_dentry_open(struct file *f,
cleanup_all:
fops_put(f->f_op);
file_sb_list_del(f);
if (f->f_mode & FMODE_WRITE) {
put_write_access(inode);
if (!special_file(inode->i_mode)) {
......@@ -740,7 +741,6 @@ cleanup_all:
mnt_drop_write(f->f_path.mnt);
}
}
file_sb_list_del(f);
cleanup_file:
path_put(&f->f_path);
f->f_path.mnt = NULL;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment