Commit e19f247a authored by Oren Laadan's avatar Oren Laadan Committed by Linus Torvalds
Browse files

[PATCH] setpgid: should work for sub-threads

setsid() does not work unless the calling process is a

'man setpgid' does not tell anything about that, so I consider this
behaviour is a bug.
Signed-off-by: default avatarOren Laadan <>
Cc: Oleg Nesterov <>
Cc: Roland McGrath <>
Signed-off-by: default avatarAndrew Morton <>
Signed-off-by: default avatarLinus Torvalds <>
parent ee0acf90
......@@ -257,7 +257,7 @@ static inline void reparent_to_init(void)
void __set_special_pids(pid_t session, pid_t pgrp)
struct task_struct *curr = current;
struct task_struct *curr = current->group_leader;
if (curr->signal->session != session) {
detach_pid(curr, PIDTYPE_SID);
......@@ -1215,24 +1215,22 @@ asmlinkage long sys_getsid(pid_t pid)
asmlinkage long sys_setsid(void)
struct task_struct *group_leader = current->group_leader;
struct pid *pid;
int err = -EPERM;
if (!thread_group_leader(current))
return -EINVAL;
pid = find_pid(PIDTYPE_PGID, current->pid);
pid = find_pid(PIDTYPE_PGID, group_leader->pid);
if (pid)
goto out;
current->signal->leader = 1;
__set_special_pids(current->pid, current->pid);
current->signal->tty = NULL;
current->signal->tty_old_pgrp = 0;
err = process_group(current);
group_leader->signal->leader = 1;
__set_special_pids(group_leader->pid, group_leader->pid);
group_leader->signal->tty = NULL;
group_leader->signal->tty_old_pgrp = 0;
err = process_group(group_leader);
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment