Commit e68726ff authored by Miklos Szeredi's avatar Miklos Szeredi

vfs: canonicalize create mode in build_open_flags()

Userspace can pass weird create mode in open(2) that we canonicalize to 
"(mode & S_IALLUGO) | S_IFREG" in vfs_create().

The problem is that we use the uncanonicalized mode before calling vfs_create()
with unforseen consequences.

So do the canonicalization early in build_open_flags().
Signed-off-by: default avatarMiklos Szeredi <>
Tested-by: default avatarRichard W.M. Jones <>
parent ddf343f6
......@@ -852,9 +852,10 @@ static inline int build_open_flags(int flags, umode_t mode, struct open_flags *o
int lookup_flags = 0;
int acc_mode;
if (!(flags & O_CREAT))
mode = 0;
op->mode = mode;
if (flags & O_CREAT)
op->mode = (mode & S_IALLUGO) | S_IFREG;
op->mode = 0;
/* Must never be set by userspace */
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment