1. 07 Dec, 2012 1 commit
  2. 22 Aug, 2012 1 commit
  3. 31 Jan, 2012 1 commit
  4. 31 Oct, 2011 1 commit
  5. 24 Oct, 2011 1 commit
  6. 06 Jun, 2011 1 commit
  7. 20 May, 2011 1 commit
  8. 30 Mar, 2010 1 commit
    • Tejun Heo's avatar
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo authored
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      Guess-its-ok-by: default avatarChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  9. 09 Feb, 2010 1 commit
  10. 17 Dec, 2009 1 commit
  11. 15 Dec, 2009 1 commit
  12. 23 Sep, 2009 4 commits
  13. 21 Sep, 2009 1 commit
  14. 18 Aug, 2009 2 commits
  15. 18 Jun, 2009 2 commits
  16. 06 Jan, 2009 1 commit
  17. 30 Oct, 2008 1 commit
  18. 16 Oct, 2008 1 commit
  19. 13 Sep, 2008 1 commit
  20. 07 Aug, 2008 2 commits
  21. 04 Aug, 2008 1 commit
  22. 28 Jul, 2008 1 commit
  23. 01 May, 2008 1 commit
  24. 28 Apr, 2008 1 commit
  25. 16 Apr, 2008 3 commits
  26. 11 Apr, 2008 1 commit
  27. 06 Feb, 2008 1 commit
  28. 16 Oct, 2007 1 commit
    • David Brownell's avatar
      SPI driver runtime footprint shrinkage · d1e44d9c
      David Brownell authored
      Shrink the runtime footprint of various SPI drivers:
      
        - Move the probe() routine into the init section where practical,
          using platform_driver_probe() to make that safe.  This often saves
          around 1KB.  Using platform_driver_probe() can also be a correctness
          fix, if the probe routine is already marked __init but the driver
          struct keeps a dangling pointer to it after init section removal.
      
        - Likewise move remove() routines into the exit sections.
      
      These changes would be inappropriate iff the platform devices were
      actually hotpluggable (e.g. they're found on optional addon cards,
      or in an FPGA that's dynamically reprogrammed).  In these cases,
      that's not the situation; it's an SOC controller and the only device
      is initialized before these drivers.
      Signed-off-by: default avatarDavid Brownell <dbrownell@users.sourceforge.net>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      d1e44d9c
  29. 31 Aug, 2007 1 commit
    • David Brownell's avatar
      SPI driver hotplug/coldplug fixes · fc3ba952
      David Brownell authored
      Update various SPI drivers so they properly support
      
        - coldplug through "modprobe $(cat /sys/devices/.../modalias)"
      
        - hotplug through "modprobe $(MODALIAS)"
      
      The basic rule for platform, SPI, and (new style) I2C drivers is just
      to make sure that modprobing the driver name works.  In this case, all
      the relevant drivers are platform drivers, and this patch either
      
        (a)	Changes the driver name, if no in-tree code would break;
      	this is simpler and thus preferable in the long term.
      
        (b)	Adds MODULE_ALIAS directives, when in-tree platforms declare
      	devices using the current driver name; less desirable.
      
      Most systems will link SPI controller drivers statically, but
      there's no point in being needlessly broken.
      Signed-off-by: default avatarDavid Brownell <dbrownell@users.sourceforge.net>
      Cc: Jean Delvare <khali@linux-fr.org>
      Acked-by: default avatarAndrei Konovalov <akonovalov@ru.mvista.com>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      fc3ba952
  30. 26 Jul, 2007 1 commit
  31. 17 Jul, 2007 1 commit
  32. 07 May, 2007 1 commit