Skip to content
  • Kay Sievers's avatar
    driver: dont update dev_name via device_add path · 8a577ffc
    Kay Sievers authored
    
    
    notice one system /proc/iomem some entries missed the name for pci_devices
    
    it turns that dev->dev.kobj name is changed after device_add.
    
    for pci code: via acpi_pci_root_driver.ops.add (aka acpi_pci_root_add)
    ==> pci_acpi_scan_root is used to scan pci bus/device, and at the same
    time we read the resource for pci_dev in the pci_read_bases, we have
    res->name = pci_name(pci_dev); pci_name is calling dev_name.
    
    later via acpi_pci_root_driver.ops.start (aka acpi_pci_root_start) ==>
    pci_bus_add_device to add all pci_dev in kobj tree.  pci_bus_add_device
    will call device_add.
    
    actually in device_add
    
            /* first, register with generic layer. */
            error = kobject_add(&dev->kobj, dev->kobj.parent, "%s", dev_name(dev));
            if (error)
                    goto Error;
    
    will get one new name for that kobj, old name is freed.
    
    [Impact: fix corrupted names in /proc/iomem ]
    
    Signed-off-by: default avatarYinghai Lu <yinghai@kernel.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    8a577ffc