Skip to content
  • Christian Lamparter's avatar
    pcmcia: move unbind/rebind into dev_pm_ops.complete · 42b5dd51
    Christian Lamparter authored
    Move the device rebind procedures for cardbus devices from the pm.resume
    into the pm.complete callback.
    
    The reason for moving the code is: "[...] The PM code needs to send
    suspend and resume messages to every device in the right order, and it
    can't do that if new devices are being added at the same time.  [...]"
    
    However the situation really isn't quite that rigid.  In particular,
    adding new children during a resume callback shouldn't cause much of
    problem because the children don't need to be resumed anyway (since they
    were never suspended).  On the other hand, if you do it you will get a
    dev_warn() from the PM core, something like 'parent should not be
    sleeping'.
    
    Still, it is considered bad form and should be avoided if possible."
    
    (Alan Stern's full comment about the topic can
    be found here: <https://lkml.org/lkml/2012/7/10/254
    
    >)
    
    Signed-off-by: default avatarChristian Lamparter <chunkeey@googlemail.com>
    Cc: Dominik Brodowski <linux@dominikbrodowski.net>
    Cc: Alan Stern <stern@rowland.harvard.edu>
    Cc: Greg KH <greg@kroah.com>
    Acked-by: default avatar"Rafael J. Wysocki" <rjw@sisk.pl>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    42b5dd51