• Yongqiang Yang's avatar
    jbd: clear revoked flag on buffers before a new transaction started · 8c111b3f
    Yongqiang Yang authored
    Currently, we clear revoked flag only when a block is reused.  However,
    this can tigger a false journal error.  Consider a situation when a block
    is used as a meta block and is deleted(revoked) in ordered mode, then the
    block is allocated as a data block to a file.  At this moment, user changes
    the file's journal mode from ordered to journaled and truncates the file.
    The block will be considered re-revoked by journal because it has revoked
    flag still pending from the last transaction and an assertion triggers.
    We fix the problem by keeping the revoked status more uptodate - we clear
    revoked flag when switching revoke tables to reflect there is no revoked
    buffers in current transaction any more.
    Signed-off-by: default avatarYongqiang Yang <xiaoqiangnk@gmail.com>
    Signed-off-by: default avatarJan Kara <jack@suse.cz>
revoke.c 21.3 KB