• Linus Torvalds's avatar
    Revert "ACPI: ignore FADT reset-reg-sup flag" · 19244ad0
    Linus Torvalds authored
    This reverts commit cf450136.
    It breaks reboot on at least one Thinkpad T43, as reported by Jörg Otte:
     "On reboot it shuts down as normal.
      The last lines displayed are:
      >Unmounting temporary filesystems.. [OK]
      >Deactivating swap...               [OK]
      >Unmounting local filesystems...    [OK]
      >Will now restart
      >    Restarting system
      Then I hear it accessing the cd-drive, but then it's being stuck."
    Jörg bisected the regression to this commit.
    That commit fixes another machine (see
    for details) that has a BIOS bug and doesn't support ACPI reset.
    However, at least one of those other reporters no longer even has the
    machine in question, and had a different workaround to begin with.
    Besides, it clearly was a buggy BIOS.  Let's not break the correct case
    to fix that case.
    Reported-and-bisected-by: default avatarJörg Otte <jrg.otte@googlemail.com>
    Cc: linux-acpi@vger.kernel.org
    Cc: Len Brown <lenb@kernel.org>
    Cc: Peter Anvin <hpa@zytor.com>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
reboot.c 1.34 KB