1. 08 Oct, 2015 1 commit
    • Brian Kim's avatar
      ODROID-XU3/4: Clean up the compiler warning messages · 40072ad6
      Brian Kim authored
      This patch fix the routines caused to output the warning message in compile time as below:
      - gcc version: gcc version 4.9.2 20140904 (prerelease) (crosstool-NG linaro-1.13.1-4.9-2014.09 - Linaro GCC 4.9-2014.09)
      
      drivers/cpufreq/cpufreq_interactive.c: In function ‘show_target_loads’:
      drivers/cpufreq/cpufreq_interactive.c:805:6: warning: operation on ‘ret’ may be undefined [-Wsequence-point]
        ret += sprintf(buf + --ret, "\n");
            ^
      drivers/cpufreq/cpufreq_interactive.c: In function ‘show_above_hispeed_delay’:
      drivers/cpufreq/cpufreq_interactive.c:845:6: warning: operation on ‘ret’ may be undefined [-Wsequence-point]
        ret += sprintf(buf + --ret, "\n");
            ^
      drivers/devfreq/exynos5422_bus_int.c: In function ‘exynos5_int_busfreq_target’:
      drivers/devfreq/exynos5422_bus_int.c:945:6: warning: unused variable ‘i’ [-Wunused-variable]
        int i, target_idx = LV_0;
            ^
      drivers/devfreq/exynos5422_bus_int.c: In function ‘exynos5_devfreq_int_probe’:
      drivers/devfreq/exynos5422_bus_int.c:1241:6: warning: unused variable ‘i’ [-Wunused-variable]
        int i, index = -1;
            ^
      drivers/devfreq/exynos5422_bus_int.c: In function ‘int_show_state’:
      drivers/devfreq/exynos5422_bus_int.c:1121:10: warning: iteration 1u invokes undefined behavior [-Waggressive-loop-optimizations]
         len += snprintf(buf + len, write_cnt, "%ld %llu\n", int_bus_opp_list[i].freq,
                ^
      drivers/devfreq/exynos5422_bus_int.c:1120:2: note: containing loop
        for (i = LV_0; i < LV_END; i++)
        ^
      sound/soc/samsung/lpass.c: In function ‘lpass_proc_show’:
      sound/soc/samsung/lpass.c:718:5: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 3 has type ‘void *’ [-Wformat=]
           ar->reg, ar->val);
           ^
      In file included from backports/drivers/net/wireless/ath/ath10k/debug.c:19:0:
      backports/backport-include/linux/debugfs.h:11:10: warning: ‘struct device’ declared inside parameter list
                void *data));
                ^
      backports/backport-include/linux/debugfs.h:11:10: warning: its scope is only this definition or declaration, which is probably not what you want
      In file included from backports/drivers/net/wireless/ath/wcn36xx/debug.c:19:0:
      backports/backport-include/linux/debugfs.h:11:10: warning: ‘struct device’ declared inside parameter list
                void *data));
                ^
      backports/backport-include/linux/debugfs.h:11:10: warning: its scope is only this definition or declaration, which is probably not what you want
      backports/drivers/realtek/8192cu/hal/rtl8192c/rtl8192c_rf6052.c: In function ‘PHY_RFShadowRefresh’:
      backports/drivers/realtek/8192cu/hal/rtl8192c/rtl8192c_rf6052.c:1020:37: warning: iteration 63u invokes undefined behavior [-Waggressive-loop-optimizations]
          RF_Shadow[eRFPath][Offset].Value = 0;
                                           ^
      backports/drivers/realtek/8192cu/hal/rtl8192c/rtl8192c_rf6052.c:1018:3: note: containing loop
         for (Offset = 0; Offset <= RF6052_MAX_REG; Offset++)
         ^
      drivers/gpu/drm/exynos/exynos_drm_drv.c: In function ‘exynos_drm_init’:
      drivers/gpu/drm/exynos/exynos_drm_drv.c:768:1: warning: label ‘err_unregister_pd’ defined but not used [-Wunused-label]
       err_unregister_pd:
       ^
      net/core/sysctl_net_core.c:24:12: warning: ‘one’ defined but not used [-Wunused-variable]
       static int one = 1;
                  ^
      drivers/gpu/drm/exynos/exynos_hdmi.c: In function ‘hdmi_hpd_enable’:
      drivers/gpu/drm/exynos/exynos_hdmi.c:233:27: warning: passing argument 3 of ‘kstrtoul’ from incompatible pointer type
           if(kstrtoul(line, 10, &gEnableHPD) != 0)    gEnableHPD = true;
                                 ^
      In file included from include/drm/drmP.h:45:0,
                       from drivers/gpu/drm/exynos/exynos_hdmi.c:17:
      include/linux/kernel.h:255:32: note: expected ‘long unsigned int *’ but argument is of type ‘unsigned int *’
       static inline int __must_check kstrtoul(const char *s, unsigned int base, unsigned long *res)
                                      ^
      drivers/gpu/drm/exynos/exynos_hdmi.c: At top level:
      drivers/gpu/drm/exynos/exynos_hdmi.c:1985:13: warning: ‘hdmiphy_poweroff’ defined but not used [-Wunused-function]
       static void hdmiphy_poweroff(struct hdmi_context *hdata)
                   ^
      drivers/hardkernel/ioboard-spi.c:223:12: warning: ‘ioboard_spi_read_memory’ defined but not used [-Wunused-function]
       static int ioboard_spi_read_memory              (struct spi_device *spi, unsigned int addr, unsigned char *rdata, unsigned int size)
                  ^
      drivers/hardkernel/ioboard-spi.c:329:13: warning: ‘ioboard_spi_test’ defined but not used [-Wunused-function]
       static void ioboard_spi_test        (struct spi_device *spi)
                   ^
      drivers/hid/hid-appleir.c:347:22: warning: initialization from incompatible pointer type
        .input_configured = appleir_input_configured,
                            ^
      drivers/hid/hid-appleir.c:347:22: warning: (near initialization for ‘appleir_driver.input_configured’)
      In file included from backports/net/wireless/core.c:16:0:
      backports/backport-include/linux/debugfs.h:11:10: warning: ‘struct device’ declared inside parameter list
                void *data));
                ^
      backports/backport-include/linux/debugfs.h:11:10: warning: its scope is only this definition or declaration, which is probably not what you want
      drivers/hid/hid-magicmouse.c:590:22: warning: initialization from incompatible pointer type
        .input_configured = magicmouse_input_configured,
                            ^
      drivers/hid/hid-magicmouse.c:590:22: warning: (near initialization for ‘magicmouse_driver.input_configured’)
      drivers/hid/hid-ntrig.c:1026:22: warning: initialization from incompatible pointer type
        .input_configured = ntrig_input_configured,
                            ^
      drivers/hid/hid-ntrig.c:1026:22: warning: (near initialization for ‘ntrig_driver.input_configured’)
      backports/drivers/realtek/rtl8192du/os_dep/ioctl_cfg80211.c:3580:17: warning: initialization from incompatible pointer type
        .get_station = cfg80211_rtw_get_station,
                       ^
      backports/drivers/realtek/rtl8192du/os_dep/ioctl_cfg80211.c:3580:17: warning: (near initialization for ‘rtw_cfg80211_ops.get_station’)
      backports/drivers/realtek/rtl8192du/os_dep/ioctl_cfg80211.c:3608:17: warning: initialization from incompatible pointer type
        .add_station = cfg80211_rtw_add_station,
                       ^
      backports/drivers/realtek/rtl8192du/os_dep/ioctl_cfg80211.c:3608:17: warning: (near initialization for ‘rtw_cfg80211_ops.add_station’)
      backports/drivers/realtek/rtl8192du/os_dep/ioctl_cfg80211.c:3609:17: warning: initialization from incompatible pointer type
        .del_station = cfg80211_rtw_del_station,
                       ^
      backports/drivers/realtek/rtl8192du/os_dep/ioctl_cfg80211.c:3609:17: warning: (near initialization for ‘rtw_cfg80211_ops.del_station’)
      backports/drivers/realtek/rtl8192du/os_dep/ioctl_cfg80211.c:3610:20: warning: initialization from incompatible pointer type
        .change_station = cfg80211_rtw_change_station,
                          ^
      backports/drivers/realtek/rtl8192du/os_dep/ioctl_cfg80211.c:3610:20: warning: (near initialization for ‘rtw_cfg80211_ops.change_station’)
      backports/drivers/realtek/rtl8192du/os_dep/ioctl_cfg80211.c:3617:13: warning: initialization from incompatible pointer type
        .mgmt_tx = cfg80211_rtw_mgmt_tx,
                   ^
      backports/drivers/realtek/rtl8192du/os_dep/ioctl_cfg80211.c:3617:13: warning: (near initialization for ‘rtw_cfg80211_ops.mgmt_tx’)
      net/rfkill/rfkill-regulator.c: In function ‘rfkill_regulator_set_block’:
      net/rfkill/rfkill-regulator.c:43:4: warning: ignoring return value of ‘regulator_enable’, declared with attribute warn_unused_result [-Wunused-result]
          regulator_enable(rfkill_data->vcc);
          ^
      drivers/media/platform/exynos/mfc/s5p_mfc.c:2108:28: warning: ‘s5p_mfc_dec_drm_videodev’ defined but not used [-Wunused-variable]
       static struct video_device s5p_mfc_dec_drm_videodev = {
                                  ^
      drivers/media/platform/exynos/mfc/s5p_mfc.c:2115:28: warning: ‘s5p_mfc_enc_drm_videodev’ defined but not used [-Wunused-variable]
       static struct video_device s5p_mfc_enc_drm_videodev = {
                                  ^
      fs/binfmt_misc.c: In function ‘parse_command.part.1’:
      fs/binfmt_misc.c:405:7: warning: array subscript is above array bounds [-Warray-bounds]
        if (s[count-1] == '\n')
             ^
      drivers/usb/host/xhci.c: In function ‘xhci_free_dev’:
      drivers/usb/host/xhci.c:3506:17: warning: unused variable ‘dev’ [-Wunused-variable]
        struct device *dev = hcd->self.controller;
                       ^
      drivers/usb/host/xhci.c: In function ‘xhci_alloc_dev’:
      drivers/usb/host/xhci.c:3592:17: warning: unused variable ‘dev’ [-Wunused-variable]
        struct device *dev = hcd->self.controller;
                       ^
      drivers/usb/host/xhci-plat.c: In function ‘xhci_plat_probe’:
      drivers/usb/host/xhci-plat.c:156:4: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
          extern void samsung_usb3phy_retune(int);
          ^
      arch/arm/boot/compressed/atags_to_fdt.c: In function ‘merge_fdt_bootargs’:
      arch/arm/boot/compressed/atags_to_fdt.c:96:1: warning: the frame size of 1032 bytes is larger than 1024 bytes [-Wframe-larger-than=]
       }
       ^
      
      Change-Id: I646d4470fecdef67da42bcff549a2dc3632c68cd
      40072ad6
  2. 05 Oct, 2014 1 commit
  3. 04 Apr, 2013 1 commit
  4. 25 Feb, 2013 1 commit
  5. 03 Jan, 2013 1 commit
  6. 19 Sep, 2012 1 commit
  7. 04 Jul, 2012 2 commits
  8. 25 Jun, 2012 1 commit
  9. 21 Feb, 2012 1 commit
  10. 21 Oct, 2011 1 commit
  11. 25 Aug, 2011 1 commit
  12. 10 Aug, 2011 1 commit
  13. 16 Jun, 2011 1 commit
  14. 20 May, 2011 1 commit
  15. 06 Apr, 2011 1 commit
  16. 31 Mar, 2011 1 commit
  17. 09 Mar, 2011 1 commit
  18. 10 Dec, 2010 1 commit
    • Joe Perches's avatar
      HID: Add and use hid_<level>: dev_<level> equivalents · 4291ee30
      Joe Perches authored
      Neaten current uses of dev_<level> by adding and using
      hid specific hid_<level> macros.
      
      Convert existing uses of dev_<level> uses to hid_<level>.
      Convert hid-pidff printk uses to hid_<level>.
      
      Remove err_hid and use hid_err instead.
      
      Add missing newlines to logging messages where necessary.
      Coalesce format strings.
      
      Add and use pr_fmt(fmt) KBUILD_MODNAME ": " fmt
      
      Other miscellaneous changes:
      
      Add const struct hid_device * argument to hid-core functions
      extract() and implement() so hid_<level> can be used by them.
      Fix bad indentation in hid-core hid_input_field function
      that calls extract() function above.
      Signed-off-by: default avatarJoe Perches <joe@perches.com>
      Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
      4291ee30
  19. 09 Dec, 2010 1 commit
  20. 01 Oct, 2010 1 commit
  21. 24 Sep, 2010 1 commit
  22. 03 Sep, 2010 3 commits
  23. 02 Sep, 2010 2 commits
  24. 11 Jul, 2010 2 commits
  25. 24 Jun, 2010 3 commits
  26. 04 Jun, 2010 2 commits
  27. 12 May, 2010 1 commit
    • Jiri Kosina's avatar
      HID: magicmouse: fix input registration · 23d02116
      Jiri Kosina authored
      When HIDRAW is not set, hid_hw_start() returns ENODEV as no subsystem has
      claimed the magicmouse device, and probe routine bails out. Which is not what we want.
      
      This happens because magicmouse driver is instantiating the connection to
      Input subsystem itself, and since commit 28918c21 ("HID: magicmouse: fix
      oops after device removal") the HID core is not registering input device
      itself.
      
      Fix this by letting HID core register the input device (so that hid_hw_start()
      succeeds, as the device is claimed by at least one subsystem) and de-register
      it again later before proceeding with proper input setup.
      Reported-by: default avatarJustin P. Mattock <justinmattock@gmail.com>
      Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
      23d02116
  28. 30 Mar, 2010 1 commit
    • Tejun Heo's avatar
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo authored
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      Guess-its-ok-by: default avatarChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  29. 09 Mar, 2010 1 commit
  30. 11 Feb, 2010 1 commit
  31. 10 Feb, 2010 1 commit
    • Michael Poole's avatar
      HID: add a device driver for the Apple Magic Mouse. · 128537ce
      Michael Poole authored
      The Magic Mouse requires that a driver send an unlock Report(Feature) command,
      similar to the Wacom wireless tablet and Sixaxis controller quirks.  This turns
      on an Input Report that isn't published in the input Report descriptor that
      contains touch data (and usually overrides the normal motion and click Report).
      
      Because the mouse has only one switch and no scroll wheel, the driver
      (under control of parameters) emulates a middle button and scroll wheel.
      User space could also ignore and/or re-synthesize those events based on
      the reported events.
      
      Some user-space tools to talk to the mouse directly (that is, when it is not
      associated with the host's HIDP stack) are at
      http://github.com/entrope/linux-magicmouseSigned-off-by: default avatarMichael Poole <mdpoole@troilus.org>
      Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
      128537ce