1. 03 Jan, 2013 1 commit
    • Greg Kroah-Hartman's avatar
      Drivers: ata: remove __dev* attributes. · 0ec24914
      Greg Kroah-Hartman authored
      CONFIG_HOTPLUG is going away as an option.  As a result, the __dev*
      markings need to be removed.
      
      This change removes the use of __devinit, __devexit_p, __devinitdata,
      and __devexit from these drivers.
      
      Based on patches originally written by Bill Pemberton, but redone by me
      in order to handle some of the coding style issues better, by hand.
      
      Cc: Bill Pemberton <wfp5p@virginia.edu>
      Cc: Jeff Garzik <jgarzik@pobox.com>
      Cc: Viresh Kumar <viresh.linux@gmail.com>
      Signed-off-by: 's avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      0ec24914
  2. 06 Nov, 2012 1 commit
  3. 13 Feb, 2012 1 commit
  4. 09 Jan, 2012 1 commit
    • Axel Lin's avatar
      SATA/PATA: convert drivers/ata/* to use module_platform_driver() · 99c8ea3e
      Axel Lin authored
      This patch converts the drivers in drivers/ata/* to use the
      module_platform_driver() macro which makes the code smaller and a bit
      simpler.
      
      Cc: Viresh Kumar <viresh.kumar@st.com>
      Cc: Jeff Garzik <jgarzik@pobox.com>
      Cc: Arnaud Patard <arnaud.patard@rtp-net.org>
      Cc: Alessandro Zummo <a.zummo@towertech.it>
      Cc: Sylvain Munaut <tnt@246tNt.com>
      Cc: Anton Vorontsov <avorontsov@ru.mvista.com>
      Cc: Marek Vasut <marek.vasut@gmail.com>
      Cc: Florian Fainelli <florian@openwrt.org>
      Cc: Mark Miesfeld <mmiesfeld@amcc.com>
      Cc: Ashish Kalra <ashish.kalra@freescale.com>
      Cc: Paul Mundt <lethal@linux-sh.org>
      Signed-off-by: 's avatarAxel Lin <axel.lin@gmail.com>
      Signed-off-by: 's avatarJeff Garzik <jgarzik@redhat.com>
      99c8ea3e
  5. 29 Nov, 2011 1 commit
  6. 14 Oct, 2011 1 commit
  7. 08 Aug, 2011 1 commit
  8. 14 May, 2011 1 commit
  9. 24 Apr, 2011 2 commits
  10. 19 May, 2010 1 commit
    • Tejun Heo's avatar
      libata-sff: clean up BMDMA initialization · c7087652
      Tejun Heo authored
      When BMDMA initialization failed or BMDMA was not available for
      whatever reason, bmdma_addr was left at zero and used as an indication
      that BMDMA shouldn't be used.  This leads to the following problems.
      
      p1. For BMDMA drivers which don't use traditional BMDMA register,
          ata_bmdma_mode_filter() incorrectly inhibits DMA modes.  Those
          drivers either have to inherit from ata_sff_port_ops or clear
          ->mode_filter explicitly.
      
      p2. non-BMDMA drivers call into BMDMA PRD table allocation.  It
          doesn't actually allocate PRD table if bmdma_addr is not
          initialized but is still confusing.
      
      p3. For BMDMA drivers which don't use traditional BMDMA register, some
          methods might not be invoked as expected (e.g. bmdma_stop from
          ata_sff_post_internal_cmd()).
      
      p4. SFF drivers w/ custom DMA interface implement noop BMDMA ops
          worrying libata core might call into one of them.
      
      These problems are caused by the muddy line between SFF and BMDMA and
      the assumption that all BMDMA controllers initialize bmdma_addr.
      
      This patch fixes p1 and p2 by removing the bmdma_addr assumption and
      moving prd allocation to BMDMA port start.  Later patches will fix the
      remaining issues.
      
      This patch improves BMDMA initialization such that
      
      * When BMDMA register initialization fails, falls back to PIO instead
        of failing.  ata_pci_bmdma_init() never fails now.
      
      * When ata_pci_bmdma_init() falls back to PIO, it clears
        ap->mwdma_mask and udma_mask instead of depending on
        ata_bmdma_mode_filter().  This makes ata_bmdma_mode_filter()
        unnecessary thus resolving p1.
      
      * ata_port_start() which actually is BMDMA specific is moved to
        ata_bmdma_port_start().  ata_port_start() and ata_sff_port_start()
        are killed.
      
      * ata_sff_port_start32() is moved and renamed to
        ata_bmdma_port_start32().
      
      Drivers which no longer call into PRD table allocation are...
      
        pdc_adma, sata_inic162x, sata_qstor, sata_sx4, pata_cmd640 and all
        drivers which inherit from ata_sff_port_ops.
      
      pata_icside sets ->port_start to ATA_OP_NULL as it doesn't need PRD
      but is a BMDMA controller and doesn't have custom port_start like
      other such controllers.
      
      Note that with the previous patch which makes all and only BMDMA
      drivers inherit from ata_bmdma_port_ops, this change doesn't break
      drivers which need PRD table.
      Signed-off-by: 's avatarTejun Heo <tj@kernel.org>
      Signed-off-by: 's avatarJeff Garzik <jgarzik@redhat.com>
      c7087652
  11. 30 Mar, 2010 1 commit
    • Tejun Heo's avatar
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo authored
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: 's avatarTejun Heo <tj@kernel.org>
      Guess-its-ok-by: 's avatarChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  12. 01 Mar, 2010 1 commit
  13. 12 Aug, 2009 1 commit
    • Tejun Heo's avatar
      pata_at91: fix resource release · df9eba8c
      Tejun Heo authored
      Julias Lawall discovered that pata_at91 wasn't freeing a memory region
      allocated with kzalloc() on init failure paths.  Upon review,
      pata_at91 also seems to be doing unnecessary explicit resource
      releases for managed resources too.  Convert memory allocation to
      managed one and drop unnecessary explicit resource releases.
      Signed-off-by: 's avatarTejun Heo <tj@kernel.org>
      Cc: Julia Lawall <julia@diku.dk>
      Cc: Sergey Matyukevich <geomatsi@gmail.com>
      Signed-off-by: 's avatarJeff Garzik <jgarzik@redhat.com>
      df9eba8c
  14. 29 Jul, 2009 1 commit
    • Sergey Matyukevich's avatar
      libata: Updates and fixes for pata_at91 driver · 7d084d96
      Sergey Matyukevich authored
      Please consider the following updates and fixes for pata_at91 driver.
      
      * Removed extra headers
      	Here we need only static memory controller properties, which are
      	contained in generic header at91sam9_smc.h.
      	No need to include any specific headers for at91sam9260 SoC.
      
      * No harsh BUG_ON for get_clk in set_smc_timing function
              get_clk is now performed in driver probing function,
      	        probing fails if master clock is not available
      
      * Fixed uint/ulong mess in calc_mck_cycles function
      Signed-off-by: 's avatarSergey Matyukevich <geomatsi@gmail.com>
      Signed-off-by: 's avatarJeff Garzik <jgarzik@redhat.com>
      7d084d96
  15. 15 Jul, 2009 1 commit
  16. 23 Jun, 2009 1 commit