1. 13 Feb, 2014 1 commit
    • Joe Thornber's avatar
      dm thin: fix discard support to a previously shared block · 614319df
      Joe Thornber authored
      commit 19fa1a6756ed9e92daa9537c03b47d6b55cc2316 upstream.
      If a snapshot is created and later deleted the origin dm_thin_device's
      snapshotted_time will have been updated to reflect the snapshot's
      creation time.  The 'shared' flag in the dm_thin_lookup_result struct
      returned from dm_thin_find_block() is an approximation based on
      snapshotted_time -- this is done to avoid 0(n), or worse, time
      complexity.  In this case, the shared flag would be true.
      But because the 'shared' flag reflects an approximation a block can be
      incorrectly assumed to be shared (e.g. false positive for 'shared'
      because the snapshot no longer exists).  This could result in discards
      issued to a thin device not being passed down to the pool's underlying
      data device.
      To fix this we double check that a thin block is really still in-use
      after a mapping is removed using dm_pool_block_is_used().  If the
      reference count for a block is now zero the discard is allowed to be
      passed down.
      Also add a 'definitely_not_shared' member to the dm_thin_new_mapping
      structure -- reflects that the 'shared' flag in the response from
      dm_thin_find_block() can only be held as definitive if false is
      Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1043527Signed-off-by: default avatarJoe Thornber <ejt@redhat.com>
      Signed-off-by: default avatarMike Snitzer <snitzer@redhat.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
  2. 10 May, 2013 3 commits
  3. 01 Mar, 2013 1 commit
  4. 21 Dec, 2012 1 commit
  5. 27 Jul, 2012 28 commits
  6. 02 Jun, 2012 1 commit
    • Joe Thornber's avatar
      dm thin: provide userspace access to pool metadata · cc8394d8
      Joe Thornber authored
      This patch implements two new messages that can be sent to the thin
      pool target allowing it to take a snapshot of the _metadata_.  This,
      read-only snapshot can be accessed by userland, concurrently with the
      live target.
      Only one metadata snapshot can be held at a time.  The pool's status
      line will give the block location for the current msnap.
      Since version 0.1.5 of the userland thin provisioning tools, the
      thin_dump program displays the msnap as follows:
          thin_dump -m <msnap root> <metadata dev>
      Available here: https://github.com/jthornber/thin-provisioning-tools
      Now that userland can access the metadata we can do various things
      that have traditionally been kernel side tasks:
           i) Incremental backups.
           By using metadata snapshots we can work out what blocks have
           changed over time.  Combined with data snapshots we can ensure
           the data doesn't change while we back it up.
           A short proof of concept script can be found here:
           ii) Migration of thin devices from one pool to another.
           iii) Merging snapshots back into an external origin.
           iv) Asyncronous replication.
      Signed-off-by: default avatarJoe Thornber <ejt@redhat.com>
      Signed-off-by: default avatarAlasdair G Kergon <agk@redhat.com>
  7. 28 Mar, 2012 2 commits
  8. 07 Mar, 2012 3 commits