• Hannes Frederic Sowa's avatar
    net: rework recvmsg handler msg_name and msg_namelen logic · 2f73d7fd
    Hannes Frederic Sowa authored
    [ Upstream commit f3d3342602f8bcbf37d7c46641cb9bca7618eb1c ]
    
    This patch now always passes msg->msg_namelen as 0. recvmsg handlers must
    set msg_namelen to the proper size <= sizeof(struct sockaddr_storage)
    to return msg_name to the user.
    
    This prevents numerous uninitialized memory leaks we had in the
    recvmsg handlers and makes it harder for new code to accidentally leak
    uninitialized memory.
    
    Optimize for the case recvfrom is called with NULL as address. We don't
    need to copy the address at all, so set it to NULL before invoking the
    recvmsg handler. We can do so, because all the recvmsg handlers must
    cope with the case a plain read() is called on them. read() also sets
    msg_name to NULL.
    
    Also document these changes in include/linux/net.h as suggested by David
    Miller.
    
    Changes since RFC:
    
    Set msg->msg_name = NULL if user specified a NULL in msg_name but had a
    non-null msg_namelen in verify_iovec/verify_compat_iovec. This doesn't
    affect sendto as it would bail out earlier while trying to copy-in the
    address. It also more naturally reflects the logic by the callers of
    verify_iovec.
    
    With this change in place I could remove "
    if (!uaddr || msg_sys->msg_namelen == 0)
    	msg->msg_name = NULL
    ".
    
    This change does not alter the user visible error logic as we ignore
    msg_namelen as long as msg_name is NULL.
    
    Also remove two unnecessary curly brackets in ___sys_recvmsg and change
    comments to netdev style.
    
    Cc: David Miller <davem@davemloft.net>
    Suggested-by: 's avatarEric Dumazet <eric.dumazet@gmail.com>
    Signed-off-by: 's avatarHannes Frederic Sowa <hannes@stressinduktion.org>
    Signed-off-by: 's avatarDavid S. Miller <davem@davemloft.net>
    Signed-off-by: 's avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    2f73d7fd
Name
Last commit
Last update
..
act2000 Loading commit data...
capi Loading commit data...
divert Loading commit data...
gigaset Loading commit data...
hardware Loading commit data...
hisax Loading commit data...
hysdn Loading commit data...
i4l Loading commit data...
icn Loading commit data...
isdnloop Loading commit data...
mISDN Loading commit data...
pcbit Loading commit data...
sc Loading commit data...
Kconfig Loading commit data...
Makefile Loading commit data...