From 855752f4d2093baa7660fca82a2767d1a9f1c6f5 Mon Sep 17 00:00:00 2001
From: Raphael Defosseux <raphael.defosseux@eurecom.fr>
Date: Fri, 24 Jan 2020 11:20:10 +0100
Subject: [PATCH] Fix a few warnings

Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
---
 openair1/SCHED_NR_UE/phy_procedures_nr_ue.c        | 4 +---
 openair2/LAYER2/NR_MAC_UE/nr_ue_procedures.c       | 2 +-
 openair2/LAYER2/NR_MAC_gNB/gNB_scheduler_dlsch.c   | 2 +-
 openair2/LAYER2/NR_MAC_gNB/gNB_scheduler_phytest.c | 8 ++++----
 4 files changed, 7 insertions(+), 9 deletions(-)

diff --git a/openair1/SCHED_NR_UE/phy_procedures_nr_ue.c b/openair1/SCHED_NR_UE/phy_procedures_nr_ue.c
index 30fd260ec97..0067efb4d96 100644
--- a/openair1/SCHED_NR_UE/phy_procedures_nr_ue.c
+++ b/openair1/SCHED_NR_UE/phy_procedures_nr_ue.c
@@ -3558,7 +3558,7 @@ void nr_ue_dlsch_procedures(PHY_VARS_NR_UE *ue,
   uint16_t slots_per_frame = ue->frame_parms.slots_per_frame;
   uint16_t slots_per_subframe = ue->frame_parms.slots_per_subframe;
   uint8_t numerology = ue->frame_parms.numerology_index, mapping_type_ul, mapping_type_dl;
-  int ul_tx_timing_adjustment, N_TA_max, factor_mu, N_t_1, N_t_2, N_1, N_2, d_1_1, d_2_1, d;
+  int ul_tx_timing_adjustment, N_TA_max, factor_mu, N_t_1, N_t_2, N_1, N_2, d_1_1 = 0, d_2_1, d;
   uint8_t d_2_2 = 0;// set to 0 because there is only 1 BWP
                     // TODO this should corresponds to the switching time as defined in
                     // TS 38.133
@@ -4276,8 +4276,6 @@ int phy_procedures_nrUE_RX(PHY_VARS_NR_UE *ue,
                            uint8_t do_pdcch_flag,
                            runmode_t mode)
 {
-  int l,l2;
-  int pilot1;
   int frame_rx = proc->frame_rx;
   int nr_tti_rx = proc->nr_tti_rx;
   int slot_pbch;
diff --git a/openair2/LAYER2/NR_MAC_UE/nr_ue_procedures.c b/openair2/LAYER2/NR_MAC_UE/nr_ue_procedures.c
index 0c23ad808db..77e50597722 100644
--- a/openair2/LAYER2/NR_MAC_UE/nr_ue_procedures.c
+++ b/openair2/LAYER2/NR_MAC_UE/nr_ue_procedures.c
@@ -2127,7 +2127,7 @@ void nr_ue_process_mac_pdu(
     uint16_t mac_subheader_len;
     uint16_t mac_sdu_len;
 
-    NR_UE_MAC_INST_t *UE_mac_inst = get_mac_inst(module_idP);
+    //NR_UE_MAC_INST_t *UE_mac_inst = get_mac_inst(module_idP);
     //uint8_t scs = UE_mac_inst->mib->subCarrierSpacingCommon;
     //uint16_t bwp_ul_NB_RB = UE_mac_inst->initial_bwp_ul.N_RB;
 
diff --git a/openair2/LAYER2/NR_MAC_gNB/gNB_scheduler_dlsch.c b/openair2/LAYER2/NR_MAC_gNB/gNB_scheduler_dlsch.c
index 15c96fec941..52332701499 100644
--- a/openair2/LAYER2/NR_MAC_gNB/gNB_scheduler_dlsch.c
+++ b/openair2/LAYER2/NR_MAC_gNB/gNB_scheduler_dlsch.c
@@ -91,7 +91,7 @@ int nr_generate_dlsch_pdu(module_id_t module_idP,
     timing_advance_cmd = gNB->ta_command;
     AssertFatal(timing_advance_cmd < 64,"timing_advance_cmd %d > 63\n", timing_advance_cmd);
     ((NR_MAC_CE_TA *) ce_ptr)->TA_COMMAND = timing_advance_cmd;    //(timing_advance_cmd+31)&0x3f;
-    if (gNB->tag->tag_Id != NULL){
+    if (gNB->tag->tag_Id != 0){
        tag_id = gNB->tag->tag_Id;
       ((NR_MAC_CE_TA *) ce_ptr)->TAGID = tag_id;
     }
diff --git a/openair2/LAYER2/NR_MAC_gNB/gNB_scheduler_phytest.c b/openair2/LAYER2/NR_MAC_gNB/gNB_scheduler_phytest.c
index b8af0a1167a..5fb7fdeef56 100644
--- a/openair2/LAYER2/NR_MAC_gNB/gNB_scheduler_phytest.c
+++ b/openair2/LAYER2/NR_MAC_gNB/gNB_scheduler_phytest.c
@@ -288,8 +288,8 @@ void nr_schedule_uss_dlsch_phytest(module_id_t   module_idP,
   unsigned char sdu_lcids[NB_RB_MAX] = {0};
   uint16_t sdu_lengths[NB_RB_MAX] = {0};
 
-  int padding = 0, post_padding = 0, ta_len = 0, header_length_total = 0, sdu_length_total = 0, num_sdus = 0;
-  int CC_id, lcid, offset, i, j=0, k=0, header_length_last, TBS_bytes;
+  int post_padding = 0, ta_len = 0, header_length_total = 0, sdu_length_total = 0, num_sdus = 0;
+  int CC_id, lcid, offset, i, header_length_last, TBS_bytes;
 
   int UE_id = 0; 
   uint16_t rnti = 0x1234;
@@ -398,10 +398,10 @@ void nr_schedule_uss_dlsch_phytest(module_id_t   module_idP,
       if (TBS_bytes >= 2 + header_length_total + sdu_length_total + ta_len) {
         // we have to consider padding
         // padding param currently not in use
-        padding = TBS_bytes - header_length_total - sdu_length_total - ta_len - 1;
+        //padding = TBS_bytes - header_length_total - sdu_length_total - ta_len - 1;
         post_padding = 1;
       } else {
-        padding = 0;
+        //padding = 0;
         post_padding = 0;
       }
 
-- 
GitLab