1. 12 May, 2017 2 commits
    • Gabriel's avatar
      bug fixes from Fujitsu (bug 26) · 899d1506
      Gabriel authored and Cedric Roux's avatar Cedric Roux committed
      ----------------------------------------------------------
      bug 26
      
      Ttile:
      g_buffer has only 32 index, but he/she tries to zero clear
      1024 index.
      
      Bug Location:
      static uint8_t g_buffer[32];
      :
      memset (g_buffer, 0, 1024);
      
      Note:
      Detected by CppCheck
      ----------------------------------------------------------
      899d1506
    • Gabriel's avatar
      bug fixes from Fujitsu (bug 21) · 98a7a16e
      Gabriel authored and Cedric Roux's avatar Cedric Roux committed
      Note: this fix does not solve the issue with how
      this buffer is used in this function, but I'm not
      sure this code is used at all (Cédric Roux).
      
      ----------------------------------------------------------
      bug 21
      
      Ttile:
      PAYLOAD_MAX=1500, so this coding results in index overflow.
      Additionally, operator "!=" just compairs something, this
      coding is meaningless.
      
      Bug Location:
      buffer[PAYLOAD_MAX] != '\0';
      
      Note:
      Detected by CppCheck
      ----------------------------------------------------------
      98a7a16e
  2. 03 May, 2017 1 commit
  3. 11 Apr, 2017 1 commit
  4. 10 Apr, 2017 2 commits
    • Cedric Roux's avatar
      bugfix: increase RLC UM header size · 94f880ad
      Cedric Roux authored
      The constant RLC_UM_SEGMENT_NB_MAX_LI_PER_PDU is set to 24. This is
      too low. Running a downlink TCP iperf with a 10MHz or 20MHz cell
      leads to lots of the following warning in the log:
      
      [RLC][W][SN 792] Bad RLC header! Discard this RLC PDU (size=618)
      
      The problem is that the uplink RLC PDU contains a lot of TCP ack.
      We can see much more than 24 of them. The RLC layer is not happy
      and discards the PDU.
      
      Putting 256 for RLC_UM_SEGMENT_NB_MAX_LI_PER_PDU (arbitrarily chosen,
      big but not too big) solves the problem, at least for 10MHz.
      94f880ad
    • Cedric Roux's avatar
      minor: bad comparison · fbcc9a23
      Cedric Roux authored
      it was:
      
          *num_li_pP >= RLC_UM_SEGMENT_NB_MAX_LI_PER_PDU
      
      it should be:
      
          *num_li_pP > RLC_UM_SEGMENT_NB_MAX_LI_PER_PDU
      fbcc9a23
  5. 03 Apr, 2017 2 commits
    • Cedric Roux's avatar
      hotfix: revert value of 'rb_table_index' · e7f1cf42
      Cedric Roux authored
      This reverts commit 7f24927c.
      
      With value 13 uplink TDD for a 10MHz configuration was not working.
      UDP traffic sent with: "iperf -c XX -u -b10M" was crashing
      the eNB.
      e7f1cf42
    • Cedric Roux's avatar
      integration fix: fixes for pthread_getname_np · c36c0453
      Cedric Roux authored
      - define _GNU_SOURCE before including pthread.h
      - do not use static for the array 'threadname' used
        to store the name, it makes it a global variable
        accessed by several threads in parallel
      - increase size of 'threadname' (maybe not necessary)
      - properly indent #define / #under (# should be at column 1)
      c36c0453
  6. 29 Mar, 2017 1 commit
  7. 28 Mar, 2017 8 commits
  8. 24 Mar, 2017 8 commits
  9. 23 Mar, 2017 1 commit
    • Cedric Roux's avatar
      RRC Rel14 · 4fcb6272
      Cedric Roux authored
      - import RRC ASN.1 defintions from the specifications
        (file openair2/RRC/LITE/MESSAGES/asn1c/ASN1_files/RRC-e10.asn)
        contrary to rel8/10, all modules have been imported, maybe it's too much
        to refine in case of problems
      - deal with rel14 in fix_asn1
      - all code that was for Rel10 is now for Rel10/Rel14
      - some incompatible changes (mostly in naming) were resolved in favor
        of rel14, see in openair2/RRC/LITE/defs.h
      - unsure about the rlc layer, some arrays have changed (values appended),
        I only changed the definition and in tests in the code, I changed
        the index limit, maybe it's not enough
      
      Rel14 is the default compilation mode.
      4fcb6272
  10. 21 Mar, 2017 1 commit
  11. 20 Mar, 2017 1 commit
  12. 16 Mar, 2017 2 commits
  13. 15 Mar, 2017 4 commits
  14. 14 Mar, 2017 2 commits
  15. 13 Mar, 2017 4 commits