1. 02 Nov, 2018 1 commit
  2. 15 Oct, 2018 1 commit
    • Cedric Roux's avatar
      hotfix: hardcode PLMN selection in the UE to value 1 (was 2) · 27395c08
      Cedric Roux authored
      Fix the assertion:
      Assertion ((instance_p->mnc_digit_length[ue_desc_p->selected_plmn_identity] == 3) || (instance_p->mnc_digit_length[ue_desc_p->selected_plmn_identity] == 2)) failed!
      In s1ap_eNB_handle_nas_first_req() /home/ubuntu/tmp/openair3/S1AP/s1ap_eNB_nas_procedures.c:243
      
      With this hotfix the UE selects the first PLMN sent by the eNodeB.
      
      The UE has to select the correct PLMN from those received in SIB1. This
      will be done with a later merge request.
      27395c08
  3. 28 Sep, 2018 1 commit
  4. 31 Aug, 2018 1 commit
  5. 29 Aug, 2018 1 commit
  6. 28 Aug, 2018 1 commit
  7. 24 Aug, 2018 1 commit
  8. 30 Jul, 2018 3 commits
  9. 13 Jul, 2018 1 commit
    • Bi-Ruei, Chiu's avatar
      Use an un-official community collaboration version of asn1c · a247907d
      Bi-Ruei, Chiu authored
      1. It's no need to modify LTE-RRC's ASN.1 file for enabling option group
         feature in generate_asn1.
      2. It's no need to patch the C header files generated from
         LTE-RRC/S1AP/X2AP's ASN.1 in fix_asn1.
      3. It's no need to pre-process S1AP/X2AP's ASN.1 for enabling information
         object class feature by asn1tostruct.py.
      
      This commit requires an un-official version of asn1c which are
      collaboration of asn1c community members and `build_helper` is modified
      in this commit accordingly :
      
        https://github.com/brchiu/asn1c/tree/velichkov_s1ap_plus_option_group
      
      This asn1c can also convert ASN.1 of 5G NR RRC (38.331, v15.1.0) and
      generate C files with -findirect-choice command line option without
      tweaking ASN.1 file.
      
      Examples for how to use this asn1c for S1AP are in S1AP files, e.g.
      s1ap_eNB_nas_procedures.c and s1ap_eNB_handler.c.
      
      There is an modified openair-cn (based on tag 0.5.0) with this new asn1c at :
      
        https://github.com/brchiu/openair-cn/tree/new-asn1c
      
      Basic S1AP interaction and data transfer operation between OAI eNB and
      this modified openair-cn has been tested.
      
      Note: Community version of asn1c is keeping evolved to provide better usage.
      a247907d
  10. 25 Jun, 2018 1 commit
  11. 29 May, 2018 1 commit
  12. 15 May, 2018 1 commit
  13. 22 Apr, 2018 1 commit
  14. 08 Apr, 2018 1 commit
  15. 08 Feb, 2018 1 commit
  16. 07 Feb, 2018 1 commit
    • Cedric Roux's avatar
      bugfix: fix SIB3 encoding · 1fce1bbf
      Cedric Roux authored
      The unused bits are the lower bits, so we need to shift.
      
      Not sure that the value 1 is what we want though.
      1fce1bbf
  17. 13 Jan, 2018 1 commit
  18. 11 Jan, 2018 1 commit
  19. 08 Jan, 2018 1 commit
  20. 28 Nov, 2017 1 commit
  21. 16 Nov, 2017 1 commit
  22. 09 Nov, 2017 1 commit
  23. 23 Oct, 2017 1 commit
  24. 20 Oct, 2017 2 commits
    • Cedric Roux's avatar
      fix asn1_msg.c · 6087ede0
      Cedric Roux authored
      - compile with warning enabled (changes in CMakeLists.txt)
      - remove warnings that were present
      6087ede0
    • Cedric Roux's avatar
      bugfix: fix featureGroup · 5afc71f3
      Cedric Roux authored
      - allocate memory, memory on stack does not survive the function
      - avoid uint32_t, use a char buffer, for endianness neutrality
      5afc71f3
  25. 21 Sep, 2017 1 commit
    • Cedric Roux's avatar
      bugfix: fix do_MIB · e6bf9698
      Cedric Roux authored
      - carrier->MIB will be reused, so "spare" has to be allocated
      - wrong parameters sent to uper_encode_to_buffer
      e6bf9698
  26. 16 Sep, 2017 1 commit
  27. 14 Sep, 2017 1 commit
  28. 24 Aug, 2017 1 commit
    • Cedric Roux's avatar
      improve multi-UEs scenario · 622b919b
      Cedric Roux authored
      This commits contains several fixes to improve a multi-UE scenario.
      
      This is not the end of the story.
      
      Summary of work:
      ================
      
      1 - improve SR (scheduling requests):
      
          We configured n1pucch == 3 for scheduling requests, for all
          UEs. We now use 71 - UE_id/10.
      
          For it to work, it is vital that pucch_nRB_CQI in the configuration
          file is set to 0, otherwise the SR will go to an RB used for
          PUSCH and uplink decoding will fail whenever an UE does SR.
      
          Note that we will have problems with 20MHz when we use a CCE that
          let the UE send the ACK/NACK using a n1pucch allocated for SR,
          because when the PDCCH is of size 3, we can have 87 CCEs
          and it may lead to an n1pucch colliding with one for SR.
      
          The work done in this patch is a quick solution, seems to work
          with 10MHz.
      
          The real solution is to disable the use of those CCEs that would
          lead an UE to use a n1pucch colliding with an SR n1pucch. Then
          we can use whatever n1pucch we want for SR, as long as the
          scheduler protects them.
      
          Impacted files: configuration files
                          openair2/RRC/LITE/MESSAGES/asn1_msg.c
      
      2 - some fixes for uplink scheduling:
      
          - Do not use PRACH for PUSCH, that leads to too many false
          PRACH detection. Plus the PUSCH receiving may fail if one
          UE uses the PRACH at the same time.
      
          - Take care of retransmissions. That was not done at all, so
          we could allocate one RB to several UEs. The current design
          of the code makes it hard to do it properly, so we chose a
          quick and dirty solution, which is to increase "first_rb"
          to skip any RB used for retransmission. In this process we
          may skip a lot of free RBs. A proper solution is needed here.
      
          - Do not allocate the last RB. This one is used for PUCCH.
          It was sometimes allocated to PUSCH.
      
          - In the pre-processor we didn't pre-allocate RBs to UEs
          with an empty buffer status. We didn't check if the UE
          sent an SR. For example in a three UEs scenario, we
          could have the third UE never scheduled in the uplink.
      
          - rb_table_index was not decreased properly, so we allocated
          too much RBs to some UEs and thus not enough to others.
      
          Impacted files: openair2/LAYER2/MAC/eNB_scheduler_ulsch.c
                          openair2/LAYER2/MAC/pre_processor.c
                          openair1/SCHED/phy_procedures_lte_eNb.c
      
      3 - some fixes for downlink scheduling:
      
          - The check on CCE allocation was not correct. We did something
          like:
      
              if (cce allocation is possible) {
                prepare
              }
      
          We should have done:
      
              save current cce allocation
              if (cce allocation is possible) {
                allocate cce
                prepare
              }
              reset current cce allocation
      
          Basically, when we scheduled several UEs, they were checked
          separately, and the totality of them was not checked.
      
          Impacted file: openair2/LAYER2/MAC/eNB_scheduler_dlsch.c
      
          - The retransmissions are probably not handled correctly.
          Check in openair2/LAYER2/MAC/pre_processor.c, near
          the comment "// control channel or retransmission",
          the case "round > 0" was added. It's probably not enough,
          even maybe not correct.
      
          - Change SF05_LIMIT with SF0_LIMIT. We accept to use
          central blocks in SF 5. The code was also not correct,
          vrb_map was not set properly because the loop on j
          was wrong for the last RBG (which can have one less
          RB than the others).
      
          This is not satisfying. The real solution is to use the
          central RBs and check that the MCS used is compatible
          with the numbers of resource elements allocated (we don't
          want to put too more data bits than what fits).
      
      4 - some fixes in PUCCH decoding:
      
          See: openair1/PHY/LTE_TRANSPORT/pucch.c
      
          Probably not enough. Some more work and analysis is
          required for a proper use of the PUCCH. What we see
          is that the PUCCH constellation gets wrong when there
          are several UEs, meaning the received ACK/NACK is
          not properly decoded (this, or something else...).
      
      5 - several fixes/checks added here and there:
      
          - The final allocate_CCEs in eNB_dlsch_ulsch_scheduler
            is checked and we brutally exit if it fails.
      
          - We exit in get_num_pdcch_symbols in case of failure
            (this should never happen anyway, no big deal normally).
      
          - Some logs added or changed to error/warning instead
            of debug.
      
          - In dlsch_scheduler_pre_processor an abort() was added.
            The code here looks suspicious.
      
          - In assign_max_mcs_min_rb, rb_table_index was not set
            to 2, the value 0 was used. This was not correct.
      
      What remains to be done:
      ========================
      
          - Correct CCE allocation (take into account SR n1pucch,
            check that all the n1pucch that will be used are "compatible").
      
          - Take into account the PHICH when scheduling uplink. As of
            today it is very possible to have two UEs use the same PHICH
            group and PHICH sequence index. We can use n_DMRS in the DCI
            to have uniqueness (see 36.213 table 9.1.2-2). We can drop an
            allocation if there is no free PHICH group/sequence index for
            a given UE.
      
          - When there is an uplink retransmission in the PRACH, we have
            to disable PRACH detection. It is possible that one UE does
            PRACH at the same time, but then what to do? We could use
            DCI0-based retransmission in this specific case maybe...
      
          - Handle free RBs in uplink in a much better way in case of
            a retransmission. We may have a lot of free unused RBs with
            the current code.
      
          - Check downlink retransmissions. Not much has been done there.
      
          - Surely more stuff not clear yet. In some situations we don't
            have a good behavior of the system. Hard to describe more
            precisely at this point.
      622b919b
  29. 19 Jul, 2017 1 commit
  30. 04 Jun, 2017 1 commit
  31. 17 Apr, 2017 1 commit
  32. 24 Mar, 2017 1 commit
  33. 23 Mar, 2017 1 commit
    • Cedric Roux's avatar
      RRC Rel14 · 4fcb6272
      Cedric Roux authored
      - import RRC ASN.1 defintions from the specifications
        (file openair2/RRC/LITE/MESSAGES/asn1c/ASN1_files/RRC-e10.asn)
        contrary to rel8/10, all modules have been imported, maybe it's too much
        to refine in case of problems
      - deal with rel14 in fix_asn1
      - all code that was for Rel10 is now for Rel10/Rel14
      - some incompatible changes (mostly in naming) were resolved in favor
        of rel14, see in openair2/RRC/LITE/defs.h
      - unsure about the rlc layer, some arrays have changed (values appended),
        I only changed the definition and in tests in the code, I changed
        the index limit, maybe it's not enough
      
      Rel14 is the default compilation mode.
      4fcb6272
  34. 21 Mar, 2017 1 commit
  35. 20 Mar, 2017 1 commit
  36. 14 Mar, 2017 1 commit
  37. 10 Mar, 2017 1 commit