1. 27 Jul, 2017 1 commit
    • Cedric Roux's avatar
      bugfix: fix bug "Unknown UE_id for rnti" · 8d5901c8
      Cedric Roux authored
      This bug happens when we detect uplink failure for one UE.
      In this case, a DCI format 1A is sent to the UE to ask it
      to do random acces.
      The way this DCI is generated was not compatible with how
      the software is organized. It was expected that the DCI are
      added (with add_ue_spec_dci and add_common_dci) in a very
      specific order: first all DCIs in common space are added
      (with add_common_dci) then all DCIs in UE specific space
      are added (with add_ue_spec_dci).
      The problem was that the DCI format 1A DCI sent to the UE
      for it to do random access is added (with add_ue_spec_dci)
      before the DCIs in common space.
      That totally messed up the logic in add_common_dci and
      The solution is to get rid of Num_common_dci and Num_ue_spec_dci,
      replace those two counters by only one (Num_dci) and add
      "search_space" in the dci_alloc structure to be used later by
      the function "allocate_CCEs" when calling "get_nCCE_offset".
      The software had to be adapted to the new variables, everywhere.
      I am not sure that the simulators work. It seems that some
      of them didn't use Num_common_dci and Num_ue_spec_dci to
      decide on what space (common or UE specific) to put the DCI,
      but relied on the rnti (comparing with SI_RNTI). To be tested
      The modified simulators are:
        - openair1/SIMULATION/LTE_PHY/dlsim.c
        - openair1/SIMULATION/LTE_PHY/dlsim_tm4.c
        - openair1/SIMULATION/LTE_PHY/dlsim_tm7.c
        - openair1/SIMULATION/LTE_PHY/framegen.c
        - openair1/SIMULATION/LTE_PHY/pdcchsim.c
        - openair1/SIMULATION/LTE_PHY/syncsim.c
  2. 06 Jun, 2017 1 commit
  3. 19 May, 2017 1 commit
  4. 12 May, 2017 1 commit
    • Gabriel's avatar
      bug fixes from Fujitsu (bug 22) · 34c6805f
      Gabriel authored and Cedric Roux's avatar Cedric Roux committed
      Note: not sure that the code is correct,
      to be checked (Cédric Roux).
      bug 22
      (subframe!=2)||(subframe!=7) is always TRUE. This coding
      is really intended? Operator || should be && instead?
      Bug Location:
      ((frame_parms->frame_type==TDD)&&(frame_parms->tdd_config==1)&&((subframe!=2)||(subframe!=7)))) {
      Detected by CppCheck
  5. 28 Mar, 2017 1 commit
  6. 23 Mar, 2017 1 commit
    • Cedric Roux's avatar
      RRC Rel14 · 4fcb6272
      Cedric Roux authored
      - import RRC ASN.1 defintions from the specifications
        (file openair2/RRC/LITE/MESSAGES/asn1c/ASN1_files/RRC-e10.asn)
        contrary to rel8/10, all modules have been imported, maybe it's too much
        to refine in case of problems
      - deal with rel14 in fix_asn1
      - all code that was for Rel10 is now for Rel10/Rel14
      - some incompatible changes (mostly in naming) were resolved in favor
        of rel14, see in openair2/RRC/LITE/defs.h
      - unsure about the rlc layer, some arrays have changed (values appended),
        I only changed the definition and in tests in the code, I changed
        the index limit, maybe it's not enough
      Rel14 is the default compilation mode.
  7. 21 Mar, 2017 2 commits
  8. 16 Mar, 2017 1 commit
  9. 15 Mar, 2017 2 commits
  10. 14 Mar, 2017 1 commit
  11. 10 Mar, 2017 3 commits
  12. 17 Feb, 2017 1 commit
  13. 13 Feb, 2017 1 commit
  14. 10 Feb, 2017 1 commit
  15. 07 Feb, 2017 1 commit
  16. 05 Feb, 2017 1 commit
  17. 02 Feb, 2017 1 commit
  18. 14 Jan, 2017 2 commits
  19. 11 Jan, 2017 1 commit
    • Cedric Roux's avatar
      fix LOG_X macros · f2f32f53
      Cedric Roux authored
      Some of them might not be correctly handled.
      I put /* TODO: XXX */ where I didn't know if
      the fix was correct.
  20. 07 Jan, 2017 1 commit
  21. 03 Jan, 2017 1 commit
  22. 02 Jan, 2017 1 commit
  23. 14 Dec, 2016 1 commit
  24. 05 Dec, 2016 2 commits
  25. 04 Dec, 2016 1 commit
  26. 30 Nov, 2016 1 commit
    • Cedric Roux's avatar
      T: update traces · 7adc4703
      Cedric Roux authored
      - add mcs to ENB_PHY_DLSCH_UE_DCI
      - add mcs, round, first_rb, nb_rb, TBS to ENB_PHY_ULSCH_UE_DCI
  27. 25 Nov, 2016 1 commit
  28. 24 Nov, 2016 2 commits
    • Cedric Roux's avatar
      hotfix: fix pucch_procedures · 03231dd1
      Cedric Roux authored
      Something went wrong somewhere in the commit history, the function
      was not correct.
      The most obvious symptom was that way too much SR (scheduling requests)
      were given to the UE whenever it had some PUCCH to send.
      The case for TDD has not been tested.
    • knopp's avatar
      setting of frame_tx in lte-enb.c · eb854b8e
      knopp authored
  29. 23 Nov, 2016 1 commit
  30. 22 Nov, 2016 3 commits
    • Cedric Roux's avatar
      hotfix: hack to improve PHICH generation · b55b63c5
      Cedric Roux authored
      The eNodeB may sometimes wrongly generate PHICH because somewhere
      'phich_active' is not reset to 0, due to an unidentified reason. When
      adding this hack the problem seems to disappear completely.
      This is not the end of the story. The real underlying problem has to be
      understood and fixed correctly.
    • Cedric Roux's avatar
      hotfix: correct Msg3 ressource blocks reservation · 6bb69e19
      Cedric Roux authored
      The Msg3 ressource blocks used by random access procedure
      were not correctly handled. The MAC scheduler could wrongly
      allocate a ressource block for both random access Msg3 and
      a regular UE.
      This hotfix hopefully fixes the problem.
      A new function "set_msg3_subframe" has been added in the
      interface between PHY and MAC.
    • Cedric Roux's avatar
      T: add some traces · 43df2913
      Cedric Roux authored
      - Msg3 allocation
      - initiation of Random Access procedure
  31. 18 Nov, 2016 1 commit
    • Cedric Roux's avatar
      hotfix: correct PHICH generation · 64615dcc
      Cedric Roux authored
      The PHICH generation is wrong.
      HARQ process X is uplink scheduled at TTI n.
      At TTI n+4 the eNB receives the data.
      At TTI n+8 the eNB sends ACK/NACK on the PHICH.
      The problem is that PHICH generation is done after scheduling.
      And PHICH generation uses "first_rb" and "n_DMRS" to compute
      "ngroup_PHICH" and "nseq_PHICH".
      So at TTI n+8 if the eNB has reused the HARQ process X for
      a new uplink scheduling the values "first_rb" and "n_DMRS"
      may have changed.
      We need to use the previous values.
      One solution would have been to do PHICH generation before
      scheduling. The problem is that "generate_phich_top" does more
      than PHICH generation. It has to setup parameters to sort of
      "emulate" a DCI0 in case of retransmission scheduled without
      DCI0. So part of it has to be done after scheduling. We would
      have to split the function.
      The simple adopted fix is to store old values of "first_rb"
      and "n_DMRS" and use those values in "generate_phich_top".
      This fix has only been tested with FDD. TDD may miserably fail.