1. 07 Feb, 2018 2 commits
    • Cedric Roux's avatar
      bugfix: don't take into account report CQI in case of NACK or DTX · c0bcd786
      Cedric Roux authored
      The problem that may happen is that when the UE does not transmit
      on PUCCH (for whatever reason) we may get no signal at all, and
      thus compute a very low CQI. Later on we may ask the UE to transmit
      louder which may lead to saturation and more problems.
      
      The solution is simple: don't care about CQI in case of DTX
      (and NACK also, as done for PUSCH).
      
      Only FDD case done.
      For TDD it seems that:
      - nfapi structures are not correct. See nfapi_harq_indication_tdd_rel13_t
        in nfapi/open-nFAPI/nfapi/public_inc/nfapi_interface.h, all the cases
        (bundling, multiplex, ...) use nfapi_harq_indication_tdd_harq_data_t
      - the function extract_harq does not handle TDD
      c0bcd786
    • Cedric Roux's avatar
      minor: fix AssertFatal · 9b7364a3
      Cedric Roux authored
      9b7364a3
  2. 15 Jan, 2018 2 commits
    • Cedric Roux's avatar
      Fix NFAPI integration · 922b5b59
      Cedric Roux authored
      This commit fixes issues introduced by the previous commit.
      
      Summary of work:
      - cleanup:
        - fix LOG_XX to be less verbose
        - fix cmake_targets/CMakeLists.txt
        - fix oaienv
        - remove dead code
      - bug fixes:
        - in openair1/SCHED/fapi_l1.c we had:
            eNB->pdcch_vars[subframe&1].num_dci           = number_dci;
          should be:
            eNB->pdcch_vars[subframe&1].num_dci           = 0;
          This bug let the PHY send more DCIs than what should have been
          sent because num_dci is incremented later on in the code.
          This fix may be a problem for fapi mode, to be checked.
        - add new T VCD traces
        - revert openair1/PHY/TOOLS/file_output.c to 'develop' version
        - remove thread_id in logRecord/logRecord_mt
        - revert (and adapt) configuration files
        - be careful when doing frame++, we need to % 1024
        - revert target_rx_power in openair2/LAYER2/MAC/eNB_scheduler_ulsch.c
      - NFAPI:
        - the open-nFAPI code has been included in the repository. See nfapi/README.
          Maybe we should "git clone" the Cisco repository instead. We have to be
          careful of availability though.
      
      What has been tested:
      - monolithic eNB FDD 5/10MHz with one UE, iperf UDP/TCP uplink/downlink
      
      Anything else may fail to work, especially the FAPI mode, which has not
      been tested at all.
      922b5b59
    • Cedric Roux's avatar
      import NFAPI work from David Price from Cisco (non-working commit, do not use it) · 7757b9e7
      Cedric Roux authored
      It has been chosen to not include the full history of commits
      from David. He included a binary version of wireshark, probably
      a modified one that understands NFAPI. Wireshark is released under
      the GPL license, we cannot include it in the repository. We could
      have done a next commit to remove this binary. But then it would
      still be present in the history of commits, which may not be allowed.
      And it would take space on disk. We could edit the history to remove
      wireshark entirely. But this operation is too complicated.
      
      There was also a pcap capture file, which has nothing to do in
      the history of commits and would take space on disk. There again,
      it's too difficult to edit the history to remove it.
      
      There was a file .gitignore that was also removed.
      
      The original history can be found on David's repository:
      https://gitlab.eurecom.fr/daveprice/openairinterface5g/
      The branch is: nfapi-ru-rau-split.
      
      A copy of that branch has been included in the internal OAI
      repository, for those who have access to it.
      The branch is the same. The last commit ID is
      9106438239e0bc626ff1fa1d97d911caadd0fbb9.
      
      You can compare the current commit with the commit 9106...
      to see what differs.
      
      The current commit has to be considered non-working.
      The commit following the current commit will fix problems with
      the work in the current commit.
      
      If you use git bisect, don't spend time analyzing the current
      commit.
      7757b9e7
  3. 08 Jan, 2018 1 commit
  4. 28 Nov, 2017 1 commit
  5. 27 Nov, 2017 1 commit
  6. 14 Nov, 2017 1 commit
  7. 04 Nov, 2017 1 commit
  8. 23 Oct, 2017 1 commit
  9. 19 Oct, 2017 2 commits
    • Cedric Roux's avatar
      remove gcc warnings · f1e8bff3
      Cedric Roux authored
      phy_init_lte_ue_signal was renamed init_lte_ue_signal in openair1/PHY/INIT/defs.h
      maybe it's the opposite that should have been done?
      
      Functions used in one file and defined in another may have been
      declared in the wrong header file.
      f1e8bff3
    • Cedric Roux's avatar
      bugfix: clear memory · c78351c2
      Cedric Roux authored
      Old values valid for a previous UE have to be reset for the new UE.
      c78351c2
  10. 16 Oct, 2017 1 commit
    • Cedric Roux's avatar
      trying to get better power management · 3d14d571
      Cedric Roux authored
      - change target values
      - change upper/lower limit to trigger a tpc
      - don't use ul_cqi from SR
      
      The value of ul_cqi is not convincing, for both PUSCH and PUCCH,
      more work/analysis is required.
      3d14d571
  11. 12 Oct, 2017 1 commit
  12. 11 Oct, 2017 1 commit
  13. 10 Oct, 2017 1 commit
    • Cedric Roux's avatar
      bugfix: fix timing advance · 9b428e5e
      Cedric Roux authored
      - re-use ta_timer
      - when ta_timer is running:
        - no TA sent to UE
        - no TA from UE (for UE to have time to apply previous TA command)
      - decrease ta_timer every TTI
      - be careful to use correct value of ta_update (31 means no TA)
      
      Maybe not correct, to be checked.
      9b428e5e
  14. 08 Oct, 2017 1 commit
  15. 07 Oct, 2017 2 commits
  16. 06 Oct, 2017 4 commits
  17. 04 Oct, 2017 1 commit
    • Cedric Roux's avatar
      bugfix: fix CQI reporting · c97e0546
      Cedric Roux authored
      - don't use o_flip anymore in ulsch_decoding
      - remove dl_cqi from eNB_UE_STATS
      - put dl_cqi[NFAPI_CC_MAX] in UE_sched_ctrl
      - adapt code for this dl_cqi change (from eNB_UE_STATS to UE_sched_ctrl)
      - extract_pusch_csi has been fixed for CQI_ReportModeAperiodic_rm30,
        the others need to be done. Program will exit if one uses them.
        Not sure if setting sched_ctl->dl_cqi[CC_idP]  has to be done in this
        function...
      c97e0546
  18. 03 Oct, 2017 1 commit
  19. 02 Oct, 2017 2 commits
  20. 01 Oct, 2017 2 commits
  21. 28 Sep, 2017 1 commit
  22. 25 Sep, 2017 2 commits
  23. 24 Sep, 2017 1 commit
  24. 22 Sep, 2017 1 commit
  25. 21 Sep, 2017 1 commit
  26. 19 Sep, 2017 1 commit
  27. 15 Sep, 2017 1 commit
  28. 14 Sep, 2017 1 commit
  29. 29 Aug, 2017 1 commit
    • Cedric Roux's avatar
      T: add some new traces · 0daf79bf
      Cedric Roux authored
      - ENB_PHY_OUTPUT_SIGNAL to trace output signal
      - ENB_MAC_SCHEDULING_REQUEST to trace scheduling requests
      0daf79bf
  30. 17 Aug, 2017 1 commit