Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • openairinterface5G openairinterface5G
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 54
    • Issues 54
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 45
    • Merge requests 45
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • oai
  • openairinterface5Gopenairinterface5G
  • Issues
  • #320

Closed
Open
Created Jun 25, 2018 by Mongazon@BrunoDeveloper

Code cleanup - removal of "#if 0"

There is a set of source code encapsulated by "#if 0" macros. The general purpose for using such "#if 0" to comment the code. The reasons for commenting the code are various:

  • the code is obsolete
  • the code contains debug instructions which are sometimes activated, sometimes not
  • you don't want the code to be compiled, it needs further rework or may be not.

The global goal of the issue here is to remove all "#if 0" and prevent from further usage of such macros in the future, especially in code pushed to public branch such as master/develop.

Usage of such macros is not expected because:

  • the code is not necessarily aligned with other "active" parts of the code which makes it dying and difficult to recover (uncomment)
  • in the case of debug code, the debug code shall fit in the debug/log framework
  • such macros make the code more difficult to read and maintain

In case the issue has suppressed some parts of code which are expected to work in the future, the removed code can be recovered from a previous tag of the branch and incorporated as "active" code in the current code status.

Edited Jun 25, 2018 by Mongazon
Assignee
Assign to
Time tracking