Skip to content

Documentation Improvement: DMRS pilot generation function in gNB Rx is already with Conjugate

  • Issue: Sometimes, the code implementation is undocumented properly and it is hard to find OAI implementation specifics

    • The DMRS pilot generation function in gNB Rx actually generates conjugate complex DMRS (without indicating or describing this on the top-level function.
    • File: …/openairinterface5g/openair1/PHY/NR_ESTIMATION/nr_ul_channel_estimation.c
    • Code Section: Line 105 to Line 140
    • The title of this code section is: “generate DMRS” and the name of the function is nr_pusch_dmrs_rx ().
    • It has been addressed that the DMRS table is created for DMRS conjugate only in the nr mod table constant parameter, which is the last line that we are calling from it.

  • Simple Proposal:

    • Change the title of the section to   //------------------generate DMRS Conjugate ------------------//
    • File: …/openairinterface5g/openair1/PHY/NR_ESTIMATION/nr_ul_channel_estimation.c
    • Code Section: Line 105
    • Our team spent a time to debug our new channel estimator and the issue was that we considered the DMRS generation function as the original DMRS and not the conjugate one.