openairinterface5G merge requestshttps://gitlab.eurecom.fr/oai/openairinterface5g/-/merge_requests2023-04-07T14:08:35Zhttps://gitlab.eurecom.fr/oai/openairinterface5g/-/merge_requests/20442023-04-01: fix all bugs2023-04-07T14:08:35ZCédric Rouxcedric.roux@eurecom.fr2023-04-01: fix all bugsThis commit fixes all the bugs of openair.This commit fixes all the bugs of openair.REVIEW_CAN_STARThttps://gitlab.eurecom.fr/oai/openairinterface5g/-/merge_requests/11425G NR 2 layer DL MIMO2021-07-18T19:53:45ZThomas Schlichter5G NR 2 layer DL MIMOOK_TO_BE_MERGEDhttps://gitlab.eurecom.fr/oai/openairinterface5g/-/merge_requests/1646Add 4G L2simulator test2022-08-21T06:11:08ZRobert SchmidtAdd 4G L2simulator testAdd a 4G L2simulator test to RAN-Container-Parent. Tasks to be done:
- [x] Robert: pipeline [RAN-L2-Sim-Test-4G](https://jenkins-oai.eurecom.fr/view/RAN/job/RAN-L2-Sim-Test-4G/) should run once successfully
- [x] Robert: Add iperf (on m...Add a 4G L2simulator test to RAN-Container-Parent. Tasks to be done:
- [x] Robert: pipeline [RAN-L2-Sim-Test-4G](https://jenkins-oai.eurecom.fr/view/RAN/job/RAN-L2-Sim-Test-4G/) should run once successfully
- [x] Robert: Add iperf (on my machine, works up to 1.5Mbps in DL and 6.5 in UL)OK_TO_BE_MERGEDhttps://gitlab.eurecom.fr/oai/openairinterface5g/-/merge_requests/785Add .clang-format file2022-09-05T12:05:50ZRobert SchmidtAdd .clang-format fileI propose to add a clang-format configuration file, notably since it allows to configure a range of lines of a file instead of the whole file only. Documentation of the options: https://clang.llvm.org/docs/ClangFormatStyleOptions.html
#...I propose to add a clang-format configuration file, notably since it allows to configure a range of lines of a file instead of the whole file only. Documentation of the options: https://clang.llvm.org/docs/ClangFormatStyleOptions.html
# Integration into editors
Integration into various editors (vim, emacs, VSCode, CLion) is on the project page: https://clang.llvm.org/docs/ClangFormat.html
There is an eclipse plugin: https://github.com/wangzw/CppStyle
# Integration into git
See [here](https://gitlab.eurecom.fr/oai/openairinterface5g/-/merge_requests/785#note_28175) for a more detailed explanation. In short: Add this to `~/.gitconfig`:
```
[clangFormat]
binary = clang-format-12
style = file
```
Now stage files for reformatting, then run `git clang-format`. It will reformat only the code that is staged, and you can the view what with a `git diff` (thus, the modified lines are not automatically staged).
There is also a pre-commit hook that you can install in file `pre-commit-clang`. See the file for instructions of how to use.
# Differences to current astyle:
* I believe astyle aligns assignments. The clang-format file does not do this, and would need to have `AlignConsecutiveAssignments` set to true. Example:
```c
int aaaa = 12;
int b = 23;
int ccc = 23;
```
* Also, the astyle configuration mandates to break lines after a logical, but the current clang format file does it before. Should we keep the astyle behavior? Option `BreakBeforeBinaryOperators`
```c
if (thisVariable1 == thatVariable1 ||
thisVariable2 == thatVariable2 ||
thisVariable3 == thatVariable3)
bar();
```
vs.
```c
if (thisVariable1 == thatVariable1
|| thisVariable2 == thatVariable2
|| thisVariable3 == thatVariable3)
bar();
```
[^1]:
[^2]: [^3]:
[^4]:OK_TO_BE_MERGEDThomas Laurentlaurent.thomas@open-cells.comThomas Laurentlaurent.thomas@open-cells.comhttps://gitlab.eurecom.fr/oai/openairinterface5g/-/merge_requests/1112Adding no-cache options to make to take executables from Merge Requests2021-04-08T12:52:11ZRaphael DefosseuxAdding no-cache options to make to take executables from Merge RequestsAlso trying a no-compress option on RHEL8 podman to see build-time impact.Also trying a no-compress option on RHEL8 podman to see build-time impact.Mohammed IsmailMohammed Ismailhttps://gitlab.eurecom.fr/oai/openairinterface5g/-/merge_requests/1282Add MCS from HARQ BLER2021-11-14T08:29:00ZRobert SchmidtAdd MCS from HARQ BLER- Estimates correct MCS using EMA, kept between target thresholds
`dl_bler_target_upper` and `dl_bler_target_lower` (conf options) for 1st
retx and below `dl_rd2_bler_threshold` for 2nd retx
- Maximum MCS configurable
- on 3rd retx, ...- Estimates correct MCS using EMA, kept between target thresholds
`dl_bler_target_upper` and `dl_bler_target_lower` (conf options) for 1st
retx and below `dl_rd2_bler_threshold` for 2nd retx
- Maximum MCS configurable
- on 3rd retx, reduce MCS by 5
Issues:
- rename configuration option `dl_rd2_bler_threshold` for consistency?
- Needs manual testing*!*
- Should do the same for UL?REVIEW_COMPLETED_AND_APPROVEDhttps://gitlab.eurecom.fr/oai/openairinterface5g/-/merge_requests/545Add oai ue testing2019-03-29T11:24:42ZBoris DjalalAdd oai ue testingAdding a OAI UE test in the CI.Adding a OAI UE test in the CI.Raphael DefosseuxRaphael Defosseuxhttps://gitlab.eurecom.fr/oai/openairinterface5g/-/merge_requests/398Astyle integration test2018-09-26T10:21:20ZRaphael DefosseuxAstyle integration testThis is a test on how to astyle and merge to validate the process.
I've integrated 4 pending MRs:
* First I've astyled in each branch with the CI astyle option files the files that are been modified by the MR
* Then I merge into the in...This is a test on how to astyle and merge to validate the process.
I've integrated 4 pending MRs:
* First I've astyled in each branch with the CI astyle option files the files that are been modified by the MR
* Then I merge into the integration using `git merge -s recursive -Xtheirs src_branch` command
There was no merge conflictsRaphael DefosseuxRaphael Defosseuxhttps://gitlab.eurecom.fr/oai/openairinterface5g/-/merge_requests/399Astyle integration test22018-09-27T07:20:00ZRaphael DefosseuxAstyle integration test2This is a test on how to astyle and merge to validate the process.
I've integrated 4 pending MRs:
* First I've astyled in each branch with the CI astyle option files the files that are been modified by the MR
* Then I merge into the in...This is a test on how to astyle and merge to validate the process.
I've integrated 4 pending MRs:
* First I've astyled in each branch with the CI astyle option files the files that are been modified by the MR
* Then I merge into the integration using `git merge -s recursive -Xpatience src_branch` command
There were merge conflicts but they were quite trivialRaphael DefosseuxRaphael Defosseuxhttps://gitlab.eurecom.fr/oai/openairinterface5g/-/merge_requests/400Astyle integration test32018-09-27T07:19:51ZRaphael DefosseuxAstyle integration test3This is a test on how to astyle and merge to validate the process.
I've integrated 4 pending MRs:
- First I've astyled in each branch with the CI astyle option files the files that are been modified by the MR
- Then I merge into the i...This is a test on how to astyle and merge to validate the process.
I've integrated 4 pending MRs:
- First I've astyled in each branch with the CI astyle option files the files that are been modified by the MR
- Then I merge into the integration using `git merge -s recursive -Xdiff-algorithm=histogram src_branch` command
There were merge conflicts but they were quite trivial.
Compared to MR 399, I made one different choice on a mergeRaphael DefosseuxRaphael Defosseuxhttps://gitlab.eurecom.fr/oai/openairinterface5g/-/merge_requests/401Astyle integration test42018-09-28T08:37:50ZRaphael DefosseuxAstyle integration test4This is a test on how to astyle and merge to validate the process.
I've integrated 4 pending MRs:
- First I've astyled in each branch with the CI astyle option files the files that are been modified by the MR
- Then I merge into the i...This is a test on how to astyle and merge to validate the process.
I've integrated 4 pending MRs:
- First I've astyled in each branch with the CI astyle option files the files that are been modified by the MR
- Then I merge into the integration using `git merge -s recursive -Xpatience src_branch` command
There were merge conflicts but they were quite trivial
CI will run after each branch mergeRaphael DefosseuxRaphael Defosseuxhttps://gitlab.eurecom.fr/oai/openairinterface5g/-/merge_requests/1029Benetel driver update2021-03-01T20:08:25ZFlorian KaltenbergerBenetel driver updateThis MR fixes an issue with the driver for the 4G Benetel RRUs, which should work again now.
Power levels on the 5G side were adapted to avoid saturation of the signals. 5G performance is now the same as with USRP.
Support for 2 antenna...This MR fixes an issue with the driver for the 4G Benetel RRUs, which should work again now.
Power levels on the 5G side were adapted to avoid saturation of the signals. 5G performance is now the same as with USRP.
Support for 2 antennas for both 4G and 5G was addedhttps://gitlab.eurecom.fr/oai/openairinterface5g/-/merge_requests/1126Bugfix nr t reordering2021-06-14T10:54:02ZCédric Rouxcedric.roux@eurecom.frBugfix nr t reordering- deal with "infinity" case for t-reordering
- some small fixes (one bug i pdcp, one log set to LOG_E in rlc)- deal with "infinity" case for t-reordering
- some small fixes (one bug i pdcp, one log set to LOG_E in rlc)OK_TO_BE_MERGEDhttps://gitlab.eurecom.fr/oai/openairinterface5g/-/merge_requests/873BUILD: fix for new API on load_softscope2020-08-20T05:47:59ZRaphael DefosseuxBUILD: fix for new API on load_softscopeSomething that was missed during previous integration (`2020.w31`).Something that was missed during previous integration (`2020.w31`).Raphael DefosseuxRaphael Defosseuxhttps://gitlab.eurecom.fr/oai/openairinterface5g/-/merge_requests/1681Build RHEL8 images on Openshift Cluster2022-09-16T08:38:03ZRobert SchmidtBuild RHEL8 images on Openshift ClusterDevelopment for a new pipeline that builds RHEL8 images on cluster instead of the existing server.
The [build time on the existing RHEL8 builder pipeline](https://jenkins-oai.eurecom.fr/job/RAN-RHEL8-Image-Builder/buildTimeTrend) is usu...Development for a new pipeline that builds RHEL8 images on cluster instead of the existing server.
The [build time on the existing RHEL8 builder pipeline](https://jenkins-oai.eurecom.fr/job/RAN-RHEL8-Image-Builder/buildTimeTrend) is usually 30-40min. I expect the new pipeline to execute everything in 10-15 min (maybe a bit more), similar to the [Ubuntu builder pipeline](https://jenkins-oai.eurecom.fr/job/RAN-Ubuntu18-Image-Builder/buildTimeTrend). In other words, this work will speed up the RAN-Container-Parent by 15min.
The physim python code has been updated to expect the physim images directly on the image registry.
Tasks to be done:
- [x] Add to Gitlab Jenkinsfile: https://jenkins-oai.eurecom.fr/view/RAN/job/RAN-RHEL8-Cluster-Image-Builder/
- [x] Need to check whether it is faster to build the target images (gNB, eNB, ...) serially and not in parallel
- [x] it seems the Pipeline does not pick up the XML file @defosseu could you please check? -> I used the wrong branch/need to have the pipeline clone ci-build-cluster branch into Jenkins workspaceOK_TO_BE_MERGEDThomas Laurentlaurent.thomas@open-cells.comThomas Laurentlaurent.thomas@open-cells.comhttps://gitlab.eurecom.fr/oai/openairinterface5g/-/merge_requests/666CDRX Testing with multiple UEs2019-10-11T11:14:01ZRaphael DefosseuxCDRX Testing with multiple UEsCDRX testing was limited to 1 UE due to instability. Back to normal testingCDRX testing was limited to 1 UE due to instability. Back to normal testingRaphael DefosseuxRaphael Defosseuxhttps://gitlab.eurecom.fr/oai/openairinterface5g/-/merge_requests/1697chore(ci): putting the Legacy LTE CI bench in order2022-09-24T11:16:45ZRaphael Defosseuxchore(ci): putting the Legacy LTE CI bench in order* a few typos
* some adaptations to scenarios/conf files
Mainly explicitly applying the TDD patch for B2xx.
Tagging also @florian.kaltenberger @lthomas @cedric.roux* a few typos
* some adaptations to scenarios/conf files
Mainly explicitly applying the TDD patch for B2xx.
Tagging also @florian.kaltenberger @lthomas @cedric.rouxOK_TO_BE_MERGEDRobert SchmidtRobert Schmidthttps://gitlab.eurecom.fr/oai/openairinterface5g/-/merge_requests/2137chore(ci): removing OAI-Rel14-CUPS old bare-metal 4G core installation variant2023-06-03T22:10:11ZRaphael Defosseuxchore(ci): removing OAI-Rel14-CUPS old bare-metal 4G core installation variantReviewing one of Robert's refactoring effort, I saw that this code is never used anymore.Reviewing one of Robert's refactoring effort, I saw that this code is never used anymore.OK_TO_BE_MERGEDRobert SchmidtRobert Schmidthttps://gitlab.eurecom.fr/oai/openairinterface5g/-/merge_requests/1935chore(ci): updating simulators docker-compose files for CN5G release v1.52023-02-20T08:36:37ZRaphael Defosseuxchore(ci): updating simulators docker-compose files for CN5G release v1.5I've pulled the `CN5G` `v1.5.0` images on `obelix` and `bellatrix`.
But if I did not, the first run would pull them automatically and that's better for the normal users.
Also preparing move of some of our python executors to a Ubuntu22 ...I've pulled the `CN5G` `v1.5.0` images on `obelix` and `bellatrix`.
But if I did not, the first run would pull them automatically and that's better for the normal users.
Also preparing move of some of our python executors to a Ubuntu22 server:
* Support for `docker-compose` version 2.x
* U22 issue on how to handle background tasks through `subprocess`: using `pyshark` live-capture
We also pulled the `CN5G` `v1.5.0` images on `porcepix` and Dhanuja tested w/ AS-UE.
So updating the EPC call to deploy this version when running `NSA-trigger` pipelineOK_TO_BE_MERGEDRobert SchmidtRobert Schmidthttps://gitlab.eurecom.fr/oai/openairinterface5g/-/merge_requests/1150[CI] 5G phy test stats html report2021-05-04T06:28:55ZRemi Hardy[CI] 5G phy test stats html reportOK_TO_BE_MERGED