openairinterface5G merge requestshttps://gitlab.eurecom.fr/oai/openairinterface5g/-/merge_requests2024-03-28T22:39:42Zhttps://gitlab.eurecom.fr/oai/openairinterface5g/-/merge_requests/2649NR SRS RRC assrtion removal2024-03-28T22:39:42ZFrancesco ManiNR SRS RRC assrtion removalThis MR removes an assertion in SRS RRC config that was already been removed in 28fb7a37d7b45cf3dd6371709a5f2d3eb38b3fb6 but somehow has been put back in the codeThis MR removes an assertion in SRS RRC config that was already been removed in 28fb7a37d7b45cf3dd6371709a5f2d3eb38b3fb6 but somehow has been put back in the codeREVIEW_COMPLETED_AND_APPROVEDhttps://gitlab.eurecom.fr/oai/openairinterface5g/-/merge_requests/2646NRUE fix asn_sequence_del to clear a list2024-03-28T21:06:59ZFrancesco ManiNRUE fix asn_sequence_del to clear a listThis MR addresses the issue of element deletion from the sequences with a backward iteration method to prevent skipping elements during deletion.This MR addresses the issue of element deletion from the sequences with a backward iteration method to prevent skipping elements during deletion.REVIEW_COMPLETED_AND_APPROVEDhttps://gitlab.eurecom.fr/oai/openairinterface5g/-/merge_requests/2641NR DL and UL channel estimation fix2024-03-28T10:26:55ZFrancesco ManiNR DL and UL channel estimation fixIn both DL and UL channel estimation, when filling `ul_ch_estimates` the DMRS antenna port was used. Instead when looking into the same structure `ul_ch_estimates` we would use the layer index. The two parameters may not be the same, the...In both DL and UL channel estimation, when filling `ul_ch_estimates` the DMRS antenna port was used. Instead when looking into the same structure `ul_ch_estimates` we would use the layer index. The two parameters may not be the same, the latter should be used.REVIEW_COMPLETED_AND_APPROVEDhttps://gitlab.eurecom.fr/oai/openairinterface5g/-/merge_requests/2636Fix various F1 problems2024-03-28T16:37:56ZRobert SchmidtFix various F1 problems- Fix a bug related to #706
- Fix a bug where receive a F1 message unknown to the CU makes it crash: closes #762
- Take time stamps of when last UE RRC activity has occurred
- ~Implement signal handler to do RRC "house keeping": inacti...- Fix a bug related to #706
- Fix a bug where receive a F1 message unknown to the CU makes it crash: closes #762
- Take time stamps of when last UE RRC activity has occurred
- ~Implement signal handler to do RRC "house keeping": inactive UEs will be released, as requested by @raymond.knopp~REVIEW_COMPLETED_AND_APPROVEDSagar Arorasagar.arora@openairinterface.orgSagar Arorasagar.arora@openairinterface.orghttps://gitlab.eurecom.fr/oai/openairinterface5g/-/merge_requests/2635SCTP problems: allow to bind separate F1-C/F1-U interfaces; allow to use DNS2024-03-28T17:54:44ZRobert SchmidtSCTP problems: allow to bind separate F1-C/F1-U interfaces; allow to use DNS- revert commit to fix issue #727
- introduce new option to bind on a separate address for F1U; if not specified, will reuse F1C; fix in CI; add doc
- rewrite SCTP functions to use C's `getaddrinfo()` to look up DNS names. This also al...- revert commit to fix issue #727
- introduce new option to bind on a separate address for F1U; if not specified, will reuse F1C; fix in CI; add doc
- rewrite SCTP functions to use C's `getaddrinfo()` to look up DNS names. This also allows to IPv6, but more work in the stack is necessary to fully use IPv6 (C-plane works, U-plane doesn't)
- remove all interface name config options (are not used), remove `ipv6` config options (handled through `ipv4`)
Closes #727REVIEW_COMPLETED_AND_APPROVEDLuis Pereiralpereira@allbesmart.ptLuis Pereiralpereira@allbesmart.pthttps://gitlab.eurecom.fr/oai/openairinterface5g/-/merge_requests/2619Minor PDCP fixes2024-03-28T17:29:46ZGuido CasatiMinor PDCP fixes- Flag RBs as suspended in PDCP: this prevents pulling PDUs from PDCP when re-establishment is awaiting
- Use a define for PDCP formats
related to investigation work done in #739- Flag RBs as suspended in PDCP: this prevents pulling PDUs from PDCP when re-establishment is awaiting
- Use a define for PDCP formats
related to investigation work done in #739REVIEW_COMPLETED_AND_APPROVEDGuido CasatiGuido Casatihttps://gitlab.eurecom.fr/oai/openairinterface5g/-/merge_requests/2617use UE ID instead of RNTI internally in NR RLC2024-03-28T23:01:40ZFrancesco Maniuse UE ID instead of RNTI internally in NR RLCREVIEW_COMPLETED_AND_APPROVEDhttps://gitlab.eurecom.fr/oai/openairinterface5g/-/merge_requests/2605Improve performance polar encoder i.e., 3GPP 38.212 5.3.1.2 function2024-03-28T12:55:07ZMikel IrazabalImprove performance polar encoder i.e., 3GPP 38.212 5.3.1.2 functionImprove the polar encoding e.g., u->d or the Kronecker matrix according to 3GPP 38.212 5.3.1.2.
From a N^2 algorithm to NlogN
Benchmark results for N = 512 bits e.g., PBCH:
```
2024-03-05T17:48:44+01:00
Running ./a.out
Run on (8 X 148...Improve the polar encoding e.g., u->d or the Kronecker matrix according to 3GPP 38.212 5.3.1.2.
From a N^2 algorithm to NlogN
Benchmark results for N = 512 bits e.g., PBCH:
```
2024-03-05T17:48:44+01:00
Running ./a.out
Run on (8 X 1480.55 MHz CPU s)
CPU Caches:
L1 Data 48 KiB (x4)
L1 Instruction 32 KiB (x4)
L2 Unified 1280 KiB (x4)
L3 Unified 12288 KiB (x1)
Load Average: 0.53, 0.47, 0.56
-----------------------------------------------------------
Benchmark Time CPU Iterations
-----------------------------------------------------------
BM_POLAR_OAI 1322 ns 1321 ns 483230
BM_POLAR_OAI_NEW 140 ns 140 ns 4998694
```
Code for the benchmark:
`https://github.com/mirazabal/bm_polar_encoder.git`
When measuring directly in the OAI function nr_polar_uxG, the first result glance show a performance improvement between x7 and x15 with no load (only ping traffic).
PS: I can connect and send data using RFSim. However, the validation test to compare the output of both algorithms, when feed with random data does not pass. I suspect that the problem may lay in the table constants, as the validation test passes when compared with other polar implementations e.g., srsRAN. ToDO: Carefully observe CI tests results.REVIEW_COMPLETED_AND_APPROVEDknoppknopp