Skip to content
  • Bi-Ruei, Chiu's avatar
    Compare version number using MAKE_VERSION macro to provide better SW configuration: · 5c23af77
    Bi-Ruei, Chiu authored and Cédric Roux's avatar Cédric Roux committed
    1. Previous SW configuration for different RRC version relies on whether macro Rel10,
       Rel14 defined or not by checking #ifdef Rel14 or #if defined(Rel10) || defined(R14).
       Whenever there is a newer RRC version, e.g. Rel15, it will be very a tedious and
       error-prone job to add defined(Rel15) in every place.
    
    2. Some RRC messages are defined in release 13 instead of release 14, NB-IoT
       feature is one of such example. Our code shall reflect this fact instead of using
       an afterward version number in software configuration.
    
    3. Some RRC messages or some fields of certain RRC messages are added in the middle
       a release, e.g. SystemInformationBlockType1_v1310_IEs_t defined in RRC 13.1.0
       and RRC 9.2.0 made some changes to SIB12 and SIB13 so we have sib12_v920 and
       sib13_v920 fields in SIB12 and SIB13's struct.
       We need a finer grain of control when using ASN1 from different RRC version.
    
    4. S1AP also has this problem that it use UPDATE_RELEASE_9 and UPDATE_RELEASE_10 to
       differentiate between various S1AP version.
    
    This commit propose using MAKE_VERSION(x,y,z) to designate the version number and
    modify current conditional compilation accordingly.
    
    Note: 2018/04/16, Modified based on Cedric's comment.
    5c23af77