1. 19 Jan, 2017 3 commits
    • Cedric Roux's avatar
      hack to avoid zombie UEs in the MAC layer · 5933f218
      Cedric Roux authored
      Here is the problem:
          Sometimes the UE has no PHY context but
          is still present in the MAC with 'ul_failure_timer' = 0 and
          'ul_out_of_sync' = 0. It seems wrong and the UE stays there forever. Let's
          start an UL out of sync procedure in this case.
          The root cause of this problem has to be found and corrected.
          In the meantime, this hack...
      
      This has to be redone at some point.
      5933f218
    • Cedric Roux's avatar
      hack in RLC AM to avoid a race · 38b38779
      Cedric Roux authored
      Here is the problem:
          UE comes. SRB2 is configured via message to RRC.
          At some point the RLC AM is created but not configured yet.
          At this moment (I think) MAC calls mac_rlc_status_ind
          which calls this function. But the init was not finished yet
          and we have a crash below when testing mem_block != NULL.
      
      The "solution" is to test if rlc->input_sdus is NULL.
      This is a very dirty hack. I would say the solution
      is to use proper locking mechanism because RLC is used
      by two threads: PHY/MAC on one hand and RRC on another
      hand (I think).
      38b38779
    • Cedric Roux's avatar
      remove annoying logging (dump_CCE_table) · 05d02c43
      Cedric Roux authored
      05d02c43
  2. 18 Jan, 2017 1 commit
    • Cedric Roux's avatar
      bugfix: reset DCI count before adding one · adbc609b
      Cedric Roux authored
      The management of uplink failure generates a DCI to send
      a RA PDCCH order. It calls add_ue_spec_dci which increases
      DCI_pdu[CC_id]->Num_ue_spec_dci, but this was reset to 0
      *after* the DCI generation. Let's reset *before*.
      
      Bug reported by Liang Yong on openair5g-user mailing list.
      adbc609b
  3. 16 Jan, 2017 1 commit
    • Cedric Roux's avatar
      fix the use of get_eNB_UE_stats · 67e53e72
      Cedric Roux authored
      The function may return NULL if the UE has been dropped
      in the PHY layer but is still present in the MAC layer.
      
      Deal with the NULL case everywhere it's needed.
      67e53e72
  4. 12 Jan, 2017 2 commits
    • Cedric Roux's avatar
      fix compilation of RRH GW · ab7a3e8e
      Cedric Roux authored
      I am not sure this is the correct solution.
      
      The problem seems to be that the RRH GW does not use ITTI
      and thus the type 'as_nas_info_t' is not defined, and then
      the compilation fails.
      
      The simple fix is to include 'as_message.h' in
      'openair2/RRC/LITE/defs.h' if ENABLE_ITTI is not
      defined. Maybe it's not good. RRH GW compiles with this fix.
      ab7a3e8e
    • Cedric Roux's avatar
      fix duplicated definition of boolean_t · 669aa1fb
      Cedric Roux authored
      It is defined both in openair2/COMMON/commonDef.h and
      openair2/COMMON/platform_types.h.
      
      Removing one or the other definition creates many problems
      when compiling this or that part of the system (ue_ip.ko,
      at_nas_ue). Let's keep both and protect the definitions
      inside #ifdefs.
      669aa1fb
  5. 11 Jan, 2017 1 commit
    • Cedric Roux's avatar
      fix LOG_X macros · f2f32f53
      Cedric Roux authored
      Some of them might not be correctly handled.
      I put /* TODO: XXX */ where I didn't know if
      the fix was correct.
      f2f32f53
  6. 10 Jan, 2017 1 commit
    • Cedric Roux's avatar
      add format indicator to get LOG_X warnings · cb67d586
      Cedric Roux authored
      The LOG_X macros emit a lot of warnings when compiling with the T
      because they call the function logRecord (or logRecord_mt)
      which has not been "marked" as calling printf, so gcc won't
      emit typical printf warnings.
      
      With the T, they directly translate to sprintf, so those warnings
      pop up, much more verbose due to several macro expansions.
      
      Let's make them pop up all the time so it's easier to fix them.
      cb67d586
  7. 09 Jan, 2017 1 commit
  8. 06 Jan, 2017 3 commits
  9. 05 Jan, 2017 1 commit
  10. 21 Dec, 2016 6 commits
  11. 14 Dec, 2016 1 commit
  12. 13 Dec, 2016 1 commit
  13. 12 Dec, 2016 3 commits
  14. 08 Dec, 2016 3 commits
  15. 07 Dec, 2016 3 commits
  16. 06 Dec, 2016 1 commit
  17. 05 Dec, 2016 2 commits
  18. 29 Nov, 2016 1 commit
  19. 28 Nov, 2016 3 commits
  20. 24 Nov, 2016 2 commits