1. 16 Jan, 2018 3 commits
  2. 15 Jan, 2018 1 commit
  3. 11 Jan, 2018 1 commit
  4. 22 Nov, 2017 1 commit
  5. 23 Oct, 2017 1 commit
  6. 19 Oct, 2017 1 commit
    • Cedric Roux's avatar
      remove gcc warnings · f1e8bff3
      Cedric Roux authored
      phy_init_lte_ue_signal was renamed init_lte_ue_signal in openair1/PHY/INIT/defs.h
      maybe it's the opposite that should have been done?
      
      Functions used in one file and defined in another may have been
      declared in the wrong header file.
      f1e8bff3
  7. 01 Oct, 2017 1 commit
  8. 28 Sep, 2017 1 commit
  9. 07 Aug, 2017 1 commit
    • Cedric Roux's avatar
      fix vcd · 309ca066
      Cedric Roux authored
      several problems were present:
      - there was no comma after "ue0_trx_write_ns_missing" in the array
        eurecomVariablesNames;
        comma was put, and also commas for the last element in the array,
        which doesn't hurt and will prevent future problems
      - bad order of values in eurecomVariablesNames, which
        was different from the enum vcd_signal_dump_variables;
        order was checked and fixed
      - strange/wrong use of VCD_SIGNAL_DUMPER_MODULE_END/LAST;
        the whole logic was removed/simplified
      309ca066
  10. 06 Jul, 2017 1 commit
  11. 04 Jun, 2017 1 commit
  12. 02 Jun, 2017 2 commits
    • Frank Zdarsky's avatar
    • Cedric Roux's avatar
      integration fixes · 60c4b5ec
      Cedric Roux authored
      - rename UE_NO_LOG to DISABLE_LOG_X
        because the name is misleading. The full software
        is impacted, not only the UE part
      - same for compilation option ---ue-no-log
        that becomes --disable-log
      - keep LOG_X for the standard case, that is the
        case without DISABLE_LOG_X where printf has been
        put. Two reasons:
        * printf is not realtime friendly
        * keep behavior similar for other users who may
          be troubled by different logs that don't add
          any benefit to previous logs
      60c4b5ec
  13. 22 May, 2017 1 commit
  14. 19 May, 2017 2 commits
    • Gabriel's avatar
      Remove some logs · abf30c20
      Gabriel authored
      abf30c20
    • Gabriel's avatar
      UE logging change : · fe350d5b
      Gabriel authored
      --ue-trace : Enabling UE trace for debug
      --ue-timing : Enabling UE timing trace
      --ue-no-log : Disabling all LOG_X traces
      fe350d5b
  15. 18 May, 2017 1 commit
    • Cedric Roux's avatar
      redo commit cb67d586 · 94dd8843
      Cedric Roux authored
      Seems like this commit got lost at some point.
      
      Here was the message:
      -----------------------------------------------------------------------------
      Author: Cedric Roux <cedric.roux@eurecom.fr>
      Date:   Tue Jan 10 14:21:02 2017 +0100
      
          add format indicator to get LOG_X warnings
      
          The LOG_X macros emit a lot of warnings when compiling with the T
          because they call the function logRecord (or logRecord_mt)
          which has not been "marked" as calling printf, so gcc won't
          emit typical printf warnings.
      
          With the T, they directly translate to sprintf, so those warnings
          pop up, much more verbose due to several macro expansions.
      
          Let's make them pop up all the time so it's easier to fix them.
      -----------------------------------------------------------------------------
      94dd8843
  16. 12 May, 2017 1 commit
    • Gabriel's avatar
      bug fixes from Fujitsu (bug 21) · 98a7a16e
      Gabriel authored
      Note: this fix does not solve the issue with how
      this buffer is used in this function, but I'm not
      sure this code is used at all (Cédric Roux).
      
      ----------------------------------------------------------
      bug 21
      
      Ttile:
      PAYLOAD_MAX=1500, so this coding results in index overflow.
      Additionally, operator "!=" just compairs something, this
      coding is meaningless.
      
      Bug Location:
      buffer[PAYLOAD_MAX] != '\0';
      
      Note:
      Detected by CppCheck
      ----------------------------------------------------------
      98a7a16e
  17. 19 Apr, 2017 1 commit
  18. 18 Apr, 2017 1 commit
  19. 17 Apr, 2017 1 commit
  20. 03 Apr, 2017 1 commit
    • Cedric Roux's avatar
      integration fix: fixes for pthread_getname_np · c36c0453
      Cedric Roux authored
      - define _GNU_SOURCE before including pthread.h
      - do not use static for the array 'threadname' used
        to store the name, it makes it a global variable
        accessed by several threads in parallel
      - increase size of 'threadname' (maybe not necessary)
      - properly indent #define / #under (# should be at column 1)
      c36c0453
  21. 28 Mar, 2017 2 commits
  22. 23 Feb, 2017 1 commit
    • Cedric Roux's avatar
      hotfix: pass "%s" to LOG_W to avoid compilation warnings · 60b83d84
      Cedric Roux authored
      The warning was:
      
      ------------------------
      In file included from /roux/openairinterface5g/openair2/UTIL/LOG/log.h:306:0,
                       from /roux/openairinterface5g/openair1/PHY/defs.h:54,
                       from /roux/openairinterface5g/openair2/LAYER2/MAC/eNB_scheduler_ulsch.c:33:
      /roux/openairinterface5g/openair2/UTIL/LOG/log.h: In function 'printMeas':
      /roux/openairinterface5g/common/utils/T/T.h:94:26: warning: format not a string literal and no format arguments [-Wformat-security]
       #define T_ID(x) ((struct T_header *)(uintptr_t)(x))
                                ^
      /roux/openairinterface5g/common/utils/T/T.h:29:22: note: in definition of macro 'T_PUT_int'
           int T_PUT_var = (val); \
                            ^
      /roux/openairinterface5g/common/utils/T/T.h:269:7: note: in expansion of macro 'T_HEADER'
             T_HEADER(t); \
             ^
      /roux/openairinterface5g/common/utils/T/T.h:101:76: note: in expansion of macro 'T3'
               n18,n19,n20,n21,n22,n23,n24,n25,n26,n27,n28,n29,n30,n31,n32,n,...) T##n
                                                                                  ^
      /roux/openairinterface5g/common/utils/T/T.h:102:16: note: in expansion of macro 'TN'
       #define T(...) TN(__VA_ARGS__)
                      ^
      /roux/openairinterface5g/openair2/UTIL/LOG/log.h:308:28: note: in expansion of macro 'T'
       #    define LOG_W(c, x...) T(T_LEGACY_ ## c ## _WARNING, T_PRINTF(x))
                                  ^
      /roux/openairinterface5g/common/utils/T/T_IDs.h:71:30: note: in expansion of macro 'T_ID'
       #define T_LEGACY_PHY_WARNING T_ID(68)
                                    ^
      /roux/openairinterface5g/openair2/UTIL/LOG/log.h:308:30: note: in expansion of macro 'T_LEGACY_PHY_WARNING'
       #    define LOG_W(c, x...) T(T_LEGACY_ ## c ## _WARNING, T_PRINTF(x))
                                    ^
      /roux/openairinterface5g/openair2/UTIL/LOG/log.h:411:9: note: in expansion of macro 'LOG_W'
               LOG_W(PHY,txt2);
      ------------------------
      
      over and over.
      
      By replacing LOG_W(PHY,txt2) by LOG_W(PHY,"%s",txt2) all the warnings
      are removed.
      60b83d84
  23. 17 Feb, 2017 3 commits
    • Cedric Roux's avatar
      warning fix: remove pragma in LFDS · 74afbf84
      Cedric Roux authored
      Not sure that it's correct, but those #pragma seem
      to be of no use for gcc. Let's remove them
      completely.
      74afbf84
    • Cedric Roux's avatar
      Revert "fix nettle" · 76574a1a
      Cedric Roux authored
      This reverts commit d31634c3.
      
      Laurent Thomas had a problem on one machine with the build_oai
      way of checking for nettle.
      
      The problem with the alternative solution of including nettle/bignum.h
      is that it is very unclear.
      
      The problem with nettle is that the file nettle/config.h does not
      exist for version 2. It was introduced in version 3.
      
      We want to support both versions, but there is an API incompatibility.
      So we need an #if #else mechanism.
      
      The file nettle/bignum.h is present in both versions 2 and 3 and it
      includes nettle/version.h in the version 3.
      
      So by including this file, we can check for the existence of
      NETTLE_VERSION_MAJOR (that comes from nettle/config.h) in the
      code.
      
      But as you can see, the reasoning is way too complex.
      
      So it's better to keep the check in cmake_targets/CMakeLists.txt.
      
      As long as we support version 2 this will be the way to go.
      
      It is possible to force a given version in specific non-generic
      customized environments.
      76574a1a
    • pyroclaste's avatar
  24. 14 Feb, 2017 1 commit
  25. 09 Feb, 2017 1 commit
  26. 25 Jan, 2017 1 commit
    • Imad ALAWE's avatar
      openairinterface5g: Fix multi definition of UE/eNB NB_MAX · b3ded779
      Imad ALAWE authored
      In openairinterface5g many definitions in many layers of UE or eNB NB_MAX.
      We created a file called openairinterface5g_limits.h
      located at openairinterface5g_dir/targets/COMMON/ declaring the number max
      of UE and eNB to be used in ALL layers depending on launching conditions
      (LARGE_SCALE for example).
      b3ded779
  27. 16 Jan, 2017 2 commits
  28. 15 Jan, 2017 1 commit
  29. 11 Jan, 2017 1 commit
    • Cedric Roux's avatar
      fix LOG_X macros · f2f32f53
      Cedric Roux authored
      Some of them might not be correctly handled.
      I put /* TODO: XXX */ where I didn't know if
      the fix was correct.
      f2f32f53
  30. 10 Jan, 2017 1 commit
    • Cedric Roux's avatar
      add format indicator to get LOG_X warnings · cb67d586
      Cedric Roux authored
      The LOG_X macros emit a lot of warnings when compiling with the T
      because they call the function logRecord (or logRecord_mt)
      which has not been "marked" as calling printf, so gcc won't
      emit typical printf warnings.
      
      With the T, they directly translate to sprintf, so those warnings
      pop up, much more verbose due to several macro expansions.
      
      Let's make them pop up all the time so it's easier to fix them.
      cb67d586
  31. 07 Jan, 2017 1 commit
  32. 06 Jan, 2017 1 commit