1. 27 Jul, 2017 1 commit
    • Cedric Roux's avatar
      bugfix: fix bug "Unknown UE_id for rnti" · 8d5901c8
      Cedric Roux authored
      This bug happens when we detect uplink failure for one UE.
      In this case, a DCI format 1A is sent to the UE to ask it
      to do random acces.
      
      The way this DCI is generated was not compatible with how
      the software is organized. It was expected that the DCI are
      added (with add_ue_spec_dci and add_common_dci) in a very
      specific order: first all DCIs in common space are added
      (with add_common_dci) then all DCIs in UE specific space
      are added (with add_ue_spec_dci).
      
      The problem was that the DCI format 1A DCI sent to the UE
      for it to do random access is added (with add_ue_spec_dci)
      before the DCIs in common space.
      
      That totally messed up the logic in add_common_dci and
      add_ue_spec_dci.
      
      The solution is to get rid of Num_common_dci and Num_ue_spec_dci,
      replace those two counters by only one (Num_dci) and add
      "search_space" in the dci_alloc structure to be used later by
      the function "allocate_CCEs" when calling "get_nCCE_offset".
      
      The software had to be adapted to the new variables, everywhere.
      
      I am not sure that the simulators work. It seems that some
      of them didn't use Num_common_dci and Num_ue_spec_dci to
      decide on what space (common or UE specific) to put the DCI,
      but relied on the rnti (comparing with SI_RNTI). To be tested
      properly.
      
      The modified simulators are:
        - openair1/SIMULATION/LTE_PHY/dlsim.c
        - openair1/SIMULATION/LTE_PHY/dlsim_tm4.c
        - openair1/SIMULATION/LTE_PHY/dlsim_tm7.c
        - openair1/SIMULATION/LTE_PHY/framegen.c
        - openair1/SIMULATION/LTE_PHY/pdcchsim.c
        - openair1/SIMULATION/LTE_PHY/syncsim.c
      8d5901c8
  2. 29 Jun, 2017 1 commit
  3. 02 Jun, 2017 2 commits
    • Frank Zdarsky's avatar
    • Cedric Roux's avatar
      integration fixes · 60c4b5ec
      Cedric Roux authored
      - rename UE_NO_LOG to DISABLE_LOG_X
        because the name is misleading. The full software
        is impacted, not only the UE part
      - same for compilation option ---ue-no-log
        that becomes --disable-log
      - keep LOG_X for the standard case, that is the
        case without DISABLE_LOG_X where printf has been
        put. Two reasons:
        * printf is not realtime friendly
        * keep behavior similar for other users who may
          be troubled by different logs that don't add
          any benefit to previous logs
      60c4b5ec
  4. 23 May, 2017 3 commits
  5. 22 May, 2017 3 commits
  6. 19 May, 2017 3 commits
  7. 18 May, 2017 5 commits
    • Cedric Roux's avatar
      warning removal · c08bd6ba
      Cedric Roux authored
      force j to -1, there is a compilation warning with the T tracer
      (variable may be used uninitialized)
      c08bd6ba
    • Cedric Roux's avatar
      minor: warnings removal · dcfdd761
      Cedric Roux authored
      It seems that ciphering_algorithm is "unsigned int" in RRC Rel10
      and "unsigned long" in RRC Rel14 (as processed by asn1c)
      
      Let's force it to unsigned long in the log to avoid compilation-time
      warnings.
      dcfdd761
    • Cedric Roux's avatar
      warnings removal in LOG_X · 9d65f4dd
      Cedric Roux authored
      those popped up thanks to previous commit
      9d65f4dd
    • Cedric Roux's avatar
      redo commit cb67d586 · 94dd8843
      Cedric Roux authored
      Seems like this commit got lost at some point.
      
      Here was the message:
      -----------------------------------------------------------------------------
      Author: Cedric Roux <cedric.roux@eurecom.fr>
      Date:   Tue Jan 10 14:21:02 2017 +0100
      
          add format indicator to get LOG_X warnings
      
          The LOG_X macros emit a lot of warnings when compiling with the T
          because they call the function logRecord (or logRecord_mt)
          which has not been "marked" as calling printf, so gcc won't
          emit typical printf warnings.
      
          With the T, they directly translate to sprintf, so those warnings
          pop up, much more verbose due to several macro expansions.
      
          Let's make them pop up all the time so it's easier to fix them.
      -----------------------------------------------------------------------------
      94dd8843
    • Cedric Roux's avatar
      add CQI to periodic logging of UE · f6693af6
      Cedric Roux authored
      f6693af6
  8. 15 May, 2017 1 commit
  9. 13 May, 2017 1 commit
    • Cedric Roux's avatar
      rewrite phy_stats_exist · 9eaee53b
      Cedric Roux authored
      We have to test that all active CCs of a given UE exist in the PHY layer.
      Maybe not the end of the story...
      9eaee53b
  10. 12 May, 2017 3 commits
    • Tien-Thinh Nguyen's avatar
      fix the errors related to multiple carriers (for a given UE considering only... · 3d4ba1a3
      Tien-Thinh Nguyen authored
      fix the errors related to multiple carriers (for a given UE considering only the CCs which this UE belongs to)
      3d4ba1a3
    • Gabriel's avatar
      bug fixes from Fujitsu (bug 26) · 899d1506
      Gabriel authored
      ```-------------------------------------------------------
      bug 26
      
      Ttile:
      g_buffer has only 32 index, but he/she tries to zero clear
      1024 index.
      
      Bug Location:
      static uint8_t g_buffer[32];
      :
      memset (g_buffer, 0, 1024);
      
      Note:
      Detected by CppCheck
      ```
      
      -------------------------------------------------------
      899d1506
    • Gabriel's avatar
      bug fixes from Fujitsu (bug 21) · 98a7a16e
      Gabriel authored
      Note: this fix does not solve the issue with how
      this buffer is used in this function, but I'm not
      sure this code is used at all (Cédric Roux).
      
      ----------------------------------------------------------
      bug 21
      
      Ttile:
      PAYLOAD_MAX=1500, so this coding results in index overflow.
      Additionally, operator "!=" just compairs something, this
      coding is meaningless.
      
      Bug Location:
      buffer[PAYLOAD_MAX] != '\0';
      
      Note:
      Detected by CppCheck
      ----------------------------------------------------------
      98a7a16e
  11. 03 May, 2017 1 commit
  12. 11 Apr, 2017 1 commit
  13. 10 Apr, 2017 2 commits
    • Cedric Roux's avatar
      bugfix: increase RLC UM header size · 94f880ad
      Cedric Roux authored
      The constant RLC_UM_SEGMENT_NB_MAX_LI_PER_PDU is set to 24. This is
      too low. Running a downlink TCP iperf with a 10MHz or 20MHz cell
      leads to lots of the following warning in the log:
      
      [RLC][W][SN 792] Bad RLC header! Discard this RLC PDU (size=618)
      
      The problem is that the uplink RLC PDU contains a lot of TCP ack.
      We can see much more than 24 of them. The RLC layer is not happy
      and discards the PDU.
      
      Putting 256 for RLC_UM_SEGMENT_NB_MAX_LI_PER_PDU (arbitrarily chosen,
      big but not too big) solves the problem, at least for 10MHz.
      94f880ad
    • Cedric Roux's avatar
      minor: bad comparison · fbcc9a23
      Cedric Roux authored
      it was:
      
          *num_li_pP >= RLC_UM_SEGMENT_NB_MAX_LI_PER_PDU
      
      it should be:
      
          *num_li_pP > RLC_UM_SEGMENT_NB_MAX_LI_PER_PDU
      fbcc9a23
  14. 03 Apr, 2017 2 commits
    • Cedric Roux's avatar
      hotfix: revert value of 'rb_table_index' · e7f1cf42
      Cedric Roux authored
      This reverts commit 7f24927c.
      
      With value 13 uplink TDD for a 10MHz configuration was not working.
      UDP traffic sent with: "iperf -c XX -u -b10M" was crashing
      the eNB.
      e7f1cf42
    • Cedric Roux's avatar
      integration fix: fixes for pthread_getname_np · c36c0453
      Cedric Roux authored
      - define _GNU_SOURCE before including pthread.h
      - do not use static for the array 'threadname' used
        to store the name, it makes it a global variable
        accessed by several threads in parallel
      - increase size of 'threadname' (maybe not necessary)
      - properly indent #define / #under (# should be at column 1)
      c36c0453
  15. 29 Mar, 2017 1 commit
  16. 28 Mar, 2017 8 commits
  17. 24 Mar, 2017 2 commits