1. 06 Feb, 2018 1 commit
    • Cedric Roux's avatar
      bugfix: fix UL over scheduling · eccb96c4
      Cedric Roux authored
      There is too much UL scheduling because the buffer status is
      overestimated.
      
      This commit tries to make things simpler.
      eccb96c4
  2. 21 Jan, 2018 1 commit
  3. 15 Jan, 2018 2 commits
    • Cedric Roux's avatar
      Fix NFAPI integration · 922b5b59
      Cedric Roux authored
      This commit fixes issues introduced by the previous commit.
      
      Summary of work:
      - cleanup:
        - fix LOG_XX to be less verbose
        - fix cmake_targets/CMakeLists.txt
        - fix oaienv
        - remove dead code
      - bug fixes:
        - in openair1/SCHED/fapi_l1.c we had:
            eNB->pdcch_vars[subframe&1].num_dci           = number_dci;
          should be:
            eNB->pdcch_vars[subframe&1].num_dci           = 0;
          This bug let the PHY send more DCIs than what should have been
          sent because num_dci is incremented later on in the code.
          This fix may be a problem for fapi mode, to be checked.
        - add new T VCD traces
        - revert openair1/PHY/TOOLS/file_output.c to 'develop' version
        - remove thread_id in logRecord/logRecord_mt
        - revert (and adapt) configuration files
        - be careful when doing frame++, we need to % 1024
        - revert target_rx_power in openair2/LAYER2/MAC/eNB_scheduler_ulsch.c
      - NFAPI:
        - the open-nFAPI code has been included in the repository. See nfapi/README.
          Maybe we should "git clone" the Cisco repository instead. We have to be
          careful of availability though.
      
      What has been tested:
      - monolithic eNB FDD 5/10MHz with one UE, iperf UDP/TCP uplink/downlink
      
      Anything else may fail to work, especially the FAPI mode, which has not
      been tested at all.
      922b5b59
    • Cedric Roux's avatar
      import NFAPI work from David Price from Cisco (non-working commit, do not use it) · 7757b9e7
      Cedric Roux authored
      It has been chosen to not include the full history of commits
      from David. He included a binary version of wireshark, probably
      a modified one that understands NFAPI. Wireshark is released under
      the GPL license, we cannot include it in the repository. We could
      have done a next commit to remove this binary. But then it would
      still be present in the history of commits, which may not be allowed.
      And it would take space on disk. We could edit the history to remove
      wireshark entirely. But this operation is too complicated.
      
      There was also a pcap capture file, which has nothing to do in
      the history of commits and would take space on disk. There again,
      it's too difficult to edit the history to remove it.
      
      There was a file .gitignore that was also removed.
      
      The original history can be found on David's repository:
      https://gitlab.eurecom.fr/daveprice/openairinterface5g/
      The branch is: nfapi-ru-rau-split.
      
      A copy of that branch has been included in the internal OAI
      repository, for those who have access to it.
      The branch is the same. The last commit ID is
      91064382.
      
      You can compare the current commit with the commit 9106...
      to see what differs.
      
      The current commit has to be considered non-working.
      The commit following the current commit will fix problems with
      the work in the current commit.
      
      If you use git bisect, don't spend time analyzing the current
      commit.
      7757b9e7
  4. 28 Nov, 2017 1 commit
  5. 27 Nov, 2017 1 commit
  6. 04 Nov, 2017 1 commit
  7. 25 Oct, 2017 1 commit
    • Cedric Roux's avatar
      bugfix: fix timing advance · 6da42658
      Cedric Roux authored
      - remove global variables in the function lte_est_timing_advance_pusch
      - do the smoothing logic that was in lte_est_timing_advance_pusch
        in rx_sdu (is it necessary? is it correct?)
      - put back the value 100 in prach_procedures for the test on prach energy
      - change the value of timing_advance_update
      
        it was:
      
           timing_advance_update                  = sync_pos - eNB->frame_parms.nb_prefix_samples/4; //to check
      
        it is now:
      
           timing_advance_update                  = sync_pos; // - eNB->frame_parms.nb_prefix_samples/4; //to check
      
        this should be checked somehow. The computation looked suspicious. Maybe
        the new one is wrong.
      6da42658
  8. 23 Oct, 2017 1 commit
  9. 19 Oct, 2017 1 commit
    • Cedric Roux's avatar
      remove gcc warnings · f1e8bff3
      Cedric Roux authored
      phy_init_lte_ue_signal was renamed init_lte_ue_signal in openair1/PHY/INIT/defs.h
      maybe it's the opposite that should have been done?
      
      Functions used in one file and defined in another may have been
      declared in the wrong header file.
      f1e8bff3
  10. 18 Oct, 2017 1 commit
    • Cedric Roux's avatar
      improve crnti reception (still not correct, we need to reconfigure the UE) · 256c5ab0
      Cedric Roux authored
      TODO: if the UE did random access (followed by a MAC uplink with
      CRNTI) because none of its scheduling request was granted, then
      according to 36.321 5.4.4 the UE's MAC will notify RRC to release
      PUCCH/SRS. According to 36.331 5.3.13 the UE will then apply
      default configuration for CQI reporting and scheduling requests,
      which basically means that the CQI requests won't work anymore and
      that the UE won't do any scheduling request anymore as long as the
      eNB doesn't reconfigure the UE.
      We have to take care of this. As the code is, nothing is done and
      the UE state in the eNB is wrong.
      256c5ab0
  11. 17 Oct, 2017 1 commit
  12. 16 Oct, 2017 1 commit
    • Cedric Roux's avatar
      trying to get better power management · 3d14d571
      Cedric Roux authored
      - change target values
      - change upper/lower limit to trigger a tpc
      - don't use ul_cqi from SR
      
      The value of ul_cqi is not convincing, for both PUSCH and PUCCH,
      more work/analysis is required.
      3d14d571
  13. 15 Oct, 2017 1 commit
  14. 14 Oct, 2017 1 commit
  15. 12 Oct, 2017 2 commits
  16. 11 Oct, 2017 1 commit
  17. 10 Oct, 2017 2 commits
  18. 08 Oct, 2017 1 commit
  19. 07 Oct, 2017 1 commit
  20. 04 Oct, 2017 1 commit
    • Cedric Roux's avatar
      bugfix: fix CQI reporting · c97e0546
      Cedric Roux authored
      - don't use o_flip anymore in ulsch_decoding
      - remove dl_cqi from eNB_UE_STATS
      - put dl_cqi[NFAPI_CC_MAX] in UE_sched_ctrl
      - adapt code for this dl_cqi change (from eNB_UE_STATS to UE_sched_ctrl)
      - extract_pusch_csi has been fixed for CQI_ReportModeAperiodic_rm30,
        the others need to be done. Program will exit if one uses them.
        Not sure if setting sched_ctl->dl_cqi[CC_idP]  has to be done in this
        function...
      c97e0546
  21. 03 Oct, 2017 1 commit
  22. 01 Oct, 2017 2 commits
  23. 27 Sep, 2017 1 commit
    • Cedric Roux's avatar
      update T tracer · e6936f1b
      Cedric Roux authored
      not finished, UE may not work, many things bad/to fix properly
      e6936f1b
  24. 25 Sep, 2017 2 commits
  25. 24 Sep, 2017 3 commits
  26. 21 Sep, 2017 1 commit
  27. 19 Sep, 2017 1 commit
  28. 14 Sep, 2017 1 commit
  29. 30 Aug, 2017 1 commit
  30. 24 Aug, 2017 1 commit
    • Cedric Roux's avatar
      improve multi-UEs scenario · 622b919b
      Cedric Roux authored
      This commits contains several fixes to improve a multi-UE scenario.
      
      This is not the end of the story.
      
      Summary of work:
      ================
      
      1 - improve SR (scheduling requests):
      
          We configured n1pucch == 3 for scheduling requests, for all
          UEs. We now use 71 - UE_id/10.
      
          For it to work, it is vital that pucch_nRB_CQI in the configuration
          file is set to 0, otherwise the SR will go to an RB used for
          PUSCH and uplink decoding will fail whenever an UE does SR.
      
          Note that we will have problems with 20MHz when we use a CCE that
          let the UE send the ACK/NACK using a n1pucch allocated for SR,
          because when the PDCCH is of size 3, we can have 87 CCEs
          and it may lead to an n1pucch colliding with one for SR.
      
          The work done in this patch is a quick solution, seems to work
          with 10MHz.
      
          The real solution is to disable the use of those CCEs that would
          lead an UE to use a n1pucch colliding with an SR n1pucch. Then
          we can use whatever n1pucch we want for SR, as long as the
          scheduler protects them.
      
          Impacted files: configuration files
                          openair2/RRC/LITE/MESSAGES/asn1_msg.c
      
      2 - some fixes for uplink scheduling:
      
          - Do not use PRACH for PUSCH, that leads to too many false
          PRACH detection. Plus the PUSCH receiving may fail if one
          UE uses the PRACH at the same time.
      
          - Take care of retransmissions. That was not done at all, so
          we could allocate one RB to several UEs. The current design
          of the code makes it hard to do it properly, so we chose a
          quick and dirty solution, which is to increase "first_rb"
          to skip any RB used for retransmission. In this process we
          may skip a lot of free RBs. A proper solution is needed here.
      
          - Do not allocate the last RB. This one is used for PUCCH.
          It was sometimes allocated to PUSCH.
      
          - In the pre-processor we didn't pre-allocate RBs to UEs
          with an empty buffer status. We didn't check if the UE
          sent an SR. For example in a three UEs scenario, we
          could have the third UE never scheduled in the uplink.
      
          - rb_table_index was not decreased properly, so we allocated
          too much RBs to some UEs and thus not enough to others.
      
          Impacted files: openair2/LAYER2/MAC/eNB_scheduler_ulsch.c
                          openair2/LAYER2/MAC/pre_processor.c
                          openair1/SCHED/phy_procedures_lte_eNb.c
      
      3 - some fixes for downlink scheduling:
      
          - The check on CCE allocation was not correct. We did something
          like:
      
              if (cce allocation is possible) {
                prepare
              }
      
          We should have done:
      
              save current cce allocation
              if (cce allocation is possible) {
                allocate cce
                prepare
              }
              reset current cce allocation
      
          Basically, when we scheduled several UEs, they were checked
          separately, and the totality of them was not checked.
      
          Impacted file: openair2/LAYER2/MAC/eNB_scheduler_dlsch.c
      
          - The retransmissions are probably not handled correctly.
          Check in openair2/LAYER2/MAC/pre_processor.c, near
          the comment "// control channel or retransmission",
          the case "round > 0" was added. It's probably not enough,
          even maybe not correct.
      
          - Change SF05_LIMIT with SF0_LIMIT. We accept to use
          central blocks in SF 5. The code was also not correct,
          vrb_map was not set properly because the loop on j
          was wrong for the last RBG (which can have one less
          RB than the others).
      
          This is not satisfying. The real solution is to use the
          central RBs and check that the MCS used is compatible
          with the numbers of resource elements allocated (we don't
          want to put too more data bits than what fits).
      
      4 - some fixes in PUCCH decoding:
      
          See: openair1/PHY/LTE_TRANSPORT/pucch.c
      
          Probably not enough. Some more work and analysis is
          required for a proper use of the PUCCH. What we see
          is that the PUCCH constellation gets wrong when there
          are several UEs, meaning the received ACK/NACK is
          not properly decoded (this, or something else...).
      
      5 - several fixes/checks added here and there:
      
          - The final allocate_CCEs in eNB_dlsch_ulsch_scheduler
            is checked and we brutally exit if it fails.
      
          - We exit in get_num_pdcch_symbols in case of failure
            (this should never happen anyway, no big deal normally).
      
          - Some logs added or changed to error/warning instead
            of debug.
      
          - In dlsch_scheduler_pre_processor an abort() was added.
            The code here looks suspicious.
      
          - In assign_max_mcs_min_rb, rb_table_index was not set
            to 2, the value 0 was used. This was not correct.
      
      What remains to be done:
      ========================
      
          - Correct CCE allocation (take into account SR n1pucch,
            check that all the n1pucch that will be used are "compatible").
      
          - Take into account the PHICH when scheduling uplink. As of
            today it is very possible to have two UEs use the same PHICH
            group and PHICH sequence index. We can use n_DMRS in the DCI
            to have uniqueness (see 36.213 table 9.1.2-2). We can drop an
            allocation if there is no free PHICH group/sequence index for
            a given UE.
      
          - When there is an uplink retransmission in the PRACH, we have
            to disable PRACH detection. It is possible that one UE does
            PRACH at the same time, but then what to do? We could use
            DCI0-based retransmission in this specific case maybe...
      
          - Handle free RBs in uplink in a much better way in case of
            a retransmission. We may have a lot of free unused RBs with
            the current code.
      
          - Check downlink retransmissions. Not much has been done there.
      
          - Surely more stuff not clear yet. In some situations we don't
            have a good behavior of the system. Hard to describe more
            precisely at this point.
      622b919b
  31. 17 Aug, 2017 1 commit
  32. 13 Aug, 2017 1 commit
  33. 10 Aug, 2017 1 commit