• Cedric Roux's avatar
    bugfix: fix initialUEMessage criticality · f55cbe47
    Cedric Roux authored
    S1AP specs say:
    
        initialUEMessage S1AP-ELEMENTARY-PROCEDURE ::= {
            INITIATING MESSAGE      InitialUEMessage
            PROCEDURE CODE          id-initialUEMessage
            CRITICALITY             ignore
        }
    
    So let's use "ignore", not "reject".
    
    The online decoder http://asn1-playground.oss.com/ did
    not decode a message encoded by the eNB because of this.
    
    Only the S1AP messages captured while doing a simple connection
    of one UE have been tested with the online decoder.
    
    So, not all the S1AP messages have been checked, maybe some
    instances of this problem are still there.
    
    It does not seem to harm the actual UE<->eNB<->EPC communication
    (because we don't check the integrity of messages or because
    asn1c does not do it), so it's not a big deal.
    f55cbe47
Name
Last commit
Last update
..
MESSAGES/ASN1 Loading commit data...
s1ap_common.c Loading commit data...
s1ap_common.h Loading commit data...
s1ap_eNB.c Loading commit data...
s1ap_eNB.h Loading commit data...
s1ap_eNB_context_management_procedures.c Loading commit data...
s1ap_eNB_context_management_procedures.h Loading commit data...
s1ap_eNB_decoder.c Loading commit data...
s1ap_eNB_decoder.h Loading commit data...
s1ap_eNB_default_values.h Loading commit data...
s1ap_eNB_defs.h Loading commit data...
s1ap_eNB_encoder.c Loading commit data...
s1ap_eNB_encoder.h Loading commit data...
s1ap_eNB_handlers.c Loading commit data...
s1ap_eNB_handlers.h Loading commit data...
s1ap_eNB_itti_messaging.c Loading commit data...
s1ap_eNB_itti_messaging.h Loading commit data...
s1ap_eNB_management_procedures.c Loading commit data...
s1ap_eNB_management_procedures.h Loading commit data...
s1ap_eNB_nas_procedures.c Loading commit data...
s1ap_eNB_nas_procedures.h Loading commit data...
s1ap_eNB_nnsf.c Loading commit data...
s1ap_eNB_nnsf.h Loading commit data...
s1ap_eNB_overload.c Loading commit data...
s1ap_eNB_overload.h Loading commit data...
s1ap_eNB_trace.c Loading commit data...
s1ap_eNB_trace.h Loading commit data...
s1ap_eNB_ue_context.c Loading commit data...
s1ap_eNB_ue_context.h Loading commit data...