During a Merge-Request, after the CI has passed, one or several TC members are tasked to perform a human code review.
This review objective is to check things that were not automatically checked by CI.
Form to use by copying/pasting into a comment on the Merge Request Web page:
**Code Review by : AuthorName*** Impact on functional code - Does code change respect architecture/protocol split? - Are abnormal exits properly handled? - Coding Style Issues (all SHALL be unselected): * Added DEAD Code * Improper logging * Added useless debug code * Duplication of an existing function * Any other coding style issue - Has a new tool been introduced? * if yes, can an existing tool be improved? - if no, do we accept this new tool? * Testing --> Merge Request requires additional testing - Additional testing already present in the Merge Request * if no, has contributor provided framework to do so* Documentation --> Merge Request requires additional documentation - Feature Set documentation updated? - Wiki tutorial / in-repo usage documentation? - Added/Modified/Removed script/build/runtime option(s) * Help modified?Additional Comments:- - -
Example after pasting into a comment:
Code Review by : Raphael Defosseux
Impact on functional code
Does code change respect architecture/protocol split?