Remove outdated tests, do static checks

.prospector.yaml

+inherits:
+  - strictness_veryhigh
+
+ignore:
+  - (^|/)\..+
+  - ^docs/
+  - ^build/
+
+uses:
+  - flask
+
+member-warning: true
+
+output-format: grouped
+
+dodgy:
+    # Looks at Python code to search for things which look "dodgy"
+    # such as passwords or git conflict artifacts
+    run: true
+
+mccabe:
+    # complexity checking.
+    run: true
+
+pep257:
+    # docstring checking
+    run: true
+
+pep8:
+    # style checking
+    run: false
+
+pyflakes:
+    # preferring 'frosted' instead (a fork of)
+    run: true
+
+pylint:
+    # static analysis and then some, see .pylintrc file for configuration
+    run: true
+
+pyroma:
+    # checks setup.py
+    run: false
+
+vulture:
+    # this tool does a good job of finding unused code.
+    run: true

.pylintrc

+[MASTER]
+# Python code to execute, usually for sys.path manipulation such as
+# pygtk.require().
+#init-hook=
+
+# Add files or directories to the blacklist. They should be base names, not
+# paths.
+ignore=CVS
+
+# Pickle collected data for later comparisons.
+persistent=yes
+
+# List of plugins (as comma separated values of python modules names) to load,
+# usually to register additional checkers.
+load-plugins=
+
+# Use multiple processes to speed up Pylint.
+jobs=2
+
+# Allow optimization of some AST trees. This will activate a peephole AST
+# optimizer, which will apply various small optimizations. For instance, it can
+# be used to obtain the result of joining multiple strings with the addition
+# operator. Joining a lot of strings can lead to a maximum recursion error in
+# Pylint and this flag can prevent that. It has one side effect, the resulting
+# AST will be different than the one from reality.
+optimize-ast=no
+
+
+[MESSAGES CONTROL]
+
+# Only show warnings with the listed confidence levels. Leave empty to show
+# all. Valid levels: HIGH, INFERENCE, INFERENCE_FAILURE, UNDEFINED
+confidence=
+
+# Enable the message, report, category or checker with the given id(s). You can
+# either give multiple identifier separated by comma (,) or put this option
+# multiple time (only on the command line, not in the configuration file where
+# it should appear only once). See also the "--disable" option for examples.
+#enable=
+
+# Disable the message, report, category or checker with the given id(s). You
+# can either give multiple identifiers separated by comma (,) or put this
+# option multiple times (only on the command line, not in the configuration
+# file where it should appear only once).You can also use "--disable=all" to
+# disable everything first and then reenable specific checks. For example, if
+# you want to run only the similarities checker, you can use "--disable=all
+# --enable=similarities". If you want to run only the classes checker, but have
+# no Warning level messages displayed, use"--disable=all --enable=classes
+# --disable=W"
+disable=line-too-long
+
+
+[REPORTS]
+
+# Set the output format. Available formats are text, parseable, colorized, msvs
+# (visual studio) and html. You can also give a reporter class, eg
+# mypackage.mymodule.MyReporterClass.
+output-format=text
+
+# Tells whether to display a full report or only the messages
+reports=no
+
+
+[VARIABLES]
+
+# Tells whether we should check for unused import in __init__ files.
+init-import=no
+
+# A regular expression matching the name of dummy variables (i.e. expectedly
+# not used).
+dummy-variables-rgx=_$|dummy
+
+# List of strings which can identify a callback function by name. A callback
+# name must start or end with one of those strings.
+callbacks=_cb
+
+
+[FORMAT]
+
+# Maximum number of characters on a single line.
+max-line-length=100
+
+# Regexp for a line that is allowed to be longer than the limit.
+ignore-long-lines=^\s*(# )?<?https?://\S+>?$
+
+# Allow the body of an if to be on the same line as the test if there is no
+# else.
+single-line-if-stmt=no
+
+# List of optional constructs for which whitespace checking is disabled. `dict-
+# separator` is used to allow tabulation in dicts, etc.: {1  : 1,\n222: 2}.
+# `trailing-comma` allows a space between comma and closing bracket: (a, ).
+# `empty-line` allows space-only lines.
+no-space-check=trailing-comma,dict-separator
+
+# Maximum number of lines in a module
+max-module-lines=1000
+
+# String used as indentation unit. This is usually "    " (4 spaces) or "\t" (1
+# tab).
+indent-string='    '
+
+# Number of spaces of indent required inside a hanging  or continued line.
+indent-after-paren=4
+
+# Expected format of line ending, e.g. empty (any line ending), LF or CRLF.
+expected-line-ending-format=LF
+
+
+[TYPECHECK]
+
+# Tells whether missing members accessed in mixin class should be ignored. A
+# mixin class is detected if its name ends with "mixin" (case insensitive).
+ignore-mixin-members=yes
+
+# List of module names for which member attributes should not be checked
+# (useful for modules/projects where namespaces are manipulated during runtime
+# and thus existing member attributes cannot be deduced by static analysis. It
+# supports qualified module names, as well as Unix pattern matching.
+ignored-modules=
+
+# List of classes names for which member attributes should not be checked
+# (useful for classes with attributes dynamically set). This supports can work
+# with qualified names.
+ignored-classes=
+
+# List of members which are set dynamically and missed by pylint inference
+# system, and so shouldn't trigger E1101 when accessed. Python regular
+# expressions are accepted.
+generated-members=
+
+
+[LOGGING]
+
+# Logging modules to check that the string format arguments are in logging
+# function parameter format
+logging-modules=logging
+
+
+[SIMILARITIES]
+
+# Minimum lines number of a similarity.
+min-similarity-lines=4
+
+# Ignore comments when computing similarities.
+ignore-comments=yes
+
+# Ignore docstrings when computing similarities.
+ignore-docstrings=yes
+
+# Ignore imports when computing similarities.
+ignore-imports=no
+
+
+[BASIC]
+
+# List of builtins function names that should not be used, separated by a comma
+bad-functions=
+
+# Good variable names which should always be accepted, separated by a comma
+good-names=i,j,k,e
+
+# Bad variable names which should always be refused, separated by a comma
+bad-names=foo,bar,baz,toto,tutu,tata
+
+# Colon-delimited sets of names that determine each other's naming style when
+# the name regexes allow several styles.
+name-group=
+
+# Include a hint for the correct naming format with invalid-name
+include-naming-hint=no
+
+# Regular expression matching correct function names
+function-rgx=[a-z_][a-z0-9_]{2,30}$
+
+# Naming hint for function names
+function-name-hint=[a-z_][a-z0-9_]{2,30}$
+
+# Regular expression matching correct method names
+method-rgx=[a-z_][a-z0-9_]{2,30}$
+
+# Naming hint for method names
+method-name-hint=[a-z_][a-z0-9_]{2,30}$
+
+# Regular expression matching correct module names
+module-rgx=(([a-z_][a-z0-9_]*)|([A-Z][a-zA-Z0-9]+))$
+
+# Naming hint for module names
+module-name-hint=(([a-z_][a-z0-9_]*)|([A-Z][a-zA-Z0-9]+))$
+
+# Regular expression matching correct argument names
+argument-rgx=[a-z_][a-z0-9_]{2,30}$
+
+# Naming hint for argument names
+argument-name-hint=[a-z_][a-z0-9_]{2,30}$
+
+# Regular expression matching correct variable names
+variable-rgx=[a-z_][a-z0-9_]{2,30}$
+
+# Naming hint for variable names
+variable-name-hint=[a-z_][a-z0-9_]{2,30}$
+
+# Regular expression matching correct inline iteration names
+inlinevar-rgx=[A-Za-z_][A-Za-z0-9_]*$
+
+# Naming hint for inline iteration names
+inlinevar-name-hint=[A-Za-z_][A-Za-z0-9_]*$
+
+# Regular expression matching correct class names
+class-rgx=[A-Z_][a-zA-Z0-9]+$
+
+# Naming hint for class names
+class-name-hint=[A-Z_][a-zA-Z0-9]+$
+
+# Regular expression matching correct class attribute names
+class-attribute-rgx=([A-Za-z_][A-Za-z0-9_]{2,30}|(__.*__))$
+
+# Naming hint for class attribute names
+class-attribute-name-hint=([A-Za-z_][A-Za-z0-9_]{2,30}|(__.*__))$
+
+# Regular expression matching correct constant names
+const-rgx=(([A-Z_][A-Z0-9_]*)|(__.*__)|log)$
+
+# Naming hint for constant names
+const-name-hint=(([A-Z_][A-Z0-9_]*)|(__.*__)|log)$
+
+# Regular expression matching correct attribute names
+attr-rgx=[a-z_][a-z0-9_]{2,30}$
+
+# Naming hint for attribute names
+attr-name-hint=[a-z_][a-z0-9_]{2,30}$
+
+# Regular expression which should only match function or class names that do
+# not require a docstring.
+no-docstring-rgx=^_
+
+# Minimum line length for functions/classes that require docstrings, shorter
+# ones are exempt.
+docstring-min-length=-1
+
+
+[ELIF]
+
+# Maximum number of nested blocks for function / method body
+max-nested-blocks=5
+
+
+[MISCELLANEOUS]
+
+# List of note tags to take in consideration, separated by a comma.
+notes=FIXME,TODO
+
+
+[DESIGN]
+
+# Maximum number of arguments for function / method
+max-args=5
+
+# Argument names that match this expression will be ignored. Default to name
+# with leading underscore
+ignored-argument-names=_.*
+
+# Maximum number of locals for function / method body
+max-locals=15
+
+# Maximum number of return / yield for function / method body
+max-returns=6
+
+# Maximum number of branch for function / method body
+max-branches=12
+
+# Maximum number of statements in function / method body
+max-statements=50
+
+# Maximum number of parents for a class (see R0901).
+max-parents=7
+
+# Maximum number of attributes for a class (see R0902).
+max-attributes=7
+
+# Minimum number of public methods for a class (see R0903).
+min-public-methods=2
+
+# Maximum number of public methods for a class (see R0904).
+max-public-methods=20
+
+# Maximum number of boolean expressions in a if statement
+max-bool-expr=5
+
+
+[IMPORTS]
+
+# Deprecated modules which should not be used, separated by a comma
+deprecated-modules=optparse
+
+# Create a graph of every (i.e. internal and external) dependencies in the
+# given file (report RP0402 must not be disabled)
+import-graph=
+
+# Create a graph of external dependencies in the given file (report RP0402 must
+# not be disabled)
+ext-import-graph=
+
+# Create a graph of internal dependencies in the given file (report RP0402 must
+# not be disabled)
+int-import-graph=
+
+
+[CLASSES]
+
+# List of method names used to declare (i.e. assign) instance attributes.
+defining-attr-methods=__init__
+
+# List of valid names for the first argument in a class method.
+valid-classmethod-first-arg=cls
+
+# List of valid names for the first argument in a metaclass class method.
+valid-metaclass-classmethod-first-arg=mcs
+
+# List of member names, which should be excluded from the protected access
+# warning.
+exclude-protected=
+
+
+[EXCEPTIONS]
+
+# Exceptions that will emit a warning when being caught. Defaults to
+# "Exception"
+overgeneral-exceptions=BaseException

.travis.yml

@@ -4,6 +4,8 @@ python:
   - "3.5"
 install:
   - pip install -r requirements.txt
+  - pip install pylint
 before_script:
 script:
-  - PYTHONPATH=. py.test --cov=zoe_cmd --cov=zoe_lib --cov=zoe_master --cov=zoe_observer --cov=zoe_web
+  - prospector
+  - doc8 docs/

README.rst

@@ -31,18 +31,14 @@ Repository contents
 - `scripts`: Scripts used to test Zoe images outside of Zoe
 - `zoe_cmd`: Command-line client
 - `zoe_lib`: Client-side library, contains also some modules needed by the observer and the master processes
-- `zoe_observer`: The Observer process that monitors Swarm and informs the master of various events
 - `zoe_master`: The core of Zoe, the server process that listens for client requests and creates the containers on Swarm
-- `zoe_web`: The web client interface
+- `zoe_api`: The web client interface
 
-|Travis build| |Documentation Status| |Requirements Status|
+|Travis build| |Documentation Status|
 
 Zoe is licensed under the terms of the Apache 2.0 license.
 
 .. |Documentation Status| image:: https://readthedocs.org/projects/zoe-analytics/badge/?version=latest
    :target: https://readthedocs.org/projects/zoe-analytics/?badge=latest
-.. |Requirements Status| image:: https://requires.io/github/DistributedSystemsGroup/zoe/requirements.svg?branch=master
-   :target: https://requires.io/github/DistributedSystemsGroup/zoe/requirements/?branch=master
-   :alt: Requirements Status
 .. |Travis build| image:: https://travis-ci.org/DistributedSystemsGroup/zoe.svg
    :target: https://travis-ci.org/DistributedSystemsGroup/zoe

doc8.ini

+[doc8]
+ignore-path=docs/_build
+ignore=D001

requirements.txt

 Flask>=0.10.1
 Flask-RESTful
-Flask-WTF
-python-dateutil>=2.4.2
-pytest
-pytest-cov
 requests>=2.9.1
 docker-py==1.7.2
 tornado>=4.3
 kazoo
-passlib
 humanfriendly
 kafka-python

requirements_tests.txt

+prospector[with_vulture]
+doc8
+sphinx

zoe_lib/tests/application_api_test.py

-# Copyright (c) 2015, Daniele Venzano
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#    http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
-# implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-from zoe_lib.applications import app_validate
-
-
-def test_from_dict(application_dict):
-    assert isinstance(application_dict, dict)
-    app_validate(application_dict)

zoe_lib/tests/conftest.py

-# Copyright (c) 2015, Daniele Venzano
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#    http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
-# implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-import json
-
-import pytest
-
-
-@pytest.fixture(scope='session')
-def application_dict():
-    jsondata = open("zoe_lib/tests/resources/spark-wordcount-test.json", "r")
-    return json.load(jsondata)

zoe_lib/tests/resources/spark-wordcount-test.json

-{
-    "name": "spark-jupyter",
-    "priority": 512,
-    "requires_binary": false,
-    "services": [
-        {
-            "docker_image": "192.168.45.252:5000/zoerepo/spark-master",
-            "environment": [
-                [
-                    "SPARK_MASTER_IP",
-                    "{name_prefix}-spark-master-{execution_id}.{name_prefix}-usernet-{user_id}"
-                ]
-            ],
-            "monitor": false,
-            "name": "spark-master",
-            "ports": [
-                {
-                    "is_main_endpoint": false,
-                    "name": "Spark master web interface",
-                    "path": "/",
-                    "port_number": 8080,
-                    "protocol": "http"
-                }
-            ],
-            "required_resources": {
-                "memory": 4294967296
-            },
-            "total_count": 1,
-            "essential_count": 1,
-            "startup_order": 0
-        },
-        {
-            "docker_image": "192.168.45.252:5000/zoerepo/spark-jupyter-notebook",
-            "environment": [
-                [
-                    "SPARK_MASTER",
-                    "spark://{name_prefix}-spark-master-{execution_id}.{name_prefix}-usernet-{user_id}:7077"
-                ],
-                [
-                    "SPARK_EXECUTOR_RAM",
-                    "6442450944"
-                ],
-                [
-                    "NB_USER",
-                    "{user_name}"
-                ],
-                [
-                    "NAMENODE_HOST",
-                    "hdfs-namenode.hdfs"
-                ]
-            ],
-            "monitor": true,
-            "name": "spark-jupyter",
-            "ports": [
-                {
-                    "is_main_endpoint": false,
-                    "name": "Spark application web interface",
-                    "path": "/",
-                    "port_number": 4040,
-                    "protocol": "http"
-                },
-                {
-                    "is_main_endpoint": true,
-                    "name": "Jupyter Notebook interface",
-                    "path": "/",
-                    "port_number": 8888,
-                    "protocol": "http"
-                }
-            ],
-            "required_resources": {
-                "memory": 4294967296
-            },
-            "total_count": 1,
-            "essential_count": 1,
-            "startup_order": 2
-        },
-        {
-            "docker_image": "192.168.45.252:5000/zoerepo/spark-worker",
-            "environment": [
-                [
-                    "SPARK_WORKER_CORES",
-                    "4"
-                ],
-                [
-                    "SPARK_WORKER_RAM",
-                    "7516192768"
-                ],
-                [
-                    "SPARK_MASTER_IP",
-                    "{name_prefix}-spark-master-{execution_id}.{name_prefix}-usernet-{user_id}"
-                ],
-                [
-                    "SPARK_LOCAL_IP",
-                    "{name_prefix}-spark-worker-0-{execution_id}.{name_prefix}-usernet-{user_id}"
-                ]
-            ],
-            "monitor": false,
-            "name": "spark-worker-0",
-            "ports": [
-                {
-                    "is_main_endpoint": false,
-                    "name": "Spark worker web interface",
-                    "path": "/",
-                    "port_number": 8081,
-                    "protocol": "http"
-                }
-            ],
-            "required_resources": {
-                "memory": 8589934592
-            },
-            "total_count": 3,
-            "essential_count": 1,
-            "startup_order": 1
-        }
-    ],
-    "version": 2,
-    "will_end": false
-}

zoe_master/tests/__init__.py

-

zoe_master/tests/conftest.py

-# Copyright (c) 2015, Daniele Venzano
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#    http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
-# implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-import pytest
-from zoe_master.state.blobs.fs import FSBlobs
-from zoe_master.state.manager import StateManager
-
-from zoe_lib.config import load_configuration, get_conf
-
-
-class TestConf:
-    def __init__(self):
-        self.debug = True
-        self.zk = 'zk:2181'
-        self.state_dir = '/tmp/zoe'
-        self.zoeadmin_password = 'test'
-        self.passlib_rounds = 1
-        self.enable_influxdb = False
-
-
-@pytest.fixture(scope='session')
-def configuration(request):
-    load_configuration(test_conf=TestConf())
-    return get_conf()
-
-
-@pytest.fixture(scope='function')
-def state_manager(configuration):
-    return StateManager(FSBlobs)

zoe_master/tests/state_applications_test.py

-# Copyright (c) 2016, Daniele Venzano
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#    http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
-# implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-from zoe_master.state.application import ApplicationDescription, ServiceDescription, ServiceEndpointDescription
-
-
-def test_application():
-    ApplicationDescription()
-
-
-def test_process():
-    ServiceDescription()
-
-
-def test_process_endpoint():
-    ServiceEndpointDescription()

zoe_master/tests/state_executions_test.py

-# Copyright (c) 2016, Daniele Venzano
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#    http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
-# implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-from zoe_master.state.execution import Execution
-
-
-def test_execution(state_manager):
-    Execution(state_manager)

zoe_master/tests/state_manager_test.py

-# Copyright (c) 2016, Daniele Venzano
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#    http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
-# implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-from zoe_master.state.user import User
-
-
-def test_manager(state_manager):
-    user = User(state_manager)
-    user_id = state_manager.gen_id()
-    user.id = user_id
-    state_manager.new('user', user)
-    assert state_manager.users[user_id] == user
-    guser = state_manager.get_one('user', id=user_id)
-    assert guser == user
-    state_manager.delete('user', user_id)

zoe_master/tests/state_service_test.py

-# Copyright (c) 2016, Daniele Venzano
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#    http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
-# implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-from zoe_master.state.service import Service
-
-
-def test_execution(state_manager):
-    Service(state_manager)

zoe_master/tests/state_users_test.py

-# Copyright (c) 2016, Daniele Venzano
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.