1. 02 Mar, 2018 1 commit
    • Cedric Roux's avatar
      hotfix: fix bad RLC UM packet creation · 26d68e9c
      Cedric Roux authored
      Running TCP DL traffic with one connected UE showed a lot of
      fluctuations in throughput. After analysis it was found that
      sometimes the RLC UM PDU was not correct. It contained one byte
      more than it should. On the receiver side, the TCP packet
      contained in the RLC packet seems to be rejected by the TCP
      stack of the UE (it has one byte more than it should),
      leading to a brutal reduction of the throughput, probably due
      to some congestion detection in the TCP implementation.
      Or something.
      
      This hotfix seems to solve the problem. Using iperf in downlink
      with a 5MHz eNB, we see no more fluctuations, the traffic is
      very steady at 16.8Mb/s, as reported by the iperf server running
      on the phone. (17.5 in the PHY plot of the T tracer.)
      
      A rewrite of both the MAC and RLC UM packet generation is needed.
      The code is way too complex for what it does and may contain
      several similar problems that only trigger in specific rare
      conditions.
      26d68e9c
  2. 15 Jan, 2018 1 commit
  3. 11 Jan, 2018 1 commit
  4. 28 Nov, 2017 1 commit
  5. 23 Oct, 2017 1 commit
  6. 19 Oct, 2017 1 commit
    • Cedric Roux's avatar
      remove gcc warnings · f1e8bff3
      Cedric Roux authored
      phy_init_lte_ue_signal was renamed init_lte_ue_signal in openair1/PHY/INIT/defs.h
      maybe it's the opposite that should have been done?
      
      Functions used in one file and defined in another may have been
      declared in the wrong header file.
      f1e8bff3
  7. 06 Jul, 2017 1 commit
  8. 29 Jun, 2017 1 commit
  9. 12 May, 2017 1 commit
    • Gabriel's avatar
      bug fixes from Fujitsu (bug 26) · 899d1506
      Gabriel authored and Cedric Roux's avatar Cedric Roux committed
      ----------------------------------------------------------
      bug 26
      
      Ttile:
      g_buffer has only 32 index, but he/she tries to zero clear
      1024 index.
      
      Bug Location:
      static uint8_t g_buffer[32];
      :
      memset (g_buffer, 0, 1024);
      
      Note:
      Detected by CppCheck
      ----------------------------------------------------------
      899d1506
  10. 03 May, 2017 1 commit
  11. 17 Apr, 2017 1 commit
  12. 11 Apr, 2017 1 commit
  13. 10 Apr, 2017 2 commits
    • Cedric Roux's avatar
      bugfix: increase RLC UM header size · 94f880ad
      Cedric Roux authored
      The constant RLC_UM_SEGMENT_NB_MAX_LI_PER_PDU is set to 24. This is
      too low. Running a downlink TCP iperf with a 10MHz or 20MHz cell
      leads to lots of the following warning in the log:
      
      [RLC][W][SN 792] Bad RLC header! Discard this RLC PDU (size=618)
      
      The problem is that the uplink RLC PDU contains a lot of TCP ack.
      We can see much more than 24 of them. The RLC layer is not happy
      and discards the PDU.
      
      Putting 256 for RLC_UM_SEGMENT_NB_MAX_LI_PER_PDU (arbitrarily chosen,
      big but not too big) solves the problem, at least for 10MHz.
      94f880ad
    • Cedric Roux's avatar
      minor: bad comparison · fbcc9a23
      Cedric Roux authored
      it was:
      
          *num_li_pP >= RLC_UM_SEGMENT_NB_MAX_LI_PER_PDU
      
      it should be:
      
          *num_li_pP > RLC_UM_SEGMENT_NB_MAX_LI_PER_PDU
      fbcc9a23
  14. 29 Mar, 2017 1 commit
  15. 28 Mar, 2017 3 commits
  16. 23 Mar, 2017 1 commit
    • Cedric Roux's avatar
      RRC Rel14 · 4fcb6272
      Cedric Roux authored
      - import RRC ASN.1 defintions from the specifications
        (file openair2/RRC/LITE/MESSAGES/asn1c/ASN1_files/RRC-e10.asn)
        contrary to rel8/10, all modules have been imported, maybe it's too much
        to refine in case of problems
      - deal with rel14 in fix_asn1
      - all code that was for Rel10 is now for Rel10/Rel14
      - some incompatible changes (mostly in naming) were resolved in favor
        of rel14, see in openair2/RRC/LITE/defs.h
      - unsure about the rlc layer, some arrays have changed (values appended),
        I only changed the definition and in tests in the code, I changed
        the index limit, maybe it's not enough
      
      Rel14 is the default compilation mode.
      4fcb6272
  17. 16 Mar, 2017 1 commit
  18. 15 Mar, 2017 4 commits
  19. 14 Mar, 2017 1 commit
  20. 13 Mar, 2017 4 commits
  21. 09 Mar, 2017 2 commits
  22. 08 Mar, 2017 1 commit
  23. 07 Mar, 2017 4 commits
  24. 04 Mar, 2017 2 commits
  25. 02 Mar, 2017 2 commits