From fb9f84c3b60cecdbce0c2fda8ee6e19cfc60ac36 Mon Sep 17 00:00:00 2001
From: Lionel Gauthier <lionel.gauthier@eurecom.fr>
Date: Thu, 9 Apr 2015 09:16:59 +0000
Subject: [PATCH] patches13/0013-not-sure-how-to-fix-this-correctly.patch
git-svn-id: http://svn.eurecom.fr/openair4G/trunk@7059 818b1a75-f10b-46b9-bf7c-635c3b92a50f
---
openair-cn/NAS/EURECOM-NAS/src/emm/IdleMode.c | 2 +-
openair2/LAYER2/PDCP_v10.1.0/pdcp_primitives.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/openair-cn/NAS/EURECOM-NAS/src/emm/IdleMode.c b/openair-cn/NAS/EURECOM-NAS/src/emm/IdleMode.c
index 2251c4a8202..64b21821555 100644
--- a/openair-cn/NAS/EURECOM-NAS/src/emm/IdleMode.c
+++ b/openair-cn/NAS/EURECOM-NAS/src/emm/IdleMode.c
@@ -889,7 +889,7 @@ int emm_proc_plmn_selection_end(int found, tac_t tac, ci_t ci, AcT_t rat)
* Or terminate the PLMN selection procedure
*/
if (!select_next_plmn) {
- if (!(_emm_plmn_list.fplmn) < 0) {
+ if (!(_emm_plmn_list.fplmn) < 0) { // FIXME this comparison makes no sense (bool < 0)
/* There were one or more PLMNs which were available and allowable,
* but an LR failure made registration on those PLMNs unsuccessful
* or an entry in any of the forbidden area lists prevented a
diff --git a/openair2/LAYER2/PDCP_v10.1.0/pdcp_primitives.c b/openair2/LAYER2/PDCP_v10.1.0/pdcp_primitives.c
index 7f2fa739d6b..214c1d966ee 100755
--- a/openair2/LAYER2/PDCP_v10.1.0/pdcp_primitives.c
+++ b/openair2/LAYER2/PDCP_v10.1.0/pdcp_primitives.c
@@ -57,7 +57,7 @@ uint8_t pdcp_get_dc_filed(unsigned char* pdu_buffer)
return 0;
dc = (uint8_t)pdu_buffer[0] & 0xF0; // Reset D/C field
- dc >>= 8;
+ dc >>= 8; // FIXME this is broken!!! returns 0 all the time
return dc;
}
--
GitLab