1. 19 May, 2017 10 commits
  2. 18 May, 2017 7 commits
    • Cédric Roux's avatar
      warning removal · c08bd6ba
      Cédric Roux authored
      force j to -1, there is a compilation warning with the T tracer
      (variable may be used uninitialized)
      c08bd6ba
    • Cédric Roux's avatar
      minor: warnings removal · dcfdd761
      Cédric Roux authored
      It seems that ciphering_algorithm is "unsigned int" in RRC Rel10
      and "unsigned long" in RRC Rel14 (as processed by asn1c)
      
      Let's force it to unsigned long in the log to avoid compilation-time
      warnings.
      dcfdd761
    • Cédric Roux's avatar
      warnings removal in LOG_X · 9d65f4dd
      Cédric Roux authored
      those popped up thanks to previous commit
      9d65f4dd
    • Cédric Roux's avatar
      redo commit cb67d586 · 94dd8843
      Cédric Roux authored
      Seems like this commit got lost at some point.
      
      Here was the message:
      -----------------------------------------------------------------------------
      Author: Cedric Roux <cedric.roux@eurecom.fr>
      Date:   Tue Jan 10 14:21:02 2017 +0100
      
          add format indicator to get LOG_X warnings
      
          The LOG_X macros emit a lot of warnings when compiling with the T
          because they call the function logRecord (or logRecord_mt)
          which has not been "marked" as calling printf, so gcc won't
          emit typical printf warnings.
      
          With the T, they directly translate to sprintf, so those warnings
          pop up, much more verbose due to several macro expansions.
      
          Let's make them pop up all the time so it's easier to fix them.
      -----------------------------------------------------------------------------
      94dd8843
    • Cédric Roux's avatar
      add CQI to periodic logging of UE · f6693af6
      Cédric Roux authored
      f6693af6
    • Cédric Roux's avatar
      minor: change files mode (from 755 to 644) · 4eefaffb
      Cédric Roux authored
      4eefaffb
    • Cédric Roux's avatar
      improve logging in oaisim · 5e323eef
      Cédric Roux authored
      - print current working directory
      - print git version (if available)
      - print security keys
        this last one is a security breach, but as of today
        it's not a problem
      5e323eef
  3. 17 May, 2017 1 commit
  4. 15 May, 2017 9 commits
  5. 13 May, 2017 1 commit
    • Cédric Roux's avatar
      rewrite phy_stats_exist · 9eaee53b
      Cédric Roux authored
      We have to test that all active CCs of a given UE exist in the PHY layer.
      Maybe not the end of the story...
      9eaee53b
  6. 12 May, 2017 12 commits
    • Cédric Roux's avatar
    • Cédric Roux's avatar
    • Cédric Roux's avatar
    • Cédric Roux's avatar
    • Cédric Roux's avatar
    • Tien-Thinh Nguyen's avatar
      fix the errors related to multiple carriers (for a given UE considering only... · 3d4ba1a3
      Tien-Thinh Nguyen authored
      fix the errors related to multiple carriers (for a given UE considering only the CCs which this UE belongs to)
      3d4ba1a3
    • Gabriel's avatar
      bug fixes from Fujitsu (bug 37) · ad6d0ac5
      Gabriel authored and Cédric Roux's avatar Cédric Roux committed
      ----------------------------------------------------------
      bug 37
      
      Ttile:
      Sending side is as follows.
      rar[3] = (((mcs&0x7)<<5)) | ((TPC&7)<<2) | ((ULdelay&1)<<1) | (cqireq&1);
      So, 2 bit shift looks correct.
      
      Bug Location:
      ulsch->harq_processes[harq_pid]->TPC = (rar[3]>>3)&7;//rar->TPC;
      ----------------------------------------------------------
      ad6d0ac5
    • Gabriel's avatar
      bug fixes from Fujitsu (bug 29) · 893f36e8
      Gabriel authored and Cédric Roux's avatar Cédric Roux committed
      ----------------------------------------------------------
      bug 29
      
      Ttile:
      FDD should be TDD.
      
      Bug Location:
        switch (oai_emulation.info.frame_type[0]) {
        case FDD:
          frame_type = "FDD";
          break;
      
        case TDD:
          frame_type = "FDD";
          break;
        }
      ----------------------------------------------------------
      893f36e8
    • Gabriel's avatar
      bug fixes from Fujitsu (bug 26) · 899d1506
      Gabriel authored and Cédric Roux's avatar Cédric Roux committed
      ----------------------------------------------------------
      bug 26
      
      Ttile:
      g_buffer has only 32 index, but he/she tries to zero clear
      1024 index.
      
      Bug Location:
      static uint8_t g_buffer[32];
      :
      memset (g_buffer, 0, 1024);
      
      Note:
      Detected by CppCheck
      ----------------------------------------------------------
      899d1506
    • Cédric Roux's avatar
      bug fixes from Fujitsu (bug 24) · adb3b25c
      Cédric Roux authored
      ----------------------------------------------------------
      bug 24
      
      Ttile:
      The last line "multicast_group = multicast_group" is hard
      to understand. The local variable should be different name
      than the global variable.
      
      Bug Location:
      const char *multicast_group_list[MULTICAST_LINK_NUM_GROUPS] = {
        "239.0.0.161",
        "239.0.0.162",
        "239.0.0.163",
        "239.0.0.164"
      };
      :
      :
      void multicast_link_start(void (*rx_handlerP) (unsigned int, char *),
                                unsigned char multicast_group, char *multicast_ifname)
      {
        rx_handler = rx_handlerP;
        multicast_group = multicast_group;
      
      Note:
      Detected by CppCheck
      ----------------------------------------------------------
      adb3b25c
    • Gabriel's avatar
      bug fixes from Fujitsu (bug 22) · 34c6805f
      Gabriel authored and Cédric Roux's avatar Cédric Roux committed
      Note: not sure that the code is correct,
      to be checked (Cédric Roux).
      
      ----------------------------------------------------------
      bug 22
      
      Ttile:
      (subframe!=2)||(subframe!=7) is always TRUE. This coding
      is really intended? Operator || should be && instead?
      
      Bug Location:
      ((frame_parms->frame_type==TDD)&&(frame_parms->tdd_config==1)&&((subframe!=2)||(subframe!=7)))) {
      
      Note:
      Detected by CppCheck
      ----------------------------------------------------------
      34c6805f
    • Gabriel's avatar
      bug fixes from Fujitsu (bug 21) · 98a7a16e
      Gabriel authored and Cédric Roux's avatar Cédric Roux committed
      Note: this fix does not solve the issue with how
      this buffer is used in this function, but I'm not
      sure this code is used at all (Cédric Roux).
      
      ----------------------------------------------------------
      bug 21
      
      Ttile:
      PAYLOAD_MAX=1500, so this coding results in index overflow.
      Additionally, operator "!=" just compairs something, this
      coding is meaningless.
      
      Bug Location:
      buffer[PAYLOAD_MAX] != '\0';
      
      Note:
      Detected by CppCheck
      ----------------------------------------------------------
      98a7a16e