Skip to content
Snippets Groups Projects
Forked from oai / openairinterface5G
18883 commits behind the upstream repository.
  • Cédric Roux's avatar
    7757b9e7
    import NFAPI work from David Price from Cisco (non-working commit, do not use it) · 7757b9e7
    Cédric Roux authored
    It has been chosen to not include the full history of commits
    from David. He included a binary version of wireshark, probably
    a modified one that understands NFAPI. Wireshark is released under
    the GPL license, we cannot include it in the repository. We could
    have done a next commit to remove this binary. But then it would
    still be present in the history of commits, which may not be allowed.
    And it would take space on disk. We could edit the history to remove
    wireshark entirely. But this operation is too complicated.
    
    There was also a pcap capture file, which has nothing to do in
    the history of commits and would take space on disk. There again,
    it's too difficult to edit the history to remove it.
    
    There was a file .gitignore that was also removed.
    
    The original history can be found on David's repository:
    https://gitlab.eurecom.fr/daveprice/openairinterface5g/
    The branch is: nfapi-ru-rau-split.
    
    A copy of that branch has been included in the internal OAI
    repository, for those who have access to it.
    The branch is the same. The last commit ID is
    91064382.
    
    You can compare the current commit with the commit 9106...
    to see what differs.
    
    The current commit has to be considered non-working.
    The commit following the current commit will fix problems with
    the work in the current commit.
    
    If you use git bisect, don't spend time analyzing the current
    commit.
    7757b9e7
    History
    import NFAPI work from David Price from Cisco (non-working commit, do not use it)
    Cédric Roux authored
    It has been chosen to not include the full history of commits
    from David. He included a binary version of wireshark, probably
    a modified one that understands NFAPI. Wireshark is released under
    the GPL license, we cannot include it in the repository. We could
    have done a next commit to remove this binary. But then it would
    still be present in the history of commits, which may not be allowed.
    And it would take space on disk. We could edit the history to remove
    wireshark entirely. But this operation is too complicated.
    
    There was also a pcap capture file, which has nothing to do in
    the history of commits and would take space on disk. There again,
    it's too difficult to edit the history to remove it.
    
    There was a file .gitignore that was also removed.
    
    The original history can be found on David's repository:
    https://gitlab.eurecom.fr/daveprice/openairinterface5g/
    The branch is: nfapi-ru-rau-split.
    
    A copy of that branch has been included in the internal OAI
    repository, for those who have access to it.
    The branch is the same. The last commit ID is
    91064382.
    
    You can compare the current commit with the commit 9106...
    to see what differs.
    
    The current commit has to be considered non-working.
    The commit following the current commit will fix problems with
    the work in the current commit.
    
    If you use git bisect, don't spend time analyzing the current
    commit.
open-nfapi.oai.patch 894.53 KiB
diff --git a/common/public_inc/debug.h b/common/public_inc/debug.h
index 05e9870..14f97a1 100644
--- a/common/public_inc/debug.h
+++ b/common/public_inc/debug.h
@@ -39,7 +39,8 @@ extern nfapi_trace_fn_t nfapi_trace_g;
 extern nfapi_trace_level_t nfapi_trace_level_g;
 
 /*! NFAPI trace macro */
-#define NFAPI_TRACE(level, format, ...) { if(nfapi_trace_g && ((nfapi_trace_level_t)level <= nfapi_trace_level_g)) (*nfapi_trace_g)(level, format, ##__VA_ARGS__); }
+//#define NFAPI_TRACE(level, format, ...) { if(nfapi_trace_g && ((nfapi_trace_level_t)level <= nfapi_trace_level_g)) (*nfapi_trace_g)(level, format, ##__VA_ARGS__); }
+#define NFAPI_TRACE(level, format, ...) { if (nfapi_trace_g) (*nfapi_trace_g)(level, format, ##__VA_ARGS__); }
 
 /*! Function to change the trace level 
  * \param new_level The modified trace level
diff --git a/nfapi/public_inc/nfapi_interface.h b/nfapi/public_inc/nfapi_interface.h
index 2d58c2a..f665d11 100644
--- a/nfapi/public_inc/nfapi_interface.h
+++ b/nfapi/public_inc/nfapi_interface.h
@@ -1772,7 +1772,7 @@ typedef struct {
 	uint8_t number_of_cc;
 	struct {
 		uint8_t ri_size;
-		uint8_t dl_cqi_pmi_size;
+		uint8_t dl_cqi_pmi_size[8];
 	} cc[NFAPI_MAX_CC];
 } nfapi_ul_config_aperiodic_cqi_pmi_ri_report_t;
 
diff --git a/nfapi/src/nfapi.c b/nfapi/src/nfapi.c
index 0e06963..3f017bc 100644
--- a/nfapi/src/nfapi.c
+++ b/nfapi/src/nfapi.c
@@ -823,6 +823,10 @@ uint8_t pack_tlv(uint16_t tag, void *tlv, uint8_t **ppWritePackedMsg, uint8_t *e
 		{
 			NFAPI_TRACE(NFAPI_TRACE_WARN, "Warning pack_tlv tag 0x%x does not match expected 0x%x\n", tl->tag, tag);
 		}
+                else
+                {
+			//NFAPI_TRACE(NFAPI_TRACE_ERROR, "Warning pack_tlv tag 0x%x ZERO does not match expected 0x%x\n", tl->tag, tag);
+                }
 	}
 
 	return 1;
diff --git a/nfapi/src/nfapi_p7.c b/nfapi/src/nfapi_p7.c
index a3b0141..69ff860 100644
--- a/nfapi/src/nfapi_p7.c
+++ b/nfapi/src/nfapi_p7.c
@@ -111,6 +111,8 @@ static uint8_t pack_dl_config_dci_dl_pdu_rel8_value(void* tlv, uint8_t **ppWrite
 {
 	nfapi_dl_config_dci_dl_pdu_rel8_t* value = (nfapi_dl_config_dci_dl_pdu_rel8_t*)tlv;
 	
+        //NFAPI_TRACE(NFAPI_TRACE_ERROR, "%s() dci_format:%u\n", __FUNCTION__, value->dci_format);
+
 	return ( push8(value->dci_format, ppWritePackedMsg, end) &&
 			 push8(value->cce_idx, ppWritePackedMsg, end) &&
 			 push8(value->aggregation_level, ppWritePackedMsg, end) &&
@@ -234,6 +236,8 @@ static uint8_t pack_dl_config_bch_pdu_rel8_value(void* tlv, uint8_t **ppWritePac
 {
 	nfapi_dl_config_bch_pdu_rel8_t* value = (nfapi_dl_config_bch_pdu_rel8_t*)tlv;
 	
+        //NFAPI_TRACE(NFAPI_TRACE_ERROR, "%s()\n", __FUNCTION__);
+
 	return( push16(value->length, ppWritePackedMsg, end) &&
 			push16(value->pdu_index, ppWritePackedMsg, end) &&
 			push16(value->transmission_power, ppWritePackedMsg, end));
@@ -545,6 +549,8 @@ static uint8_t pack_dl_config_request_body_value(void* tlv, uint8_t **ppWritePac
 {
 	nfapi_dl_config_request_body_t* value = (nfapi_dl_config_request_body_t*)tlv;
 
+        //NFAPI_TRACE(NFAPI_TRACE_ERROR, "%s() dci:%u pdu:%u pdsch:%u rnti:%u pcfich:%u\n", __FUNCTION__, value->number_dci, value->number_pdu, value->number_pdsch_rnti, value->transmission_power_pcfich);
+