Move all 3GPP TS 29.571 common API models to common folder
Changes
- Removed all API models from PCF, which are defined in 3GPP TS 29.571
- Auto-generated ALL models based on 3GPP TS 29.571 R16.5 using openapi-generator 1.2.1
- selected actually used API models in used_common_files.cmake to not increase compile time (50 out of 214 are used in PCF)
Background
The idea is to have these in a common sub-module for all NFs. Then, when we change/update the API models, it is changed for all NFs. As this is the way how it is structured in the 3GPP APIs, it makes sense that we follow this approach.
Note to Reviewer
All the classes in common/model/common
are auto-generated. Some of them (unused ones) even do not compile. I don't think it is necessary to review them, as we have the same auto-generated classes in all NFs.
However, in the future, we should streamline these DTOs/models. The common sub-module will help us in achieving this.
Tests
Tested using the CURL requests described in Wiki
Room for debate
We could compile the models as static library, having the advantage that we could actually compile it in the build stage of our images. The current way of selecting the actually used classes reduces the overall build time, but we cannot build it in different stages.
Merge request reports
Activity
added v2.0 + 1 deleted label
requested review from @romain.lacroix
assigned to @defosseu
OAI OAI-CN5G-PCF build (55): failed (https://jenkins-oai.eurecom.fr/job/OAI-CN5G-PCF/55/)
OAI OAI-CN5G-PCF build (56): passed (https://jenkins-oai.eurecom.fr/job/OAI-CN5G-PCF/56/)
mentioned in merge request !16 (merged)
added 42 commits
-
0f1dc767...8cfc3a31 - 40 commits from branch
develop
- 4f7e4f61 - Merge branch 'develop' into refactor_api_models_structure
- 7a64c820 - fix(pcf): unused parameter warning in common model validate class
-
0f1dc767...8cfc3a31 - 40 commits from branch
OAI OAI-CN5G-PCF build (79): passed (https://jenkins-oai.eurecom.fr/job/OAI-CN5G-PCF/79/)
- Resolved by Romain Lacroix
- Resolved by Romain Lacroix
- Resolved by Romain Lacroix
- Resolved by Romain Lacroix
- Resolved by Romain Lacroix
added 1 commit
- 1b53e37f - refact(pcf): remove redundant namespace and remove empty files
OAI OAI-CN5G-PCF build (80): failed (https://jenkins-oai.eurecom.fr/job/OAI-CN5G-PCF/80/)
OAI OAI-CN5G-PCF build (81): passed (https://jenkins-oai.eurecom.fr/job/OAI-CN5G-PCF/81/)