Skip to content
  • Randy Dunlap's avatar
    [PATCH] tpm_bios: needs more securityfs_ functions · ed5a9270
    Randy Dunlap authored
    tpm_bios.c needs securityfs_xyz() functions.
    
    Does include/linux/security.h need stubs for these, or should
    char/tpm/Makefile just be modified to say:
    
    ifdef CONFIG_ACPI
    ifdef CONFIG_SECURITY
    	obj-$(CONFIG_TCG_TPM) += tpm_bios.o
    endif
    endif
    
    drivers/char/tpm/tpm_bios.c:494: warning: implicit declaration of function 'securityfs_create_dir'
    drivers/char/tpm/tpm_bios.c:494: warning: assignment makes pointer from integer without a cast
    drivers/char/tpm/tpm_bios.c:499: warning: implicit declaration of function 'securityfs_create_file'
    drivers/char/tpm/tpm_bios.c:501: warning: assignment makes pointer from integer without a cast
    drivers/char/tpm/tpm_bios.c:508: warning: assignment makes pointer from integer without a cast
    drivers/char/tpm/tpm_bios.c:523: warning: implicit declaration of function 'securityfs_remove'
    *** Warning: "securityfs_create_file" [drivers/char/tpm/tpm_bios.ko] undefined!
    *** Warning: "securityfs_create_dir" [drivers/char/tpm/tpm_bios.ko] undefined!
    *** Warning: "securityfs_remove" [drivers/char/tpm/tpm_bios.ko] undefined!
    
    There are also some gcc and sparse warnings that could be fixed.
    (see http://www.xenotime.net/linux/doc/build-tpm.out
    
    )
    
    Signed-off-by: default avatarRandy Dunlap <rdunlap@xenotime.net>
    Cc: Serge Hallyn <serue@us.ibm.com>
    Cc: Greg KH <greg@kroah.com>
    Cc: Kylene Jo Hall <kjhall@us.ibm.com>
    Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    ed5a9270