• Geert Uytterhoeven's avatar
    spi: Fix crash with double message finalisation on error handling · 69823005
    Geert Uytterhoeven authored
    commit 1f802f8249a0da536877842c43c7204064c4de8b upstream.
    This reverts commit e120cc0dcf2880a4c5c0a6cb27b655600a1cfa1d.
    It causes a NULL pointer dereference with drivers using the generic
    spi_transfer_one_message(), which always calls
    spi_finalize_current_message(), which zeroes master->cur_msg.
    Drivers implementing transfer_one_message() theirselves must always call
    spi_finalize_current_message(), even if the transfer failed:
     * @transfer_one_message: the subsystem calls the driver to transfer a single
     *      message while queuing transfers that arrive in the meantime. When the
     *      driver is finished with this message, it must call
     *      spi_finalize_current_message() so the subsystem can issue the next
     *      transfer
    Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@linux-m68k.org>
    Signed-off-by: default avatarMark Brown <broonie@linaro.org>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
spi.c 47.3 KB