• Johan Hovold's avatar
    USB: usb-wwan: fix multiple memory leaks in error paths · b8f0e820
    Johan Hovold authored
    Fix port-data memory leak in usb-serial probe error path by moving port
    data allocation to port_probe.
    Since commit a1028f0a ("usb: usb_wwan: replace release and disconnect
    with a port_remove hook") port data is deallocated in port_remove. This
    leaves a possibility for memory leaks if usb-serial probe fails after
    attach but before the port in question has been successfully registered.
    Note that this patch also fixes two additional memory leaks in the error
    path of attach should port initialisation fail for any port as the urbs
    were never freed and neither was the data of any of the successfully
    initialised ports.
    Compile-only tested.
    Signed-off-by: 's avatarJohan Hovold <jhovold@gmail.com>
    Signed-off-by: 's avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
usb-wwan.h 2.13 KB