Skip to content
  • Eric W. Biederman's avatar
    userns: Avoid recursion in put_user_ns · c61a2810
    Eric W. Biederman authored
    
    
    When freeing a deeply nested user namespace free_user_ns calls
    put_user_ns on it's parent which may in turn call free_user_ns again.
    When -fno-optimize-sibling-calls is passed to gcc one stack frame per
    user namespace is left on the stack, potentially overflowing the
    kernel stack.  CONFIG_FRAME_POINTER forces -fno-optimize-sibling-calls
    so we can't count on gcc to optimize this code.
    
    Remove struct kref and use a plain atomic_t.  Making the code more
    flexible and easier to comprehend.  Make the loop in free_user_ns
    explict to guarantee that the stack does not overflow with
    CONFIG_FRAME_POINTER enabled.
    
    I have tested this fix with a simple program that uses unshare to
    create a deeply nested user namespace structure and then calls exit.
    With 1000 nesteuser namespaces before this change running my test
    program causes the kernel to die a horrible death.  With 10,000,000
    nested user namespaces after this change my test program runs to
    completion and causes no harm.
    
    Acked-by: default avatarSerge Hallyn <serge.hallyn@canonical.com>
    Pointed-out-by: default avatarVasily Kulikov <segoon@openwall.com>
    Signed-off-by: default avatar"Eric W. Biederman" <ebiederm@xmission.com>
    c61a2810