Skip to content
Snippets Groups Projects
Commit b3334dbc authored by frtabu's avatar frtabu
Browse files

A fix proposal for phy simulators compilation Pb.

parent a01e93be
No related branches found
No related tags found
8 merge requests!1757Draft: Use pMAX value in configuration file, instead of hardcoded '23' in asn1_msg.c,!1493fix DL arq errors in UE,!1093Issue in generating NR PRACH for High Speed case,!1074PBCH test case support for non-zero bchpyload,!918Develop nfapi,!847Nr vcd,!774Nr rrc configuration merge develop,!738Nr rrc configuration
Hide whitespace changes
Inline Side-by-side
  • Francois TABURET @frtabu ·
    Developer

    This is a proposal to fix the nr_dlsim and nr_ulsim compilation problem. I included softmodem-common.c in these target sources and added also a PHYSICAL_SIMULATOR compilation macro in CMakefile.txt. Testing the PHYSICAL_SIMULATOR macro in softmodem-common.c allows to prevent inclusion of unwanted code when compiling PHY simulators.

  • Florian Kaltenberger @florian.kaltenberger ·
    Owner

    ok, I wasn't aware of the macro PHYSICAL_SIMULATOR. But I think there is still a piece missing. phy_test is still a local variable to nr_[dl|ul]dlsim and setting it won't have an impact. We need to replace it with get_softmodem_params()->phy_test, don't we?

  • Francois TABURET @frtabu ·
    Developer

    The macro PHYSICAL_SIMULATOR has been added, it was not there previously; Yes there shouldn't be any reference to a local phy_test variable, i may have missed it.

  • Francois TABURET @frtabu ·
    Developer

    Done here ad0eba1e

0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment