Skip to content
Snippets Groups Projects
  1. Jun 11, 2020
  2. Jun 08, 2020
  3. Jun 05, 2020
  4. Jun 04, 2020
  5. Jun 03, 2020
  6. May 29, 2020
  7. May 28, 2020
  8. May 27, 2020
  9. May 26, 2020
  10. May 25, 2020
  11. May 20, 2020
  12. May 15, 2020
  13. May 14, 2020
  14. May 11, 2020
  15. May 09, 2020
  16. May 07, 2020
    • Cédric Roux's avatar
      rlc v2: some fixes for 'bugs' found by coverity scan · 21a2a8c6
      Cédric Roux authored
      Minor fixes, doesn't change anything. Not sure these are 'bugs' either,
      but let's be polite with coverity scan...
      
      One thing was not changed.
      Coverity scan says:
      *** CID 357991:  Memory - illegal accesses  (USE_AFTER_FREE)
      /home/carabe/raphael/openairinterface5g/openair2/LAYER2/rlc_v2/rlc_entity_am.c: 507 in tx_list_remove_sn()
      501         } else {
      502           prev = cur;
      503           cur = cur->next;
      504         }
      505       }
      506
      >>>     CID 357991:  Memory - illegal accesses  (USE_AFTER_FREE)
      >>>     Using freed pointer "head.next".
      507       return head.next;
      508     }
      509
      510     void cleanup_sdu_list(rlc_entity_am_t *entity)
      511     {
      512       rlc_sdu_t head;
      
      But as far as I understand, there is no problem. We don't access
      head.next at all if it has been freed. Or is there some aliasing
      going on there (pointer aliasing)? I doubt it. False positive?
      21a2a8c6
    • Raphael Defosseux's avatar
    • Raphael Defosseux's avatar
      CI: better code guideline analysis · 2a8dacc0
      Raphael Defosseux authored
      
      -- check if C file has a GNU GPL license
      -- check if C file has s suspect license
      -- check if C header is having correct circular dependency protection (with Laurent Thomas's help)
      
      Signed-off-by: default avatarRaphael Defosseux <raphael.defosseux@eurecom.fr>
      2a8dacc0
Loading