[CI] test rfsim sa

test branch for SA:
develop-NR_SA_F1AP_5GRECORDS + ci_sa_rfsim_test

Are you sure? if not, put back 2 and change the .c file(s) where the loop uses 3.

There is srb3 in the specs, but as far as I know we don't support it, so if this is just to fix a warning, then put 2 and change the loop to 2 instead.

Thanks.

Hi @Cedric.Roux, with nr_pdcp_entity_t *srb[3] we are expecting to have until srb2, because we have srb[0] (for srb0), srb[1] (for srb1), and srb[2] (for srb2). Are we thinking wrong?

actually srb[0] stores srb1 and srb[1] stores srb2. See the functions in nr_pdcp_oai_api.c, we do:

      rb = ue->srb[rb_id - 1];

where rb_id is either 1 or 2.

I see a lot of comparisons with 3 in nr_pdcp_oai_api.c but it should be 2. Only srb1 and srb2 are handled today. So look for "srb" in nr_pdcp_oai_api.c and check that all the tests accept only 1 and 2 but not 3.

@Cedric.Roux, thank you for your clarification. We were confused about srb0. It is now fixed as you suggested. Thank you very much.

added 5G-NR label

OAI RAN-Container-Parent build (346): passed (https://jenkins-oai.eurecom.fr/job/RAN-Container-Parent/346/)

OAI RAN-CI-develop build (1750): Some Changed files in Merge Request DO NOT follow OAI Formatting Rules

added 1 commit

• 9f277aab - fix syntax error

Compare with previous version

OAI RAN-CI-develop build (1750): failed (https://open5glab.eurecom.fr:8083/jenkins/job/RAN-CI-develop/1750/)

OAI RAN-Container-Parent build (348): failed (https://jenkins-oai.eurecom.fr/job/RAN-Container-Parent/348/)

OAI RAN-CI-develop build (1752): Some Changed files in Merge Request DO NOT follow OAI Formatting Rules

OAI RAN-CI-develop build (1752): failed (https://open5glab.eurecom.fr:8083/jenkins/job/RAN-CI-develop/1752/)

assigned to @defosseu

changed milestone to %REVIEW_IN_PROGRESS

Code Review by : Raphael Defosseux

• IMPACT on Python Framework
  • A new tool/lib/package has been introduced (blocking, subject to negotiation)
    • Jenkins Python Agent image requires update.
• DOCUMENTATION (The Merge Request requires additional documentation)
  • Has NOT the new Python code sufficient comment added for better maintenance?

Notes: since it's a temporary implementation of the 5G RF Sim in Standalone mode, it's OK to merge.

Once the review remark is fixed.

approved this merge request

resolved all threads

added 1 commit

• 84799675 - add/update sa conf file

Compare with previous version

OAI RAN-Container-Parent build (351): passed (https://jenkins-oai.eurecom.fr/job/RAN-Container-Parent/351/)

OAI RAN-CI-develop build (1755): Some Changed files in Merge Request DO NOT follow OAI Formatting Rules

OAI RAN-CI-develop build (1755): failed (https://open5glab.eurecom.fr:8083/jenkins/job/RAN-CI-develop/1755/)

closed